From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 8CD1845619;
Fri, 12 Jul 2024 19:30:49 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 7E16A42EFB;
Fri, 12 Jul 2024 19:30:49 +0200 (CEST)
Received: from us-smtp-delivery-124.mimecast.com
(us-smtp-delivery-124.mimecast.com [170.10.133.124])
by mails.dpdk.org (Postfix) with ESMTP id B732842790
for <dev@dpdk.org>; Fri, 12 Jul 2024 19:30:47 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
s=mimecast20190719; t=1720805447;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:cc:mime-version:mime-version:content-type:content-type:
content-transfer-encoding:content-transfer-encoding:
in-reply-to:in-reply-to:references:references;
bh=sRJNGszk0yuzFL7tphq3ozWHAYKtqUgIJL9HUMkkGZs=;
b=UFYPb25nRT8t54YIMgsNwRmPwojJ6rAfN95x7V3QpiiYsvAoXfcFK4+IH6NFUX+pexOuF9
OqiwHjdrsymi/wloQtUfH55Wcu67HmQVTFKYux+G8tYSjzy7iskR/I46jMaQNWtfBRNMp2
/a9Gi3W37MmNE/7FleVjwnDoF3/Dq6k=
Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com
[209.85.208.198]) by relay.mimecast.com with ESMTP with STARTTLS
(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id
us-mta-306--on4YJZzOmeZke3nlfjYLQ-1; Fri, 12 Jul 2024 13:30:46 -0400
X-MC-Unique: -on4YJZzOmeZke3nlfjYLQ-1
Received: by mail-lj1-f198.google.com with SMTP id
38308e7fff4ca-2eedeca0c52so1273951fa.0
for <dev@dpdk.org>; Fri, 12 Jul 2024 10:30:45 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1720805444; x=1721410244;
h=content-transfer-encoding:cc:to:subject:message-id:date:from
:in-reply-to:references:mime-version:x-gm-message-state:from:to:cc
:subject:date:message-id:reply-to;
bh=sRJNGszk0yuzFL7tphq3ozWHAYKtqUgIJL9HUMkkGZs=;
b=vl+2LWUMrl9kYpF+gLhbXGIas6DRYs0Duv6NDoGehonrDTXlkx8Zh8mKjNk9dv/Rb3
xTbNgyhgIb0yIrN9dsB+WXIeDZAEC0IULJNM3LhALknXkdGVfUYrkh3hsHUH+L8oneW6
08UgcrHUTwX6hX0UhJhd+xKuFCB0D1wAjZQsmCobz+ZxYXDBO0A/gDM3zLCnwLIOHU43
4fsSw3w4RaDGXIlsw3xeVkmuTmVbMoB6UK4OD4KAyKJaSSNKOYHvRWbv7rxugE5g8hH+
LC/4PsNYrW5/p5GOCjJU/4P6pHGUYek5ftrLF/1w8Tz1K/n21LGoAEPpghA+KXzi+a73
6WLA==
X-Gm-Message-State: AOJu0Yz0NyChvD4u4OgcDLshYIU3hxtn0dRdyyTblq1NghlzNV3QXQcv
S4Pqi/JQZ/uaT9mRTpO5bkJLy0mJVxpsXc1jKJizC7uHrRPY/R6qTW4d1RaTpo7vq2QdGr1kYFZ
99LeyJ9iFvRyJY58OOaVRvHRs5CmASVyJzr29DMpxXh+8BN1PwhFRkGKt1uN4zGt5gGatSRufmH
MD1YwTZdT1jVEulmE=
X-Received: by 2002:a2e:8e8c:0:b0:2ee:8698:10ed with SMTP id
38308e7fff4ca-2eeb3190d76mr75327721fa.49.1720805444503;
Fri, 12 Jul 2024 10:30:44 -0700 (PDT)
X-Google-Smtp-Source: AGHT+IF0eVAMcVtAl+vEX0TS2rOLJaa1eJo5yjFATfEQJhvn7phlkNENOOn3wn07qA9X5qfJvS0okUYN67EI69EdFig=
X-Received: by 2002:a2e:8e8c:0:b0:2ee:8698:10ed with SMTP id
38308e7fff4ca-2eeb3190d76mr75327611fa.49.1720805444079; Fri, 12 Jul 2024
10:30:44 -0700 (PDT)
MIME-Version: 1.0
References: <20240702021946.4194102-1-chaoyong.he@corigine.com>
<20240702074007.1547-1-chaoyong.he@corigine.com>
<20240702074007.1547-3-chaoyong.he@corigine.com>
In-Reply-To: <20240702074007.1547-3-chaoyong.he@corigine.com>
From: David Marchand <david.marchand@redhat.com>
Date: Fri, 12 Jul 2024 19:30:32 +0200
Message-ID: <CAJFAV8xL3Uv_S1TYWGZHWX16GBaOnnfLgbQHumXePRCXNv8SDg@mail.gmail.com>
Subject: Re: [PATCH v6 2/2] bus/pci: fix secondary process save 'FD' problem
To: Chenbo Xia <chenbox@nvidia.com>
Cc: dev@dpdk.org, oss-drivers@corigine.com, Zerun Fu <zerun.fu@corigine.com>,
mukawa@igel.co.jp, stable@dpdk.org, Long Wu <long.wu@corigine.com>,
Peng Zhang <peng.zhang@corigine.com>,
Anatoly Burakov <anatoly.burakov@intel.com>,
Chaoyong He <chaoyong.he@corigine.com>
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Hello,
On Tue, Jul 2, 2024 at 9:40=E2=80=AFAM Chaoyong He <chaoyong.he@corigine.co=
m> wrote:
>
> From: Zerun Fu <zerun.fu@corigine.com>
>
> In the previous logic the 'fd' was only saved in the primary process,
> but for some devices this value is also used in the secondary logic.
>
> For example, the call of 'rte_pci_find_ext_capability()' will fail in
> the secondary process.
>
> Fix this problem by getting and saving the value of 'fd' also in the
> secondary process logic.
>
> Fixes: 9b957f378abf ("pci: merge uio functions for linux and bsd")
> Cc: mukawa@igel.co.jp
> Cc: stable@dpdk.org
>
> Signed-off-by: Zerun Fu <zerun.fu@corigine.com>
> Reviewed-by: Chaoyong He <chaoyong.he@corigine.com>
> Reviewed-by: Long Wu <long.wu@corigine.com>
> Reviewed-by: Peng Zhang <peng.zhang@corigine.com>
> Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
Chenbo,
Are you ok with this fix?
Thanks.
--=20
David Marchand