From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 521CDA00C2; Thu, 6 Oct 2022 21:34:02 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 43AAD400D6; Thu, 6 Oct 2022 21:34:02 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 05E5140042 for <dev@dpdk.org>; Thu, 6 Oct 2022 21:34:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1665084840; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Kr05kQ5COL6EMxQCtWhzt0WNBe8P89razg5qWwXynF4=; b=NSiBSdXfCVx2A44AAAACOVqO1aBPz4wUJJWGbYux8kUqL+CKhEpKRKk4TmfrFRITloreVm W2Q96D30St3hWS/TvlPXRM/p3zVgsO6mXfvGVhDVVywKwuLJebvC0rfNGAfK/tBqa5LqsK TOASCqK9MxrGauGkHICYwtDVl+sEfJ8= Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-425-w7HRZAauNNWt4uo405BAeQ-1; Thu, 06 Oct 2022 15:33:59 -0400 X-MC-Unique: w7HRZAauNNWt4uo405BAeQ-1 Received: by mail-pf1-f199.google.com with SMTP id cb7-20020a056a00430700b00561b86e0265so1630743pfb.13 for <dev@dpdk.org>; Thu, 06 Oct 2022 12:33:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date; bh=Kr05kQ5COL6EMxQCtWhzt0WNBe8P89razg5qWwXynF4=; b=WNVaHD8oPiDUVPN35yLqK8InAGMpG8eu1/hovdntbVWSzQp82ED7iyGLWVRdoC2r2c JzEknUeHmM2DQMv7dozGEy5qHsKT8TzTmpQxAvk+78S2QuBWKWox1+1F6oGaluemNLWs 1lBxnDK5phd1sTf0A6PqoW6qfh7CANMkNmNU/nMMb0JDxi6WDQ2u+rAqDUCG6pZNkgKb pajsYRHWuRmrcUqFwo7lJvDVmsdKX+wb5QZtloo/1msSEIUo+CvsVfJsSTLCYeMS8wop XohSwnrwWyv5OKttYfSRPQYsRpTgUP+qIEt32pTaJgWLmlDkXS3AoYekMyvHU8w7HviQ Sw4w== X-Gm-Message-State: ACrzQf10ZA0DseOBMcAu337/V8zqt+X6pWVGZzZkSNLhwV1bzKWwXnAJ Fuw5t/lKwbjURc4rLnFlAo3tnAnzoGfy+/tTgRN7tSt5j9nbaVUhjT5FwTtallyaBk4oxi7oX1V O3hAp1QGAOWNXrGsXKAE= X-Received: by 2002:a63:2307:0:b0:458:4d0b:a21f with SMTP id j7-20020a632307000000b004584d0ba21fmr1227706pgj.120.1665084838485; Thu, 06 Oct 2022 12:33:58 -0700 (PDT) X-Google-Smtp-Source: AMsMyM50DZrfeL/g97rSNhH8GdjDjek/cdyeaRDmyFmLnpZLKFstz2jv+a3m4pTqOZmcRWPshdwqcVUangbtKkblr9w= X-Received: by 2002:a63:2307:0:b0:458:4d0b:a21f with SMTP id j7-20020a632307000000b004584d0ba21fmr1227686pgj.120.1665084838236; Thu, 06 Oct 2022 12:33:58 -0700 (PDT) MIME-Version: 1.0 References: <20221006081729.578475-1-harry.van.haaren@intel.com> <20221006125247.1018265-1-harry.van.haaren@intel.com> <98CBD80474FA8B44BF855DF32C47DC35D873A1@smartserver.smartshare.dk> In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35D873A1@smartserver.smartshare.dk> From: David Marchand <david.marchand@redhat.com> Date: Thu, 6 Oct 2022 21:33:46 +0200 Message-ID: <CAJFAV8xL9wYC3ij9ut5A8GDd8_a5cMzkPzw9TNhnhUF229n-ng@mail.gmail.com> Subject: Re: [PATCH v3] test/service: fix spurious failures by extending timeout To: Harry van Haaren <harry.van.haaren@intel.com> Cc: dev@dpdk.org, dpdklab@iol.unh.edu, ci@dpdk.org, Honnappa.Nagarahalli@arm.com, mattias.ronnblom@ericsson.com, thomas@monjalon.net, =?UTF-8?Q?Morten_Br=C3=B8rup?= <mb@smartsharesystems.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On Thu, Oct 6, 2022 at 3:27 PM Morten Br=C3=B8rup <mb@smartsharesystems.com= > wrote: > > This commit extends the timeout for service_may_be_active() > > from 100ms to 1000ms. Local testing on a idle and loaded system > > (compiling DPDK with all cores) always completes after 1 ms. > > > > The wait time for a service-lcore to finish is also extended > > from 100ms to 1000ms. > > > > The same timeout waiting code was duplicated in two tests, and > > is now refactored to a standalone function avoiding duplication. > > > > Reported-by: David Marchand <david.marchand@redhat.com> > > Suggested-by: Mattias Ronnblom <mattias.ronnblom@ericsson.com> > > Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com> > Acked-by: Morten Br=C3=B8rup <mb@smartsharesystems.com> Reviewed-by: Mattias R=C3=B6nnblom <mattias.ronnblom@ericsson.com> Ok, let's see if the situation gets better with this. Applied, thanks. --=20 David Marchand