From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 43C1CA0C4C; Mon, 20 Sep 2021 09:25:29 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C6B4340DF7; Mon, 20 Sep 2021 09:25:28 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id EAB4A40DF5 for ; Mon, 20 Sep 2021 09:25:26 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1632122725; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=M0H2WUD+eCxQIC9eXWdorhb+Wi6rjiCa0A6GnIbXmVA=; b=ijw17+6/oAoYrJdalfXgkFuAQY31fP5LuqaBAu8CfLkWV/xF+MUJQvdy8okoJSpbn2ReFa vb6ZvL3yxxqfhw99TF3qBZQqtY5zjdkzpJV8q3e0Vuc/pK8pBrTs03j7sk7SQVO6+jBrRU nSTQj6D/OVly5uKHVyaEcIfn08fFO0k= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-543-YIEhY7RXOjyV28JcY64b-w-1; Mon, 20 Sep 2021 03:25:22 -0400 X-MC-Unique: YIEhY7RXOjyV28JcY64b-w-1 Received: by mail-lf1-f72.google.com with SMTP id s8-20020ac25c48000000b003faf62e104eso7986704lfp.22 for ; Mon, 20 Sep 2021 00:25:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=M0H2WUD+eCxQIC9eXWdorhb+Wi6rjiCa0A6GnIbXmVA=; b=usKI4qZNUWDLDWDVVR0VBQZ0o9w8u/EMVU86+cvlRAdyY7xQQkZx3is6VEObdRj9ZT uHONdiqJCyK7Jr6QnyX8xpSfd+KsnrC3GTrB2Zbdz+Q6Ww4TptONv69YKRRTyc3vpq+B GiPa1oyYM+pM/a9C0nS9JiWRkextcroUxpx36jiMKEvBu1dolWZr7adDTw24vWvtwbFe 5rcYpHV9cmAPo/5InEK2axRSQo1LDt/OmwSSf9y9AVkqeWT4zniMU62T/IwxNOAk+JY2 2c3T4b3K+6JCHEmxbHYBigiKzinI5hAgTpClHvr+PdHgqXpoSZsAZCFtORGoG6ywhiXP s3dQ== X-Gm-Message-State: AOAM530xMFBlDqgREnl+AIkOGAP0PbsG/EVrpF9reAU9uGNFXxdNKhna I+jZe0NsL7XnizMevQ/6NDmKMvSn9mO2EUAByJVvqPYQbKFPTzg8TkZpRqnAXVp7Z0PmEOSwNzV 34rN37eW7FVSzoDGxuQQ= X-Received: by 2002:a2e:91d4:: with SMTP id u20mr15031403ljg.81.1632122720914; Mon, 20 Sep 2021 00:25:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxeugMkVBQCSn9zkBKeFoDx1MQGGGTKrjxh/is6330ZxQ/Hq/bJg5ZiZ4bA0ADoxfM5djbl6rdNRL04xxpuwDo= X-Received: by 2002:a2e:91d4:: with SMTP id u20mr15031377ljg.81.1632122720645; Mon, 20 Sep 2021 00:25:20 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: David Marchand Date: Mon, 20 Sep 2021 09:25:09 +0200 Message-ID: To: Yunjian Wang , "Wang, Haiyue" , "Yigit, Ferruh" Cc: dev , Beilei Xing , Qiming Yang , Qi Zhang , dingxiaoxiong@huawei.com, Renata Saiakhova Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2 0/4] delete HW rings when releasing queues for some drivers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sat, Sep 18, 2021 at 10:34 AM Yunjian Wang wrote: > > This series for deleting HW rings when releasing queues for > igb, ixgbe, i40e, ice & em drivers. > > --- > v2: > * Update commit log > > Yunjian Wang (4): > net/e1000: delete HW rings when releasing queues > net/ice: delete HW rings when releasing queues > net/i40e: delete HW rings when releasing queues > net/ixgbe: delete HW rings when releasing queues > > drivers/net/e1000/em_rxtx.c | 8 ++++++-- > drivers/net/e1000/igb_rxtx.c | 9 +++++++-- > drivers/net/i40e/i40e_fdir.c | 3 --- > drivers/net/i40e/i40e_rxtx.c | 8 ++++++-- > drivers/net/i40e/i40e_rxtx.h | 2 ++ > drivers/net/ice/ice_rxtx.c | 6 ++++-- > drivers/net/ice/ice_rxtx.h | 2 ++ > drivers/net/ixgbe/ixgbe_rxtx.c | 6 ++++-- > drivers/net/ixgbe/ixgbe_rxtx.h | 2 ++ > 9 files changed, 33 insertions(+), 13 deletions(-) > - In net/ice (at least), the fdir rxq/txq memzones can be aligned on the same scheme. Looking at the remaining drivers (net/cnxk, net/cxgbe and net/octeontx2), we could apply the same principle of keeping a reference to mz in internal driver structures. Afterwards, I see no need to keep rte_eth_dma_zone_free() (it's internal, so we can remove and it's easy to re-add if a need arises). Wdyt? - Is this worth backporting to stable branches? -- David Marchand