Re: [EXTERNAL] [PATCH v3 2/6] trace: support dereferencing arguments

[David Marchand <david.marchand@redhat.com>]

On Tue, Feb 11, 2025 at 9:44 AM Sunil Kumar Kori <skori@marvell.com> wrote:
>
> > diff --git a/lib/eal/common/eal_common_trace_ctf.c
> > b/lib/eal/common/eal_common_trace_ctf.c
> > index 04c4f71462..3e4228ee7f 100644
> > --- a/lib/eal/common/eal_common_trace_ctf.c
> > +++ b/lib/eal/common/eal_common_trace_ctf.c
> > @@ -373,6 +373,11 @@ rte_trace_metadata_dump(FILE *f)
> >
> >  char *trace_metadata_fixup_field(const char *field)  {
> > +     static const char * const tokens[] = {
> > +             ".",
> > +             "->",
> > +             "*",
> > +     };
> As this patch is intended to support dereferencing operation but as a side effect it applies to multiplication operator too.

Support for multiplication helps with the next patch too, when passing
an array size as a blob length.

> Hence for A * B, field is generated like A___B (one extra underscore). So IMO, multiplication string shouldn't be used.

I am not following the consequence.. why should it be prevented?


-- 
David Marchand