From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 0B862A0561;
	Tue, 21 Apr 2020 09:49:46 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id D3C141D8E9;
	Tue, 21 Apr 2020 09:49:45 +0200 (CEST)
Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com
 [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id 8A3591D8E1
 for <dev@dpdk.org>; Tue, 21 Apr 2020 09:49:44 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
 s=mimecast20190719; t=1587455384;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
 content-transfer-encoding:content-transfer-encoding:
 in-reply-to:in-reply-to:references:references;
 bh=9/EofYpTFJU15G+GHQEMLwHLJpnj/v1V6U8hHhmyDh8=;
 b=T6CdHcTd372KXo/pf7g7zlA4JRP7PwajtdgqAHPtibRKjixQlGOxFblGPod6szS4zoY278
 Du6Bf7OVfYIHUHsmdHv2PGiXlLIjiNyEdvJx5+l5Q6vAsZbzPwngCzpoEC/Iv7xvx0WknV
 KTypzJSb38vKyuRCgVS6Y6GBV9GxsW4=
Received: from mail-il1-f199.google.com (mail-il1-f199.google.com
 [209.85.166.199]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-475-D_RG6EYmNQuP5oJuIPGOjw-1; Tue, 21 Apr 2020 03:49:42 -0400
X-MC-Unique: D_RG6EYmNQuP5oJuIPGOjw-1
Received: by mail-il1-f199.google.com with SMTP id y2so15334346ilm.8
 for <dev@dpdk.org>; Tue, 21 Apr 2020 00:49:41 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=ZORrchCD3KqYMiyGpVOCbL+heS6zTb/AhuJzEbhfKMo=;
 b=C6xy5K3sfnxHVYf1qExbpMN/FXCVyWkjXUfOw/6n99KZXfnzyW6WZJpcpWdS9boML+
 9FVga31fZsqjbphj+z6qcXy1JV8+k2rUXHLqdz5kzLQhWfwYrhxv9SvKg4ZGYmpOXFQO
 gZ3XZLWZzoZNyiB4MIHBI3d4FjSE4mZv2H9ofSxwzOYiVdTsK8cdNF+JPK6pAaQZ5UaT
 WQKV6Ynb7esEl8FVxNpmBKCvLCdUcVmrypzt4EJ44h/K8u47eB2nFXxfkS1NsbJJgov6
 2WjAvgtTL7po8pPQMbyn1yRXo6ibxCo+1IW5+mcXBmLLqm5vFvwW1/PF4x8zpt+bgiPg
 Nnfg==
X-Gm-Message-State: AGi0PuZ2G5FjCanVfi0zdifEcSguRUUm5YgwkBJitmhDaeVSbcQb3H9a
 I7bB7w+ggOH3gglwnH1Eupv+H4ziFQoBOHc5UPkdOYAP3FFjKgz86Z0bTsoEHX9cy3/ud6IkvIL
 JI0YNXnhYgRgSpYzIrXU=
X-Received: by 2002:a5e:df06:: with SMTP id f6mr19374108ioq.177.1587455381350; 
 Tue, 21 Apr 2020 00:49:41 -0700 (PDT)
X-Google-Smtp-Source: APiQypKBGOZVDFKVpAoUlcGdN8NhgWEk38OJOz6cjIDInspomz69J43x0Gi2NHOlrA8oN9ZqiPmOs5Y9hgLNAsqmtvw=
X-Received: by 2002:a5e:df06:: with SMTP id f6mr19374091ioq.177.1587455381041; 
 Tue, 21 Apr 2020 00:49:41 -0700 (PDT)
MIME-Version: 1.0
References: <20200421020455.505176-1-thomas@monjalon.net>
In-Reply-To: <20200421020455.505176-1-thomas@monjalon.net>
From: David Marchand <david.marchand@redhat.com>
Date: Tue, 21 Apr 2020 09:49:30 +0200
Message-ID: <CAJFAV8xLmSNtiTvgZk3fDoCvKaks8obG9Cv6dtAuuRY5yneDmg@mail.gmail.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev <dev@dpdk.org>, Bruce Richardson <bruce.richardson@intel.com>
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Subject: Re: [dpdk-dev] [PATCH] devtools: remove useless files from ABI
	reference
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, Apr 21, 2020 at 4:05 AM Thomas Monjalon <thomas@monjalon.net> wrote=
:
>
> When building an ABI reference with meson, some static libraries
> are built and linked in apps. They are useless and take a lot of space.
> Those binaries, and other useless files (examples and doc files)
> in the share/ directory, are removed after being installed.
>
> In order to save time when building the ABI reference,
> the examples (which are not installed anyway) are not compiled.
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
>  devtools/test-meson-builds.sh | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson-builds.s=
h
> index e8df017596..16271e057d 100755
> --- a/devtools/test-meson-builds.sh
> +++ b/devtools/test-meson-builds.sh
> @@ -141,10 +141,15 @@ build () # <directory> <target compiler> <meson opt=
ions>
>                         fi
>
>                         rm -rf $abirefdir/build
> -                       config $abirefdir/src $abirefdir/build $*
> +                       config $abirefdir/src $abirefdir/build -Dexamples=
=3D $*
>                         compile $abirefdir/build
>                         install_target $abirefdir/build $abirefdir/$targe=
tdir
>                         $srcdir/devtools/gen-abi.sh $abirefdir/$targetdir
> +
> +                       # save disk space by removing static libs and app=
s
> +                       rm $abirefdir/$targetdir/usr/local/lib/*.a

The install directory for libraries is not lib/ in all cases.
This breaks the ABI generation for gcc-shared:

DESTDIR=3D/home/dmarchan/abi/v20.02/build-gcc-shared ninja -C
/home/dmarchan/abi/v20.02/build install >/dev/null
rm: cannot remove
'/home/dmarchan/abi/v20.02/build-gcc-shared/usr/local/lib/*.a': No
such file or directory

$ ls ~/abi/v20.02/build-gcc-shared/usr/local/
bin  include  lib64  share


--=20
David Marchand