From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4366F45547; Tue, 2 Jul 2024 10:53:23 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 33011402AD; Tue, 2 Jul 2024 10:53:23 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 229874028A for ; Tue, 2 Jul 2024 10:53:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1719910401; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DuCbDIhX91doxMjzkl9bnEKth1w4rseVlAb5XRDnbXI=; b=iC4Ls1N96RpDLSXDTovIHJ+1oB0hFwucOXBjuWG+vcHd7YU+bil8uMPJFsGmBwtj3fdZsZ ol7I/vSB8owWeWQNAVsq82/dMWAaqGcOeWLjskSgvmZv5glQg9Ho/0Dv1jFlQuRqqqk7/K aRDjefqaskpbxn2kJn/1hj/DWq94/ss= Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-378-BcGFpRJKN9GK3wIuEW2Xxg-1; Tue, 02 Jul 2024 04:53:20 -0400 X-MC-Unique: BcGFpRJKN9GK3wIuEW2Xxg-1 Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-2c95f724bb2so281527a91.0 for ; Tue, 02 Jul 2024 01:53:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719910399; x=1720515199; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DuCbDIhX91doxMjzkl9bnEKth1w4rseVlAb5XRDnbXI=; b=Bgcplo9OR9UQDMuMEZGcN+L8cMxA65+UxafzneMpGR32WlPtzAi08qcLtf+gt4HRxV Zrfxh4hRUg8Yoj6ud+E50pdzZhMWWGeUh8/ZPuc5Wz20Tet36NmyKjxfSTw5mVbiq2V1 9V/toYD8QQH/oRrszu84vyN9XcmzMOsn45wPmO1sCg6bNjnlZ4s/ppPZQqYCUvxItMeR qzeApfadl8Nx5gzPKtsYRopMxJg0DGBWLmZpZw3fjXN8kQlxyeY8Ut+z+nmopqpKX1j0 9BlOiRDYpFASs5VkimGvJJLAA7iAFnvG9J5hHteA3ZkvFm4rWKDYFF+tY6LAAYvyH2cG 3e7w== X-Gm-Message-State: AOJu0YxotbE21vBy5hj9bj74Yz91Jz8GSxlEZkiXEphnQKrmmo8Ek+aZ IzRSVlmjr2bDAY6qrHUlmha0K/aup3LNqHSAFYshcJvl9zJdGZbtq3jOedTD48JB5mqdExCjMnh JcuNQts1IuqGdb8MZtgGe2BRvIBf5mx7xWzNcVREVDgob32fcQb6U5RgKYO1kT1ziNL3m5U8B8k PJgX7mciV85HXWjSo= X-Received: by 2002:a17:90b:f0a:b0:2c4:a9b8:2f2e with SMTP id 98e67ed59e1d1-2c93d7439b0mr4656227a91.20.1719910399167; Tue, 02 Jul 2024 01:53:19 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGT4BG7/8QV1LozOS/LThk0DT3dauBLruiC9RYpHD8mPjZSaTym+1/re0UGulEnwSge4iNYLB1F9EWtyspP21M= X-Received: by 2002:a17:90b:f0a:b0:2c4:a9b8:2f2e with SMTP id 98e67ed59e1d1-2c93d7439b0mr4656219a91.20.1719910398788; Tue, 02 Jul 2024 01:53:18 -0700 (PDT) MIME-Version: 1.0 References: <20240701082751.3479106-1-li.hanxiao@zte.com.cn> In-Reply-To: <20240701082751.3479106-1-li.hanxiao@zte.com.cn> From: David Marchand Date: Tue, 2 Jul 2024 10:52:58 +0200 Message-ID: Subject: Re: [PATCH] zsda:introduce zsda drivers and examples To: lhx Cc: dev@dpdk.org, Akhil Goyal , Thomas Monjalon X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hello, Thanks for the submission. On Tue, Jul 2, 2024 at 10:42=E2=80=AFAM lhx wrote: > > From: =3D Hanxiao Li There is an extra =3D sign here, please remove. > > Introduce zsda (ZTE Storage Data Accelerator) drivers and examples, > which can help to accelerate some calculation process. It looks like this is an upstreaming effort for code written against DPDK v21.11. There are unrelated / broken changes (probably due to some rebase issue). Please fix at least what I quickly noticed: - no version.map if unneeded, - no touching of rte_config.h like disabling RTE_BACKTRACE, - don't reintroduce renamed headers, like for example rte_cryptodev_pmd.h, - don't remove "dma" device support in usertools/dpdk-devbind.py, - don't introduce a hardware specific example, Important: overall, this patch should be split in logical smaller patches introducing feature one at a time. And for next revisions, please version your patches, and register to the dev@ mailing list and patchwork. --=20 David Marchand