From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 304D7A0A03; Mon, 18 Jan 2021 09:18:25 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E2B1D140D1A; Mon, 18 Jan 2021 09:18:24 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mails.dpdk.org (Postfix) with ESMTP id 93AAB140D12 for ; Mon, 18 Jan 2021 09:18:23 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1610957903; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1amxqV2icCT88gsyBYEQlL/in9LJ/rL4LvZfDYJgcPg=; b=ZqWTfUwMiwjiI0alyex65P8T2x4HYDcsXDv9TNaV7YfXxH0IGe42AMsIQXlTvvqJEW8Uw1 1JhD9Cb0JSuD5GSgNuLWmBKLv/Ufc2SV2Tg5c2bx7Kt/J+1W237YE0eiEeL6kT8uBOAeNI 60pmSEv8bSe9QWa0GyWgwvOyeM1faf0= Received: from mail-ua1-f72.google.com (mail-ua1-f72.google.com [209.85.222.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-520-icUoYc_bPX6JeoE1w7tdhA-1; Mon, 18 Jan 2021 03:18:19 -0500 X-MC-Unique: icUoYc_bPX6JeoE1w7tdhA-1 Received: by mail-ua1-f72.google.com with SMTP id 9so5100416uas.17 for ; Mon, 18 Jan 2021 00:18:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1amxqV2icCT88gsyBYEQlL/in9LJ/rL4LvZfDYJgcPg=; b=SjQr/HM0qojoidQgbRRU120IRUGi+9xuo1s8pLc+PMv8hiOKD5iWYo/MWNtw1P2wIZ E2biNkhk0ImTFoR5Fdy7Ik07pwb/PfqRw6Me6AlFUS+dpfCjcncRkcnlzhVgkc/vz8Oo rHS0ZZTl7vy/MnEGgMz4if+YMjLjfP0olDg0XX38cA3UUl8OX+GZ+2hooVOT3FQmqgBw EYsJK5rGwEXThSAAGhsUbcnXHRx25UqKjnFSKDr3Q9oXWAV91j90DqoMmhdMZhhyOesx YJPVCZDJZqlSjS6GNYj7exVQ3KwCSgmrH1taisYsNzouxvlvGBulRzlkPjnz4srMi/SU /j0w== X-Gm-Message-State: AOAM530f9MojJFzJcrTtkpbTEC1dS9xA6SQQHuGHw9YvG+fr9ISAe0Tb FdIejjsg5oF0jEakdAMDQOUeaGGm5XW8o2l+XW2A9ncSYC2NI2+K1snr1RLwTkEYkQAuJ/S2y9L QRUOOsUtWEhLsrftzafk= X-Received: by 2002:a1f:9e83:: with SMTP id h125mr17777086vke.18.1610957898800; Mon, 18 Jan 2021 00:18:18 -0800 (PST) X-Google-Smtp-Source: ABdhPJwW6nHzLwuNm7mcHSRlUpByMBV6Qoj2JuRRO8t75TdmwP0j3SHjxn1v3wC6O1hkAVE+QGKSTjCP5+QGfn8DATI= X-Received: by 2002:a1f:9e83:: with SMTP id h125mr17777079vke.18.1610957898602; Mon, 18 Jan 2021 00:18:18 -0800 (PST) MIME-Version: 1.0 References: <20210115134021.7391-1-david.marchand@redhat.com> <20210115134021.7391-2-david.marchand@redhat.com> In-Reply-To: From: David Marchand Date: Mon, 18 Jan 2021 09:18:07 +0100 Message-ID: To: Ruifeng Wang Cc: "dev@dpdk.org" , "ferruh.yigit@intel.com" , "stable@dpdk.org" , Ziyang Xuan , Xiaoyun Wang , Guoyang Zhou , Ciara Power , "thomas@monjalon.net" , nd Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 1/3] net/hinic: restore vectorised code X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sat, Jan 16, 2021 at 3:39 PM Ruifeng Wang wrote: > > Subject: [PATCH 1/3] net/hinic: restore vectorised code > > > > Following make support removal, the vectorised code is not built anymore, > > fix the build flag check. > > > > Fixes: 3cc6ecfdfe85 ("build: remove makefiles") > > Cc: stable@dpdk.org > > > > Signed-off-by: David Marchand > > --- > > drivers/net/hinic/hinic_pmd_rx.c | 6 +++--- > > drivers/net/hinic/hinic_pmd_tx.c | 10 +++++----- > > 2 files changed, 8 insertions(+), 8 deletions(-) > > > > diff --git a/drivers/net/hinic/hinic_pmd_rx.c > > b/drivers/net/hinic/hinic_pmd_rx.c > > index a49769a863..842399cc4c 100644 > > --- a/drivers/net/hinic/hinic_pmd_rx.c > > +++ b/drivers/net/hinic/hinic_pmd_rx.c > > @@ -4,7 +4,7 @@ > > > > #include > > #include > > -#ifdef __ARM64_NEON__ > > +#ifdef RTE_ARCH_ARM64 > > We can test '__ARM_NEON' which will be defined by compilers. > https://developer.arm.com/documentation/ihi0053/latest/ On the principle, I agree, but this was not what was tested before. The activation was only gated by checking for the arm architecture. See: https://git.dpdk.org/dpdk/tree/drivers/net/hinic/Makefile?id=05b6eee7bdabf7c17ed69c44515e0cd7d6e1da23#n14 So I restored the test as it was before make removal. What you propose can be done in a followup from the hinic developers, but the minimal fix is still this current patch. -- David Marchand