From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9AC0EA3168 for ; Wed, 16 Oct 2019 17:16:20 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6E15F1E969; Wed, 16 Oct 2019 17:16:20 +0200 (CEST) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) by dpdk.org (Postfix) with ESMTP id E0FB71E95F for ; Wed, 16 Oct 2019 17:16:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1571238978; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zE07cMggu5VN8jYkDH3tPbHhvAl9b5wZ9VQBM+CZUM4=; b=Q3Gu0zRBDYp/fNUBu997gbSgJWvJlTG1X+A2emmBbehkjetQUFJx/q/0I3S1qBeY6GJ+kC m5IjXqElsvldqoAF84TuZUaIRE5V2X0egRzXq80xNIwcQ8OiaHWy1DA6FknvwHCOmbL6Ym 8zztJ6+SDO6zx9V3r2YLbDxaz/oZUjQ= Received: from mail-ua1-f72.google.com (mail-ua1-f72.google.com [209.85.222.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-37-PtA7kERLOL6VTDminnqSkA-1; Wed, 16 Oct 2019 11:16:16 -0400 Received: by mail-ua1-f72.google.com with SMTP id q60so5410100uaq.11 for ; Wed, 16 Oct 2019 08:16:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pXDresLlhPcL0frFbAtuhjspvozvv+70XRuN0KjygM8=; b=mSq4cKpXt/AyGN+m5fNxNXWT3az6vtZRwO/waTU2f0vprbc99HwBXtCTYiB6nSqZaQ 6URYOAbr6ctJiHDNmGnxhxAhHAM2g6FLMeH921ir47ywFUmAIkQ+Ekqqp+BDnCOn95Mu U53ezwtCga5PMHiJEzwmBGdv9HLCYYVCpUjak1rTkDPkzWePpq3HCvRfshuHSKLzCQ6v 0c66al6GAmIU6IOLMfpftzQEzGU8JxlaZGNAPv8ubjkEp/YN3yilRwreAqp0TJJzOgQ+ /eZ/1G3TxhUFqkqo1jFhYAbnOTmahVCrdCF03xA1PRCLzOJrkJB8Fr3hodoiGOJwcLEs +j6g== X-Gm-Message-State: APjAAAVb9CQdB5OfXcfA3SfYXlOrZ4YZEDVSu9pZwfBD8QUNwFJ7cjDi wFUOyNNoIIuXkntA5M+BmWFTTxXzRwXaJG+6S/IER04sd5gb+jdZcfaafe9/V4+IZPOCxN8lbsU NiDcbY3Syj9rL3H3WenI= X-Received: by 2002:a05:6102:387:: with SMTP id m7mr175225vsq.105.1571238976289; Wed, 16 Oct 2019 08:16:16 -0700 (PDT) X-Google-Smtp-Source: APXvYqzIlE3/3Z204ynHdKfw1H8A1qBPYuDy2NvxvweQcNkVhuF5uhFmJBZaFoKk21yRX5LgZ9oalcOcPK0hxUkuQvk= X-Received: by 2002:a05:6102:387:: with SMTP id m7mr175200vsq.105.1571238975933; Wed, 16 Oct 2019 08:16:15 -0700 (PDT) MIME-Version: 1.0 References: <20190925214223.79362-1-drc@linux.vnet.ibm.com> In-Reply-To: <20190925214223.79362-1-drc@linux.vnet.ibm.com> From: David Marchand Date: Wed, 16 Oct 2019 17:16:04 +0200 Message-ID: To: David Christensen Cc: "Burakov, Anatoly" , dev X-MC-Unique: PtA7kERLOL6VTDminnqSkA-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH] eal:ppc: fix incorrect ifdef for ppc_64 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Sep 25, 2019 at 11:42 PM David Christensen wrote: > > An ifdef present in eal_memory.c references "RTE_ARCH_PPC64" when > it should actually use "RTE_ARCH_PPC_64". Simple testing revealed > that both the PPC_64 and non-PPC_64 versions of the code involved > work, but the PPC_64 version of the code is retained to be > consistent with other instances in the same file where mmapped > memory is accessed in reverse order on Power platforms. The change itself is not that scary, but just reading this commitlog I fail to see the impact for an application. Can you share some light? > > Fixes: 66cc45e ("mem: replace memseg with memseg lists") Fixes sha1 should be on 12 digits. Should we copy stable ? > Cc: Anatoly Burakov > > Signed-off-by: David Christensen > --- > lib/librte_eal/linux/eal/eal_memory.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/librte_eal/linux/eal/eal_memory.c b/lib/librte_eal/linux= /eal/eal_memory.c > index 1c089a1ef..1bbdd8a29 100644 > --- a/lib/librte_eal/linux/eal/eal_memory.c > +++ b/lib/librte_eal/linux/eal/eal_memory.c > @@ -688,7 +688,7 @@ remap_segment(struct hugepage_file *hugepages, int se= g_start, int seg_end) > return -1; > } > > -#ifdef RTE_ARCH_PPC64 > +#ifdef RTE_ARCH_PPC_64 > /* for PPC64 we go through the list backwards */ > for (cur_page =3D seg_end - 1; cur_page >=3D seg_start; > cur_page--, ms_idx++) { > -- > 2.18.1 > Thanks. --=20 David Marchand