From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 01687A0471 for ; Fri, 21 Jun 2019 18:47:44 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C75DB1D558; Fri, 21 Jun 2019 18:47:43 +0200 (CEST) Received: from mail-vk1-f196.google.com (mail-vk1-f196.google.com [209.85.221.196]) by dpdk.org (Postfix) with ESMTP id 649671D54F for ; Fri, 21 Jun 2019 18:47:42 +0200 (CEST) Received: by mail-vk1-f196.google.com with SMTP id 130so1424543vkn.9 for ; Fri, 21 Jun 2019 09:47:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ej53Wb1dev17mOum3xeqbAW7ZV0njHPrrh1BTkmz2K4=; b=R0rRQyOD4CkeuE7VslPGokYZTATz0klr6WO750SkJwgI0RGcdks3Bv4QYtAenPNyC0 KaPF+Kj8GNQRz9MN3LjeCmhrJH5OkcV3jE8ws+K6tcNpjw0PYYPmxqsxqgzrEMmU3MxI B8FJtOUE7wJ9RdPLdX0cOvZUBfKDkDvMV73YwaNg1zcZYHpyC6Zsj2OZHRWLsgaXp/zS 2bPES97Kifb7HsadVVrngKf+gnnQW4k/ieFJuhaAHEUy6A21x/Q7T1Dekj0CGOeuDldc VvfA5VE47AwcH6UrhV6sYhgiT8gHfzcOF6dKEVBe61+WoVGHnXKOFjnW8sZdRgUhwL// Gcxw== X-Gm-Message-State: APjAAAX5mE48uL+VX+2s1RVux+e1BeBSHMn8KevHflznPEmBwTxGJrun ykI6ZInrHJREtg7DNScJDMgoMoO2S++k8xbCOHm1mQ== X-Google-Smtp-Source: APXvYqzaa7OxOUZlA9wfKagI5Gpo8TuHXNE9cvy/d5VJdMtPyR4l24EFv/fAqSY7hno4lizTddaHc+H+A7kwwZkjbx8= X-Received: by 2002:a1f:50c1:: with SMTP id e184mr10117200vkb.86.1561135661812; Fri, 21 Jun 2019 09:47:41 -0700 (PDT) MIME-Version: 1.0 References: <20190620164206.3972-1-gage.eads@intel.com> <20190621162726.GA21895@hmswarspite.think-freely.org> In-Reply-To: <20190621162726.GA21895@hmswarspite.think-freely.org> From: David Marchand Date: Fri, 21 Jun 2019 18:47:31 +0200 Message-ID: To: Neil Horman Cc: Aaron Conole , Adrien Mazarguil , Gage Eads , dev , Jerin Jacob Kollanukkaran , Van Haaren Harry , Nikhil Rao , Erik Gabriel Carrillo , Bruce Richardson , Pablo de Lara Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] eal: promote some service core functions to stable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Jun 21, 2019 at 6:28 PM Neil Horman wrote: > On Fri, Jun 21, 2019 at 02:45:45PM +0200, David Marchand wrote: > > Ok, did a new pass on the tree.. found quite some sites where we have > > issues (and other discrepancies... I started a new patchset). > > Looked at gcc documentation [1], and to me the safer approach would be to > > enforce that __rte_experimental is the first thing of a symbol > declaration. > > > > Comments? > > > Yes, thats the only way it works, in fact I'm suprised gcc didn't throw an > error > about expecting an asm statement if you put it anywhere else > - I tried this, but then I hit issues with inlines. Like for example: static inline char * __rte_experimental rte_mbuf_buf_addr(struct rte_mbuf *mb, struct rte_mempool *mp) { return (char *)mb + sizeof(*mb) + rte_pktmbuf_priv_size(mp); } I did not find a way to move the __rte_experimental tag without getting warnings. If I try to compile some sources which includes rte_mbuf.h but without -DALLOW_EXPERIMENTAL_API, then gcc errors at including the header, complaining that rte_mbuf_buf_addr() is deprecated, even if this inline is not called. For now, I hid all those inlines under the ALLOW_EXPERIMENTAL_API flag. - I have accumulated other fixes and I dropped all the marking in the .c files. This ended up with a huge series... 118 files changed, 867 insertions(+), 646 deletions(-) https://github.com/david-marchand/dpdk/commits/experimental I will let the week end pass on this. -- David Marchand