From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id 815B6A054F;
Tue, 18 Feb 2020 10:41:20 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 3F7991C012;
Tue, 18 Feb 2020 10:41:20 +0100 (CET)
Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com
[205.139.110.61]) by dpdk.org (Postfix) with ESMTP id B22001BFF3
for <dev@dpdk.org>; Tue, 18 Feb 2020 10:41:18 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
s=mimecast20190719; t=1582018878;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:cc:mime-version:mime-version:content-type:content-type:
content-transfer-encoding:content-transfer-encoding:
in-reply-to:in-reply-to:references:references;
bh=b4vZFIExod9J6Ypp/oYn2qyBMQ3M4EhdAWeNWsuLZf4=;
b=ABuAsATAjT3tM7HRyMjBuWL3ZyG+/aRlGSt4LPh5k3OhtWDiVCDb1Uj9xgGzo7tXbPBiop
UgJC2ZTFwnaDDMQD1NBFmEMKNbgA/SzOhLd60ItWJYlQb9/lufra7e3dyLU71xeyVcphg5
DRTrolK9E6n0Kf0IB2+bAGQCifUKVJw=
Received: from mail-vk1-f197.google.com (mail-vk1-f197.google.com
[209.85.221.197]) (Using TLS) by relay.mimecast.com with ESMTP id
us-mta-258-qOxMeQ3cP56zGuFYVw_L5w-1; Tue, 18 Feb 2020 04:41:08 -0500
Received: by mail-vk1-f197.google.com with SMTP id y28so7895987vkl.23
for <dev@dpdk.org>; Tue, 18 Feb 2020 01:41:07 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:mime-version:references:in-reply-to:from:date
:message-id:subject:to:cc;
bh=JaMm74LFiWRsR9tZH5hRo7BQbvqvW42lnwLjO8bFLQo=;
b=uaVu2rjuKo7fYUcHuWmzG1xCtuLXL1/VDu6/ahmD8Iq/J9yWb1LSLRyhJwREpx94D0
tCkcFsdNpgDBmRnCinmJE44v5TAGaoV/tQH9PggTmwYoTSj6IyMNrOuNs7oL1lEbj/jG
BSV48i17eTK5gy7oQeukDipOaVHoTz3d8dtXStpvngBHy9iH4z1PJ+z4YlqFKhPInIn+
vNYznEqsk0ysOOQ4RWstvjtNgy2wxEEPWL18NLKQrrznpOpeX1oxz6eMzrcXtnTc/dZa
c1mGzAJZDVMeUifD8mRLjB+7YL8jYU850gSWOv4CXfJXb7swnEwl/u/AITGnbHqJrMgL
1v4A==
X-Gm-Message-State: APjAAAX6ozhAsuWIzKP+yI6S3f2shgiUTVQG8BUAE8ySrOKQLmv4iJpk
Io2/igbpAAXkbkIWDaQTS3IftiW3cF8S+gUUSH06ocNAhaPSaglWO9u9MmhcWFMYD4X+ZF2AaUL
b0IKelH9b5pM51xffj/g=
X-Received: by 2002:a67:f315:: with SMTP id p21mr10501783vsf.39.1582018867088;
Tue, 18 Feb 2020 01:41:07 -0800 (PST)
X-Google-Smtp-Source: APXvYqzkGs5iV5v/7aCA+DGBwXBTlqC+QtTpZC2RfrQ/+eR7HCduz4/mKrPpVn6O/PL1Eek8cVmiSxExfGfeAXDTTlk=
X-Received: by 2002:a67:f315:: with SMTP id p21mr10501771vsf.39.1582018866799;
Tue, 18 Feb 2020 01:41:06 -0800 (PST)
MIME-Version: 1.0
References: <20200217135929.30987-1-david.marchand@redhat.com>
<f7tftf9uk2y.fsf@dhcp-25.97.bos.redhat.com>
In-Reply-To: <f7tftf9uk2y.fsf@dhcp-25.97.bos.redhat.com>
From: David Marchand <david.marchand@redhat.com>
Date: Tue, 18 Feb 2020 10:40:55 +0100
Message-ID: <CAJFAV8xNg=La+90vH=Ry1u0KDWcbKSyTNaN6e896=GLwxRnrkQ@mail.gmail.com>
To: Aaron Conole <aconole@redhat.com>
Cc: Thomas Monjalon <thomas@monjalon.net>, dev <dev@dpdk.org>,
Christian Ehrhardt <christian.ehrhardt@canonical.com>,
Dodji Seketeli <dodji@redhat.com>,
Michael Santana <maicolgabriel@hotmail.com>
X-MC-Unique: qOxMeQ3cP56zGuFYVw_L5w-1
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Subject: Re: [dpdk-dev] [PATCH] ci: build and use libabigail 1.6
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
On Mon, Feb 17, 2020 at 7:48 PM Aaron Conole <aconole@redhat.com> wrote:
>
> David Marchand <david.marchand@redhat.com> writes:
>
> > libabigail 1.2 (at least) reports changes in 'const' property as an ABI
> > breakage [1].
> > This was fixed upstream in libabigail 1.4 [2], and a bug has been opene=
d
> > in launchpad [3].
> >
> > But for now, build and use the last version 1.6 so that the ABI checks
> > can be kept.
> >
> > 1: https://travis-ci.com/DPDK/dpdk/jobs/287872118#L2242
> > 2: https://sourceware.org/git/gitweb.cgi?p=3Dlibabigail.git;a=3Dcommitd=
iff;h=3D215b7eb4fe8b986fe1cc87d9d8e7412998038392
> > 3: https://bugs.launchpad.net/ubuntu/+source/libabigail/+bug/1863607
> >
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
> > ---
>
> Does it make sense to base libabigail required ontop of extra packages?
> Otherwise some libraries won't get built / checked, no?
The only change I see is the pcap driver being enabled.
On the principle, I agree that trying to build all possible
libraries/drivers is better when checking the ABI.
So I'll keep extra_packages yes.
I am currently testing that touching extra_packages (well, testing
Thomas patches) results in Travis treating the job as a new one (i.e.
with no cache).
>
> > .ci/linux-build.sh | 22 ++++++++++++++++++++++
> > .travis.yml | 15 ++++++++++-----
> > 2 files changed, 32 insertions(+), 5 deletions(-)
> >
> > diff --git a/.ci/linux-build.sh b/.ci/linux-build.sh
> > index c7c3840fc..0d4bc9a62 100755
> > --- a/.ci/linux-build.sh
> > +++ b/.ci/linux-build.sh
> > @@ -38,6 +38,28 @@ if [ "$AARCH64" !=3D "1" ]; then
> > fi
> >
> > if [ "$ABI_CHECKS" =3D "1" ]; then
> > + LIBABIGAIL_REPO=3D${LIBABIGAIL_REPO:-https://sourceware.org/git/li=
babigail.git}
> > + LIBABIGAIL_VERSION=3D${LIBABIGAIL_VERSION:-libabigail-1.6}
> > +
> > + if [ "$(cat libabigail/VERSION 2>/dev/null)" !=3D "$LIBABIGAIL_VER=
SION" ]; then
> > + rm -rf libabigail
> > + # if we change libabigail, invalidate existing abi cache
> > + rm -rf reference
> > + fi
> > +
> > + if [ ! -d libabigail ]; then
> > + git clone --single-branch -b $LIBABIGAIL_VERSION $LIBABIGAIL_R=
EPO libabigail/src
> > + cd libabigail/src && autoconf -vfi && cd -
And I managed to send a "oh yeah, seems better this way"/untested version..=
.
Fixed.
--
David Marchand