DPDK patches and discussions
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: Harry van Haaren <harry.van.haaren@intel.com>
Cc: dev <dev@dpdk.org>,
	fredrik.a.lindgren@tietoevry.com,
	 Jerin Jacob Kollanukkaran <jerinj@marvell.com>
Subject: Re: [dpdk-dev] [PATCH] eventdev: remove return value comment in pmd api
Date: Mon, 1 Feb 2021 14:27:31 +0100	[thread overview]
Message-ID: <CAJFAV8xNvLoMB-LYmt-ErTfHGAPz4mTQ+Qm9U5NaGgt_wh7B0Q@mail.gmail.com> (raw)
In-Reply-To: <20210201131946.133378-1-harry.van.haaren@intel.com>

On Mon, Feb 1, 2021 at 2:20 PM Harry van Haaren
<harry.van.haaren@intel.com> wrote:
>
> The PMD info get API has a void return type. Remove the
> @return 0 Success doxygen comment as it doesn't make sense here.

Fixes: 5223a1f3b8de ("eventdev: define southbound driver interface")
Cc: stable@dpdk.org

>
> Reported-by: Fredrik A Lindgren <fredrik.a.lindgren@tietoevry.com>
> Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>
> ---
>  lib/librte_eventdev/eventdev_pmd.h | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/lib/librte_eventdev/eventdev_pmd.h b/lib/librte_eventdev/eventdev_pmd.h
> index 9e83993efa..7eb9a77393 100644
> --- a/lib/librte_eventdev/eventdev_pmd.h
> +++ b/lib/librte_eventdev/eventdev_pmd.h
> @@ -158,9 +158,6 @@ rte_event_pmd_is_valid_dev(uint8_t dev_id)
>   *   Event device pointer
>   * @param dev_info
>   *   Event device information structure
> - *
> - * @return
> - *   Returns 0 on success
>   */
>  typedef void (*eventdev_info_get_t)(struct rte_eventdev *dev,
>                 struct rte_event_dev_info *dev_info);
> --
> 2.25.1
>

LGTM.

-- 
David Marchand


  reply	other threads:[~2021-02-01 13:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-01 13:19 Harry van Haaren
2021-02-01 13:27 ` David Marchand [this message]
2021-02-04 18:16   ` Jerin Jacob

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJFAV8xNvLoMB-LYmt-ErTfHGAPz4mTQ+Qm9U5NaGgt_wh7B0Q@mail.gmail.com \
    --to=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=fredrik.a.lindgren@tietoevry.com \
    --cc=harry.van.haaren@intel.com \
    --cc=jerinj@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).