From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 911F8454ED; Tue, 25 Jun 2024 09:35:53 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 66DD1402A3; Tue, 25 Jun 2024 09:35:53 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id BDC5C40151 for ; Tue, 25 Jun 2024 09:35:51 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1719300951; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/928Wv9104ZTp0sIs8cPI5zOSPq+0WA8TOUnmY1FDCY=; b=TVaJ47D9nyq2gHK+Br8FDeGET2+Xpe2xploc9mICqwdX/9G/DK31m1wWPNzc80UlWKTUeH 4g3zqyBZLHCUeYB5DTdiw2IaqxKm6mAIwe/ZTPyEGJfsinilR0fXuPGKSi5jyeD440GRdD oqs1nOp/Vzt8lgn05t386cdFGHdbiRA= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-689-4jXuzB-SM7O_HUtTubHo4g-1; Tue, 25 Jun 2024 03:35:49 -0400 X-MC-Unique: 4jXuzB-SM7O_HUtTubHo4g-1 Received: by mail-lj1-f200.google.com with SMTP id 38308e7fff4ca-2ec584f36bfso17575891fa.3 for ; Tue, 25 Jun 2024 00:35:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719300948; x=1719905748; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/928Wv9104ZTp0sIs8cPI5zOSPq+0WA8TOUnmY1FDCY=; b=aopApE/xSXBzgfjW2YRu8N/P3uIq8TpacNPx4/6bDOOyM7rgPFqigrtNJ2TK/tkrfF Z9ypuhwGQVA2avtJOHhfN18ZGUEqOzXJkHbK/yNiKaRiANxc4lGJwzDG35dFAexwJRO8 HAKWr4ISX+LRokUUUcswPrJ197b/tVqNnJRk10vDExnR+YgITWEk038VGyMlQwmjTCEU RbuN4tJ4FIHHb4fRiAjVGw9VDYw9nbQ0Ct5YcWI4Kwe1g037IYp+ui3jo0sXXZoDVXr9 nfPXlCm905LG3nHRn7qvYWkGxFC0i1l+3wLlruuopCOwMI+dwY42X96DFwWzsgd+OsQ9 iL9g== X-Gm-Message-State: AOJu0YyxsaZK0j6t9ypMpydumusDLwmZ74FqMhSs4HK8TiPEggKVpJE0 8bOtlpQf7rdDBbxQDc1Fo/N54pse5rfvZbrds79hIqG4dSUqhcNcJW/xl/D7AMr6p5dW8YULbFL mcUjBUjuH7JGoMsgjLKBObYgOzwjGBTxGCrKjWLRBUmTiuwbo8MyXuXE2ZcARKFnsOyGSGD9kpz qEhiArLQQmDmT2YXw= X-Received: by 2002:a05:651c:1991:b0:2ec:5bb2:c236 with SMTP id 38308e7fff4ca-2ec5bb2c276mr50159361fa.33.1719300948068; Tue, 25 Jun 2024 00:35:48 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGNt8IuR234jckMXym723uCAwpS1gY97Mz9Mrnbtq6LgI4efa2Kj87sY32pxJKfE3NGlnqI3+zXAEWWMYL0L7U= X-Received: by 2002:a05:651c:1991:b0:2ec:5bb2:c236 with SMTP id 38308e7fff4ca-2ec5bb2c276mr50159271fa.33.1719300947757; Tue, 25 Jun 2024 00:35:47 -0700 (PDT) MIME-Version: 1.0 References: <20240624144613.1855582-1-maxime.coquelin@redhat.com> In-Reply-To: <20240624144613.1855582-1-maxime.coquelin@redhat.com> From: David Marchand Date: Tue, 25 Jun 2024 09:35:36 +0200 Message-ID: Subject: Re: [PATCH] vhost: only emit debug log with invalid FD To: Maxime Coquelin Cc: dev@dpdk.org, chenbox@nvidia.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Jun 24, 2024 at 4:46=E2=80=AFPM Maxime Coquelin wrote: > > This patch improves the FD manager logging in case > of FD removal from the epoll FD set failure. > > When the FD is not more valid, like for example if it is not valid anymore* > has already been closed, only emit a debug log and not > an error one. > > Fixes: 0e38b42bf61c ("vhost: manage FD with epoll") > > Reported-by: David Marchand > Signed-off-by: Maxime Coquelin I tested with OVS dpdk-latest and the patch lgtm. Reviewed-by: David Marchand --=20 David Marchand