From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7C248A0524; Fri, 6 Nov 2020 11:44:50 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DFABB5AB3; Fri, 6 Nov 2020 11:44:47 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by dpdk.org (Postfix) with ESMTP id 941135AB2 for ; Fri, 6 Nov 2020 11:44:44 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1604659482; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jw3bUg2AarOEo8r1O4Akytlszj07AIq7dpbYeJSq69o=; b=HqCikyJhRb3gmR5DjucVibjtHoiKigMrZETxmHsbkFS4OWqYFAijF4o8BdZpUR5Dyn/TCz 6u/8W1Vz//AXLB5h+WcYL+s9rg6iW9QEEAvBDZvSE3XSLuH5jbFV+yNF06mesIrk3RU9aL OLd5wRXy6aLLlypyp7+X7TACa7+/rTU= Received: from mail-vs1-f70.google.com (mail-vs1-f70.google.com [209.85.217.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-216--lYAmiC-No2CMaJT4KXAxQ-1; Fri, 06 Nov 2020 05:44:40 -0500 X-MC-Unique: -lYAmiC-No2CMaJT4KXAxQ-1 Received: by mail-vs1-f70.google.com with SMTP id u14so368812vsp.2 for ; Fri, 06 Nov 2020 02:44:39 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jw3bUg2AarOEo8r1O4Akytlszj07AIq7dpbYeJSq69o=; b=azcC9Px+X7pOJrI9d73nfP4u9UVkGtl2/aHrGsn+c0mhbiPC0WwYB8xjxK+1rRQK8V 8oX9CjBBZl9CmjK7raeRApQjnBrriYLyuV/BesJDfWqg+3bHafJKomdcnvCkcGeUqX0m qDPc+vzG5/KLyTJyxOARIGQ60mR6EIIUcp5V+N84plmccAz/SvkFdQKDpBupw4NFS9vm 9Dw1snxqgPr24zoQaYjLQC+IqnjjLtjaEZWZOqxgTL6+1M/BvB3SdWYxmvxsqiMBA1vH lwU6dNJAcz8f/hozjG7Kcw35YaBSdCQ3LrKH3sxb2NJa/lFYqjGfeuXRnYXW8Q32JqDb +i+g== X-Gm-Message-State: AOAM531bdw+xoFkXdTlKnoM/Fub2PgDeCsSFs/ByWfSi/gts2Q5nCUWQ 5rhHdRhW4nByeNWGVoEdnOmdEmE1qgNaGCkNsi5YjvdI5Mk9+I7r+HDAoJzDwShblW1BRmeoX63 42tPS+kQ2eghc1Ol2mGo= X-Received: by 2002:a67:f54b:: with SMTP id z11mr516974vsn.17.1604659479358; Fri, 06 Nov 2020 02:44:39 -0800 (PST) X-Google-Smtp-Source: ABdhPJzHBjMdZ4VOQMnf/ItkniKNdpqKw0Lfs7sy+WVyokucuhhpQ23vjjvrUDPJZqjVa4KnZMT3rN44+hT7a+kXPCk= X-Received: by 2002:a67:f54b:: with SMTP id z11mr516969vsn.17.1604659479073; Fri, 06 Nov 2020 02:44:39 -0800 (PST) MIME-Version: 1.0 References: <18966392.1bK43UoomU@xps> <20201105211716.25181-1-ncopa@alpinelinux.org> In-Reply-To: <20201105211716.25181-1-ncopa@alpinelinux.org> From: David Marchand Date: Fri, 6 Nov 2020 11:44:28 +0100 Message-ID: To: Natanael Copa Cc: dev Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] Build fixes for musl libc X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hello Natanael, On Thu, Nov 5, 2020 at 10:17 PM Natanael Copa wrote: > > A set of patches to fix build with musl libc. I also did a few cleanups wrt > macros and fixed a few scary compiler warnings while at it. > > Please note that those are only compile tested on x86_64 with musl libc. > > v2 has some code style fixes reported by checkpatch > > v3 is a full reroll of the entire patch set to enable automatted tests > and logic for patchwork patchset. > > v4 rebase against main and deal with renames/moves. > fix commit messages to make check-git-log.sh happy. > improve error(3) -> warn(3) patch and clarify commit message. > update __WORDSIZE patch to use RTE_ARCH_64 > add "Fixes:" tags > add a couple of patches fro eal > > Sorry that it took so long time to follow up. > > Natanael Copa (8): > app/testpmd: fix uint build error with musl libc > net/cxgbe: fix uint build error with musl libc > bus/pci: add fallback for out* for non GNU libc > bus/dpaa: use warn instead of error to improve portability > bus/dpaa: fix detection of 64 bit arch > common/dpaax: build fix for musl libc > common/dpaax: simplify pr debug/err/warn macros > eal: add missing include to fix build with musl libc - I suppose you got the mails with the build errors from the robot. Build is broken in dpaa (missing a few includes). https://travis-ci.com/github/ovsrobot/dpdk/jobs/429242867#L1005 - I still see a uint use in drivers/net/igc. How about: diff --git a/drivers/net/igc/igc_flow.c b/drivers/net/igc/igc_flow.c index 1bb64d323c..66053060af 100644 --- a/drivers/net/igc/igc_flow.c +++ b/drivers/net/igc/igc_flow.c @@ -656,7 +656,7 @@ igc_parse_action_rss(struct rte_eth_dev *dev, * Return the pointer of the flow, or NULL for failed **/ static inline struct rte_flow * -igc_alloc_flow(const void *filter, enum igc_filter_type type, uint inbytes) +igc_alloc_flow(const void *filter, enum igc_filter_type type, size_t inbytes) { /* allocate memory, 8 bytes boundary aligned */ struct rte_flow *flow = rte_malloc("igc flow filter", -- David Marchand