From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9453DA0C47; Tue, 12 Oct 2021 14:39:05 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5B4494111E; Tue, 12 Oct 2021 14:39:05 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 9ABB2410FC for ; Tue, 12 Oct 2021 14:39:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1634042343; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=RvxgsDPVgVOHWu27vpkf/OkYpCUL4vJxKi0TqVfg1dY=; b=H5y4MMZ4ElZjkb2KDSD+wy9JxaGTpKLaaMTOOJwJKH8p6Fc6Cfu1nbvTmedWlU0F9AuO8T 24Y/lymz4MxUzd9tGfpaTgw6rIEoGnA6dW9W8bf2Q29JF2PL8SrywJbQOyQPf8mJbJdFOh T9hqTK+uE2foLqBL2CiMhhTU/B0gdP0= Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-199-F8SETfRcPSyqRujsrJOXbg-1; Tue, 12 Oct 2021 08:39:01 -0400 X-MC-Unique: F8SETfRcPSyqRujsrJOXbg-1 Received: by mail-lf1-f70.google.com with SMTP id i6-20020a056512318600b003fd8c8c2677so4793613lfe.1 for ; Tue, 12 Oct 2021 05:39:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=RvxgsDPVgVOHWu27vpkf/OkYpCUL4vJxKi0TqVfg1dY=; b=V+ZotBLUHjeFFUR607WNxyijkygpwKErVTTAYQcHIC2axgcfWhRJDdON+8JdBQV2Eb uSv9MSi6SzztRSRhKDSUoeEJj+wqNKhFEHBHKO05GQ+TFwys/CTVrFppfKE/rKTD+tYQ BLymYLzchax8GlTUdBIfyX8vniK+rJmYPmO+uCUJM87Vo0kCBc/GsHifLkLoC3BoNYPd r4FrdI7VU3zwf2kUNdGIs4bFnQVbJnrxl8iIpSWyjYCp4Wy+8uNSTGoySGuozHhZaGoD 971TJ4HuEtd/RERrla00fEZ8IDewTRcMwcpHmASSqNczho7qfI0sGsUklgFE1ZmIeo67 4n2A== X-Gm-Message-State: AOAM533QLuS/VE1o6PDiLD3p9hzgIf389AUs7QFzgevLiAk2Ohg/VMzv RiGA7zodhnoSIil/fw9SXerKycEY/W7/LrTtO0uX9yfksKmUDHUjH8Tr9truhLMKx5LvKKxRdDt yGpJp4sA2suusSEwlWKw= X-Received: by 2002:a2e:2f02:: with SMTP id v2mr28083024ljv.46.1634042340395; Tue, 12 Oct 2021 05:39:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJywxPiBxk9wYTgBfnQKM+2qRWO6Y557uIYwJJhxryNtxfCV7eyPiG6qq3CmWP6utzjAlXg+YnPPgOQihPv3Src= X-Received: by 2002:a2e:2f02:: with SMTP id v2mr28082994ljv.46.1634042340105; Tue, 12 Oct 2021 05:39:00 -0700 (PDT) MIME-Version: 1.0 References: <1705686.Ar61aiJpx4@thomas> <20210809112434.383123-1-john.levon@nutanix.com> In-Reply-To: From: David Marchand Date: Tue, 12 Oct 2021 14:38:48 +0200 Message-ID: To: John Levon , "dmitry.kozliuk@gmail.com" Cc: "dev@dpdk.org" , "anatoly.burakov@intel.com" , "thomas@monjalon.net" Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] eal: allow hugetlbfs sub-directories X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Aug 17, 2021 at 10:05 PM John Levon wrote: > On Mon, Aug 09, 2021 at 12:24:34PM +0100, John Levon wrote: > > > get_hugepage_dir() was implemented in such a way that a --huge-dir > > option had to exactly match the mountpoint, but there's no reason for > > this restriction: DPDK might not be the only user of hugepages, and > > shouldn't assume it owns an entire mountpoint. For example, if I have > > /dev/hugepages/myapp, and /dev/hugepages/dpdk, I should be able to > > specify: > > > > --huge-dir=/dev/hugepages/dpdk/ > > > > and have DPDK only use that sub-directory. > > > > Fix the implementation to allow a sub-directory within a suitable > > hugetlbfs mountpoint to be specified, preferring the closest match. > > > > Signed-off-by: John Levon > > --- > > v2: prefer closer matches > > v3: checkpatch fixes > > v4: fix docs, added tests > > Anyone like to (re) review? Your patch lgtm, I tested a few scenarios I had in mind and it looks ok. Dmitry offered to rebase after your patch, can you send a new revision with following updates? - This patch only concerns Linux, so the title prefix should be eal/linux, - Jerin asked for a release notes update, a quick description is fine, - Dmitry mentionned he acked your v3, so you can add it. Thanks. -- David Marchand