From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AF931A0032; Fri, 18 Feb 2022 09:12:09 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A23C340395; Fri, 18 Feb 2022 09:12:09 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 163A740150 for ; Fri, 18 Feb 2022 09:12:07 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1645171927; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LFSPV+kaQBpUQpxW0YQ7fxlPyzCGqmn/fKMNqBbJkfw=; b=eQMjr3wB7SotrraCKtMXVlvbP/ZPumm2NY5bQlrfnJc9rKV8SwH0AHL98NSshdi1EPBGrb qofxUd5ONfon+nkgdQi4Jw3ZeHdXr0ouoa75HN3DMlFwkc1PfR/4QjCBi/5Lw0nQ4ifmDU FWmU9+L5xQahEv+BAFjjHiOWjwZMIVg= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-52-7F1TNv_kPGy2fU5VXX_JDg-1; Fri, 18 Feb 2022 03:12:04 -0500 X-MC-Unique: 7F1TNv_kPGy2fU5VXX_JDg-1 Received: by mail-lf1-f72.google.com with SMTP id f37-20020a0565123b2500b004433d9bb4feso384003lfv.22 for ; Fri, 18 Feb 2022 00:12:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=LFSPV+kaQBpUQpxW0YQ7fxlPyzCGqmn/fKMNqBbJkfw=; b=pf4PzKOrY8P5geHFE8KjY07xfF/vUzsujlZKtPZbTBdN9DD5mpya/GlAuBpQxYzqKO WicGYhulAJpTJ2/2x9g2JSHEtHvmyCkH/agalb1eTPvbaEC1lOqZBCtxJqRV33ln7bUs Jx4lxMH/Yj0Y45Ip/lnsk2s2sgW8oac85sUUTVZdMM0rGU5SBkKewrLFG41LdulNXCzg 2+EQGt5aX8+MTDkEDVjLuRFhtR+ILVMfDrhb+A/HUrdmbR9XrpDq4gGQCOdzKdKMToQ6 bRpQiO+YMCH7BAOevVykMvwI0C6yoWLj4HMyQAoI9veKUTvZdbUy0cBvOjgwwvkuLrEu XUzw== X-Gm-Message-State: AOAM531jwJjQ9nwdk7h2W4nQfCy69S9Q7D37QzF1wftEYd1TqXeNLjmQ ye6VV2D9G39p2OwKvGOZXyT/YXaiBexzEj0M2d8PYYs3LHgKkHKljgTczwmznV+DQ3mQukBEna3 /5CLriHUa7BPmGxSJJpE= X-Received: by 2002:a2e:a37a:0:b0:22d:7f2b:23c with SMTP id i26-20020a2ea37a000000b0022d7f2b023cmr4996195ljn.81.1645171922535; Fri, 18 Feb 2022 00:12:02 -0800 (PST) X-Google-Smtp-Source: ABdhPJwfx/Ae8IVxP877Lq+FFLouXh98f294udvvjNUPNvikilt+QQGviO8hoHH19DJAGpDPgQT0d0WxCFtOr6hYwuQ= X-Received: by 2002:a2e:a37a:0:b0:22d:7f2b:23c with SMTP id i26-20020a2ea37a000000b0022d7f2b023cmr4996186ljn.81.1645171922305; Fri, 18 Feb 2022 00:12:02 -0800 (PST) MIME-Version: 1.0 References: <20220218074148.2549134-1-megha.ajmera@intel.com> In-Reply-To: <20220218074148.2549134-1-megha.ajmera@intel.com> From: David Marchand Date: Fri, 18 Feb 2022 09:11:50 +0100 Message-ID: Subject: Re: [PATCH v1 0/4] sched: HQoS Library cleanup. To: Megha Ajmera Cc: dev , "Singh, Jasvinder" , Cristian Dumitrescu , Thomas Monjalon Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Feb 18, 2022 at 8:42 AM Megha Ajmera wrote: > > v1: > * Removed unused HQoS #defines from rte_config. > * Enabled stats in HQoS by default. > * TC subscription for best effort queues is always enabled in HQoS library. > * VECTOR defines are removed from HQoS library. This series does not apply on main, so we won't get tests from CI. Is this a followup of patches? https://patchwork.dpdk.org/project/dpdk/patch/20220121181459.1599739-1-megha.ajmera@intel.com/ (<-- which should be marked superseded..) https://patchwork.dpdk.org/project/dpdk/patch/20220125102105.1719667-1-megha.ajmera@intel.com/ I prefer to ask because I did not see much public discussion. Commitlogs are poor/nonexistent and the cover letter does not explain the rationale. -- David Marchand