From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7C951A0032; Fri, 21 Oct 2022 15:06:23 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7134542B9C; Fri, 21 Oct 2022 15:06:23 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 4B0DD41147 for ; Fri, 21 Oct 2022 15:06:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666357580; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=NFi2hIiXq052C3ltRgAKGxbb94qn6Pm8MDU4H9oxHzk=; b=UOP/SWedMAizDeOKcJJY+lBFL+GzZraoEYist2EEMh9dRHWB88F1D150j2JH97SxsCmmpA n8qSE/8vetUKoSdhbDM2x+bDdj9wn4L0JO9JhkKG+3zc+s3P3aeTWWMr9IdUvg506eDUFo Nm830hHTQecUG/p0Pz6m/scLEpkWBEI= Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-549-GXUpEQGxPNeNyicB5ZMr9g-1; Fri, 21 Oct 2022 09:06:19 -0400 X-MC-Unique: GXUpEQGxPNeNyicB5ZMr9g-1 Received: by mail-pj1-f72.google.com with SMTP id pa16-20020a17090b265000b0020a71040b4cso1210329pjb.6 for ; Fri, 21 Oct 2022 06:06:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=NFi2hIiXq052C3ltRgAKGxbb94qn6Pm8MDU4H9oxHzk=; b=O8Tm1nut1kp8wen+CoTgDGS6at36wLbxg6VNlIyr9LxRBZmFvHbI57g1caNLpKcwGP edbw5dr+8VRKDFogiqDbfbE2pIeIWVh0K/DbTVgI8ufuw0FCZlpBoS+5x5gUe+OGSOfg 487d6lFNkMsFk3JnkmQzVOlPrYflLSDIva2HtQjtH9Okl5+ZOmV7CWosK2DEANNeltBN 1NGLyCFsl9/EuanHonW60P972Rgnv0eTP7IeiuhXoHGl0qAf8c2QWto3dXPuKTbsjwZY CrxzhdTYoMEoFeyBqOYQ2bkwwNLxzGzfy6AaBK77sRNi+s31kPpka/wzYd+omaOnUEy9 HfeA== X-Gm-Message-State: ACrzQf0TmhD7qCn9QJ1AECvCvkw53k393k1lIfG8Xz5CM/M/7CTbQwFg 0viaUB7nWbiUsRmBymp2V2iwAsBWDxtXni1aHxQBvXIiCXP4uSEzwn/D4Jru7rpwmVyUlAYoZFD LqoMgH3PD7wW5vLRgsI0= X-Received: by 2002:a63:83c6:0:b0:46a:fe3e:8b1f with SMTP id h189-20020a6383c6000000b0046afe3e8b1fmr16036586pge.120.1666357578377; Fri, 21 Oct 2022 06:06:18 -0700 (PDT) X-Google-Smtp-Source: AMsMyM71XG1lwEEfVMGq6lk6DzKrYVEYY27tLT01FmItA5V1orYsoUct/nzggBXmiKQuOT0od1/PdHcVZtk7omjmOgo= X-Received: by 2002:a63:83c6:0:b0:46a:fe3e:8b1f with SMTP id h189-20020a6383c6000000b0046afe3e8b1fmr16036572pge.120.1666357578105; Fri, 21 Oct 2022 06:06:18 -0700 (PDT) MIME-Version: 1.0 References: <20221020221840.305941-1-stephen@networkplumber.org> In-Reply-To: <20221020221840.305941-1-stephen@networkplumber.org> From: David Marchand Date: Fri, 21 Oct 2022 15:06:06 +0200 Message-ID: Subject: Re: [PATCH] dumpcap: remove bogus rte_free() To: Stephen Hemminger Cc: dev@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Oct 21, 2022 at 12:19 AM Stephen Hemminger wrote: > > At end of program there is call to rte_free() which is passing > a bogus value. There is no "bpf_filter" defined in this application; > it ends up being a text address inside pcap library. > > Fixes: cbb44143be74 ("app/dumpcap: add new packet capture application") Cc: stable@dpdk.org > Signed-off-by: Stephen Hemminger Applied, thanks. -- David Marchand