From: David Marchand <david.marchand@redhat.com>
To: Anatoly Burakov <anatoly.burakov@intel.com>
Cc: dev <dev@dpdk.org>, David Hunt <david.hunt@intel.com>,
"Pattan, Reshma" <reshma.pattan@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2] l3fwd-power: make interrupt wakeup log thread safe
Date: Mon, 2 Nov 2020 11:46:40 +0100 [thread overview]
Message-ID: <CAJFAV8xRov0O510zVAh108T=MTukbEpNAtMo6gLk5bdY3ZwaRA@mail.gmail.com> (raw)
In-Reply-To: <e443e130a0aca99f0e03b727b1796e19479bdb07.1601640423.git.anatoly.burakov@intel.com>
On Fri, Oct 2, 2020 at 2:07 PM Anatoly Burakov
<anatoly.burakov@intel.com> wrote:
>
> Currently, the interrupt status notification prevents log spam by
> remembering whether previous interrupt wakeup was due to traffic or due
> to timeout expiring. However, it is a single variable that can
> potentially be accessed from multiple threads, so it is not thread-safe.
>
> Fix it by having per-lcore interrupt status.
>
> Fixes: f4d1e19c293d ("examples/l3fwd-power: add Rx interrupt timeout")
>
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
Acked-by: David Hunt <david.hunt@intel.com>
Tested-by: Xi Zhang <xix.zhang@intel.com>
Applied, thanks.
--
David Marchand
prev parent reply other threads:[~2020-11-02 10:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-02 12:03 [dpdk-dev] [PATCH] " Anatoly Burakov
2020-10-02 12:07 ` [dpdk-dev] [PATCH v2] " Anatoly Burakov
2020-10-07 15:06 ` David Hunt
2020-11-02 10:35 ` Xie, WeiX
2020-10-09 6:26 ` Xie, WeiX
2020-10-30 12:46 ` David Marchand
2020-11-02 10:46 ` David Marchand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8xRov0O510zVAh108T=MTukbEpNAtMo6gLk5bdY3ZwaRA@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=anatoly.burakov@intel.com \
--cc=david.hunt@intel.com \
--cc=dev@dpdk.org \
--cc=reshma.pattan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).