From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id 6F0BFA04E7;
Mon, 2 Nov 2020 11:46:58 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 4F631BE97;
Mon, 2 Nov 2020 11:46:57 +0100 (CET)
Received: from us-smtp-delivery-124.mimecast.com
(us-smtp-delivery-124.mimecast.com [216.205.24.124])
by dpdk.org (Postfix) with ESMTP id 7AC4ABE95
for <dev@dpdk.org>; Mon, 2 Nov 2020 11:46:55 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
s=mimecast20190719; t=1604314013;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:cc:mime-version:mime-version:content-type:content-type:
in-reply-to:in-reply-to:references:references;
bh=vw/iBroY5Yz1HxaqLqEcZ6BXitVoB9CTM9A16Dp1gtY=;
b=dvqRlrhyHqGeSbVj/q/W86c9uSbq7A6g5AL1k7kTgCkhRP7kXsgLi+mvR0EhLpkc/RnWc6
3/EWo2JOVV4uWb0Dg5kpbteQg7RFdnm+QS96+G57s69KgTaXyzMJrV85BkEEb6fm7MhfLx
M/zmfOCRPPmjDZzTRaIQnLXvlBSvydQ=
Received: from mail-vs1-f72.google.com (mail-vs1-f72.google.com
[209.85.217.72]) (Using TLS) by relay.mimecast.com with ESMTP id
us-mta-513-PzZIE59IM92TV0iNiY2Gbw-1; Mon, 02 Nov 2020 05:46:52 -0500
X-MC-Unique: PzZIE59IM92TV0iNiY2Gbw-1
Received: by mail-vs1-f72.google.com with SMTP id z9so4792010vsl.3
for <dev@dpdk.org>; Mon, 02 Nov 2020 02:46:52 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:mime-version:references:in-reply-to:from:date
:message-id:subject:to:cc;
bh=vw/iBroY5Yz1HxaqLqEcZ6BXitVoB9CTM9A16Dp1gtY=;
b=KA+qKV6dhN0pEkHD4Rn35RPhgMUTRNXdAJvccfa+2jD5GpB2J76ixN4WfiRCdV5uG0
UnpazwTinTVhNPaPaJpTcZ80QWkNIUNxDJuipRNoLi53eDBuHnem8SotuIBHqnKukfEs
LwiNVl8xW6QMiOZQjJP7IFybq6vEIz483yWpgrXLNODyY2yUG8zf79yB6tew188qPFCw
/bTVxThtCQSj/PAFgvi4xmsUQ8jAmWh0j7fraC8XC7PH8uhpLDpiWnZzqDMX/GAQdfAO
iPR6+vTkP4qTywq7/sMVCBIQ2tGrrEKbpeqcbY5/Q6CDWVC+EU2QSt315kwxmJLX1cuD
A90Q==
X-Gm-Message-State: AOAM533FuAS6pBEcT2u6BtBppnc4MnkljVZlgxDbHSUD0hwvIA1smZCn
AVvBfdz21F/Oym3iyB3jC/HiK6W4Pf63FYm6rRPJqm62QMY0Nm+yNteL1aJ5qcuodWeiAEOwer6
kxArUtU8Hb89TC6O98Cg=
X-Received: by 2002:ab0:6dd3:: with SMTP id r19mr970109uaf.86.1604314011636;
Mon, 02 Nov 2020 02:46:51 -0800 (PST)
X-Google-Smtp-Source: ABdhPJxgcgVRTQGGpLVumHPAJiVWWHXKNolmGWdy7djScHYyD80wKF0ChjmLPOQA2MwHyP6Qvznqrl3035WnRleOtcE=
X-Received: by 2002:ab0:6dd3:: with SMTP id r19mr970102uaf.86.1604314011477;
Mon, 02 Nov 2020 02:46:51 -0800 (PST)
MIME-Version: 1.0
References: <c155c104b7974876674d01ff2d789f78d607f04a.1601640180.git.anatoly.burakov@intel.com>
<e443e130a0aca99f0e03b727b1796e19479bdb07.1601640423.git.anatoly.burakov@intel.com>
In-Reply-To: <e443e130a0aca99f0e03b727b1796e19479bdb07.1601640423.git.anatoly.burakov@intel.com>
From: David Marchand <david.marchand@redhat.com>
Date: Mon, 2 Nov 2020 11:46:40 +0100
Message-ID: <CAJFAV8xRov0O510zVAh108T=MTukbEpNAtMo6gLk5bdY3ZwaRA@mail.gmail.com>
To: Anatoly Burakov <anatoly.burakov@intel.com>
Cc: dev <dev@dpdk.org>, David Hunt <david.hunt@intel.com>,
"Pattan, Reshma" <reshma.pattan@intel.com>
Authentication-Results: relay.mimecast.com;
auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [dpdk-dev] [PATCH v2] l3fwd-power: make interrupt wakeup log
thread safe
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
On Fri, Oct 2, 2020 at 2:07 PM Anatoly Burakov
<anatoly.burakov@intel.com> wrote:
>
> Currently, the interrupt status notification prevents log spam by
> remembering whether previous interrupt wakeup was due to traffic or due
> to timeout expiring. However, it is a single variable that can
> potentially be accessed from multiple threads, so it is not thread-safe.
>
> Fix it by having per-lcore interrupt status.
>
> Fixes: f4d1e19c293d ("examples/l3fwd-power: add Rx interrupt timeout")
>
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
Acked-by: David Hunt <david.hunt@intel.com>
Tested-by: Xi Zhang <xix.zhang@intel.com>
Applied, thanks.
--
David Marchand