From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 014F8A0A0F; Wed, 30 Jun 2021 08:29:36 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 73FFF40040; Wed, 30 Jun 2021 08:29:36 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id B960C4003C for ; Wed, 30 Jun 2021 08:29:35 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1625034575; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wPN7qcp5YNHjWPtI34IXdCLkzrAUsU/t68kbUeAUTxE=; b=OO0OJ2qNKT3GT2GugQuzmQhtmdc3pypvy0SyqJqPWaStSzJJBEYd5nhmvOXzJX350Rguev P1OEDdmNaFEcOKvWv0k6+XnVNNb/uQoo4iB1UpWzroiSZncOA/DljeCTtkldahRdTIZMND Qp22A+PMlY6S7RESKrLcj66K76RzpLs= Received: from mail-vs1-f72.google.com (mail-vs1-f72.google.com [209.85.217.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-254-yjaRxMmkPECXqlTsgn1YrQ-1; Wed, 30 Jun 2021 02:29:33 -0400 X-MC-Unique: yjaRxMmkPECXqlTsgn1YrQ-1 Received: by mail-vs1-f72.google.com with SMTP id x128-20020a6763860000b0290273379eff23so591666vsb.3 for ; Tue, 29 Jun 2021 23:29:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wPN7qcp5YNHjWPtI34IXdCLkzrAUsU/t68kbUeAUTxE=; b=Ldq+z1SDMBMtUbmIU5IwfAJQiqKjHCnCEY2VuaRpgtKBinZuaZ4h1VNT6EcsA4/UKc eM+Io9t24iYqOdztIwHFB05p94Su7s0uCKQT36HJnKUTz5AAy59OP9PvxB1IGSXhnS9M BgU8RVxYh/Jj82yfpRy6eVE/Bt8FD27esVg0pkM6PDQiQ4Hf5hsoZVhJxrxTelCv3X87 Nt84BC7mHq+DS6bVXTAJBMgaJJJ9t/AvbnmFcvvxTwFcn6TIgcvbpzYvtRfUePQpfnxi sLrcMdyaIFuhpIkRVvkA5PugmQh9GqC7/r2MYsgS9o/zQuMTXar49kgM8Mm0pEd32jSp gHKQ== X-Gm-Message-State: AOAM533FTlhTNWQjZJy8hjwSvopWLpTDzgdT3dATKG5pH93VDkgrJa1+ RmDZi8zu/uIeRjyrs321Znu8/BOrB4YYbRtwJIIZAUU5NjfzM5DW6p0iavMmas6cdTK0KWFzA3/ /DzGI5CszdgpBPTSmXCA= X-Received: by 2002:a9f:3ec6:: with SMTP id n6mr12341991uaj.87.1625034572603; Tue, 29 Jun 2021 23:29:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxOB35iisnJmItIWeai1rXnRvZVo4RkMZk0SMrD1cuNgKk/nYWOUaVxPwj7cFuowNfXFBitB8Ung4f+UZVSZwM= X-Received: by 2002:a9f:3ec6:: with SMTP id n6mr12341976uaj.87.1625034572336; Tue, 29 Jun 2021 23:29:32 -0700 (PDT) MIME-Version: 1.0 References: <20210629134632.525037-1-ferruh.yigit@intel.com> In-Reply-To: <20210629134632.525037-1-ferruh.yigit@intel.com> From: David Marchand Date: Wed, 30 Jun 2021 08:29:21 +0200 Message-ID: To: Ferruh Yigit Cc: Cristian Dumitrescu , Jasvinder Singh , Thomas Monjalon , Andrew Rybchenko , dev , Dodji Seketeli Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] ethdev: add namespace X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hello Ferruh, On Tue, Jun 29, 2021 at 3:46 PM Ferruh Yigit wrote: > > Add 'RTE_ETH' namespace to all enums & macros in a backward compatible > way. The macros for backward compatibility can be removed in next LTS. > > Signed-off-by: Ferruh Yigit - I did not do a full check but I noticed that ETH_RSS compat macro at least is removed. Is this intentional? - libabigail is not happy because of enum names changes. Example: [C] 'function int rte_eth_dev_configure(uint16_t, uint16_t, uint16_t, const rte_eth_conf*)' at rte_ethdev.c:1326:1 has some indirect sub-type changes: parameter 4 of type 'const rte_eth_conf*' has sub-type changes: in pointed to type 'const rte_eth_conf': in unqualified underlying type 'struct rte_eth_conf' at rte_ethdev.h:1491:1: type size hasn't changed 5 data member changes (1 filtered): type of 'rte_eth_rxmode rxmode' changed: type size hasn't changed 1 data member change: type of 'rte_eth_rx_mq_mode mq_mode' changed: type size hasn't changed 8 enumerator deletions: 'rte_eth_rx_mq_mode::ETH_MQ_RX_NONE' value '0' 'rte_eth_rx_mq_mode::ETH_MQ_RX_RSS' value '1' 'rte_eth_rx_mq_mode::ETH_MQ_RX_DCB' value '2' 'rte_eth_rx_mq_mode::ETH_MQ_RX_DCB_RSS' value '3' 'rte_eth_rx_mq_mode::ETH_MQ_RX_VMDQ_ONLY' value '4' 'rte_eth_rx_mq_mode::ETH_MQ_RX_VMDQ_RSS' value '5' 'rte_eth_rx_mq_mode::ETH_MQ_RX_VMDQ_DCB' value '6' 'rte_eth_rx_mq_mode::ETH_MQ_RX_VMDQ_DCB_RSS' value '7' 8 enumerator insertions: 'rte_eth_rx_mq_mode::RTE_ETH_MQ_RX_NONE' value '0' 'rte_eth_rx_mq_mode::RTE_ETH_MQ_RX_RSS' value '1' 'rte_eth_rx_mq_mode::RTE_ETH_MQ_RX_DCB' value '2' 'rte_eth_rx_mq_mode::RTE_ETH_MQ_RX_DCB_RSS' value '3' 'rte_eth_rx_mq_mode::RTE_ETH_MQ_RX_VMDQ_ONLY' value '4' 'rte_eth_rx_mq_mode::RTE_ETH_MQ_RX_VMDQ_RSS' value '5' 'rte_eth_rx_mq_mode::RTE_ETH_MQ_RX_VMDQ_DCB' value '6' 'rte_eth_rx_mq_mode::RTE_ETH_MQ_RX_VMDQ_DCB_RSS' value '7' [snip] I guess libabigail is lost because the symbol rte_eth_rx_mq_mode::ETH_MQ_RX_NONE simply disappeared (because we used a macro to wrap to the new name). Maybe we could go the other way: leave the current enums defined as is and put in place wrappers for new names pointing as old names. The rest of the code in DPDK would use the new names only. This comment applies if we want to merge this change in 21.08 and/or we want to backport this change. This won't be a problem if we merge this patch in 21.11. > --- > We can get the update on v21.11 and remove backward compatibility macros > on v22.11. -- David Marchand