From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DBE4343900; Fri, 19 Jan 2024 16:54:56 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 74AF94029F; Fri, 19 Jan 2024 16:54:56 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 1546D40279 for ; Fri, 19 Jan 2024 16:54:54 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1705679694; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BGHcVVaV4hI5OXJVc+ikx7P/OUJB/Np5gPuw/h5+xp8=; b=VDIwa/T63vT8TS9QU3s6vF1/NaY+q+jMktRokUb9d81ctJQ6S1WNN2Wwqi+PoTnfCUl6wO XU+SaWrKBflcLxnDlmPQTZ29wioyMiAoQyA71v+wfF/gF6rB2qDiqTOWOmNtJzx4/Dib06 tyLsEAu4SeIVmswKy9yHdLDqvtzjDKs= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-148-CnoBtZnmO0aIMLv2SWM7uA-1; Fri, 19 Jan 2024 10:54:52 -0500 X-MC-Unique: CnoBtZnmO0aIMLv2SWM7uA-1 Received: by mail-lj1-f199.google.com with SMTP id 38308e7fff4ca-2cceb983e83so6848541fa.3 for ; Fri, 19 Jan 2024 07:54:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705679691; x=1706284491; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BGHcVVaV4hI5OXJVc+ikx7P/OUJB/Np5gPuw/h5+xp8=; b=nQfEevq3Zjg38Kz2MN3bQOAChilSXE4L1DHnPCh++0OdzywqmfkXLhaj+0h48FWklx NHjLehHSb4tS1vKE51sSgGZ3MkzmRaTLgxAFMznuxFUyjr7kCFwv9T9272qQcrWmJj56 FzR4WadEMbqdRkXX9QbyPO3HVI5KwMwfqKFL6RAKtRnGTWTlOuY6VRTLT0d+EjivlOYC SEn/I0pm5jO+z0dxhbjtnH9u4mn8aIf7Nlvd4RfGs4xP6NhvZyKhe43Vj9EB18ZSJp2P aLf6UPNB3xwnuHDUT4T94oAHLM4S4sLRkLdnyTUsTSUkkNfLQRT5UIf5vGgx0erq4/lz HSDA== X-Gm-Message-State: AOJu0Yw9Ef5YThs9+X0fZTHgbSly6nR37FqWpFgU+aRu+We5w3cflRcY l52vjCeucOO4JU5++TVeB21LrrOSPGSUZCCR4ZCkqt1k1ASu1HZkQvLR12E/ESpvEioYnA7ENsJ E69CIzoYoFszhEUzwk+nVRAVn807nxICUe2jc72GE55iA0DrbJxBTMULQK3j1WhMmKybNbFHhIr V4hI1eFtm30zKuZbk= X-Received: by 2002:a05:651c:2105:b0:2cd:10aa:7628 with SMTP id a5-20020a05651c210500b002cd10aa7628mr1960090ljq.8.1705679690826; Fri, 19 Jan 2024 07:54:50 -0800 (PST) X-Google-Smtp-Source: AGHT+IElUaOb6KVV+3PccrJeKfuge6U/+Ms50BdSC4A+F31qMg/bQHa4G+94Y3OUvXhgispSsparmzGfvmvkl2zqunw= X-Received: by 2002:a05:651c:2105:b0:2cd:10aa:7628 with SMTP id a5-20020a05651c210500b002cd10aa7628mr1960086ljq.8.1705679690558; Fri, 19 Jan 2024 07:54:50 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: David Marchand Date: Fri, 19 Jan 2024 16:54:39 +0100 Message-ID: Subject: Re: [PATCH] lib/telemetry:fix telemetry conns leak in case of socket write fail To: sunshaowei01 <1819846787@qq.com> Cc: dev@dpdk.org, ciara.power@intel.com, Bruce Richardson X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hello, On Fri, Jan 19, 2024 at 12:40=E2=80=AFPM sunshaowei01 <1819846787@qq.com> w= rote: > > Telemetry can only create 10 conns by default, each of which is processed > by a thread. > > When a thread fails to write using socket, the thread will end directly > without reducing the total number of conns. > > This will result in the machine running for a long time, and if there are > 10 failures, the telemetry will be unavailable > Thanks for the patch, do you know which commit first triggered the issue? This is needed so we add a Fixes: tag in the commitlog for backporting the fix in stable releases. See https://doc.dpdk.org/guides/contributing/patches.html#patch-fix-related= -issues > Signed-off-by: sunshaowei01 <1819846787@qq.com> We need your full name in the SoB tag. Like, for example in my case, it would be David Marchand . --=20 David Marchand