From: David Marchand <david.marchand@redhat.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev <dev@dpdk.org>, "Dong, JunX" <junx.dong@intel.com>,
"Morten Brørup" <mb@smartsharesystems.com>,
"Tyler Retzlaff" <roretzla@linux.microsoft.com>
Subject: Re: [PATCH] config: remove explicit undef of unset values
Date: Wed, 15 Jun 2022 09:14:16 +0200 [thread overview]
Message-ID: <CAJFAV8xSBOuWtmqjOeSrJt9tx7Y+qpEPjQO3J8ff0qqe3wKHrw@mail.gmail.com> (raw)
In-Reply-To: <20211216111430.699717-1-bruce.richardson@intel.com>
On Thu, Dec 16, 2021 at 12:15 PM Bruce Richardson
<bruce.richardson@intel.com> wrote:
>
> Rather than explicitly clearing any setting of undefined values in our
> rte_config.h file, it's better to instead just add a comment that the
> value is not set. Using a comment allows the user to set the value using
> CFLAGS or similar mechanism without the config file clearing the value
> again.
>
> The text used "<VALUE> is not set" is modelled after the kernel approach
> of doing the same thing.
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
Acked-by: Morten Brørup <mb@smartsharesystems.com>
Acked-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
Rebased, added check as agreed, and applied.
Thanks Bruce.
--
David Marchand
prev parent reply other threads:[~2022-06-15 7:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-16 11:14 Bruce Richardson
2022-06-13 9:54 ` Bruce Richardson
2022-06-13 10:01 ` Morten Brørup
2022-06-13 12:26 ` David Marchand
2022-06-13 12:37 ` Bruce Richardson
2022-06-13 14:20 ` David Marchand
2022-06-13 14:48 ` Bruce Richardson
2022-06-13 14:46 ` Tyler Retzlaff
2022-06-15 7:14 ` David Marchand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8xSBOuWtmqjOeSrJt9tx7Y+qpEPjQO3J8ff0qqe3wKHrw@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=junx.dong@intel.com \
--cc=mb@smartsharesystems.com \
--cc=roretzla@linux.microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).