From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 65B67A0548; Wed, 15 Jun 2022 09:14:32 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5517340221; Wed, 15 Jun 2022 09:14:32 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 79FCA40220 for ; Wed, 15 Jun 2022 09:14:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1655277271; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bCXdVaDZZss1CwGHoPSERf8FKWqF/lJ9QtyMbg01SmY=; b=Uu5ISx3IeiGeqW3iZz+XxwgrHxrc1kQ5LvJI59E77yuTwLDDcztY4WBzV0eYkCWBulFmXx q0s+SnIfxQbbElhLp82dONli4ySwATgNxNNzdY/HSfgSLIZTkY50hLpuQC3+JXqBCrLMpY PytcxA75yGnzirBS9Sxh9n1H3kTjUlg= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-320-DV8maNLQPjKPZhG9-qAtaw-1; Wed, 15 Jun 2022 03:14:29 -0400 X-MC-Unique: DV8maNLQPjKPZhG9-qAtaw-1 Received: by mail-lf1-f69.google.com with SMTP id u5-20020a056512128500b00479784f526cso5626882lfs.13 for ; Wed, 15 Jun 2022 00:14:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=bCXdVaDZZss1CwGHoPSERf8FKWqF/lJ9QtyMbg01SmY=; b=qJau44kGLZCjHolP2WlDN+8xOkZzQP75XPoqRdZBuUGmvdwLo/XjiJEn4ozl6bGjRu 2jfPSCOVgcq/U3qxzE2qSqiqU2phXEzQH2pdbAjfXrxiOoNxn6r1SYTl0eCq/GhkdPTh ieqXTdVVh+XsgcDnKETCDk12blE6WMbNk6f9cLYnEVwTMibKOUdTJcUClfz9mjkqElIj vA11lm0OTFLGkefRi8hNEPSHfWRRCnktq42mbZr5VmqC9Y1HyTuSaNnc09Wzj1Pcg/tK SHkuemkIPvmcPIz6EfVztErG7xtv3hGJFAo1ocs3z/gRVw01RWsZ0QisLEHeIW5Y3yZX JMHQ== X-Gm-Message-State: AJIora/KOkgJ92UvkYpzYLP0fX24oqze4p2CUjUPTkIoGQz0IXjl/XPa crhCBZQSttkydK6/7+YC1wdWAOEaauxitQCLR3plMJED11vleW+DW1B4O0CgrqdLb8tqubpL5Ey WKO7bEWDBS7+GNIY60Ls= X-Received: by 2002:a05:651c:24b:b0:259:85b:ac09 with SMTP id x11-20020a05651c024b00b00259085bac09mr4483806ljn.46.1655277268234; Wed, 15 Jun 2022 00:14:28 -0700 (PDT) X-Google-Smtp-Source: AGRyM1sgGShoWCI5uBcWFZ74ekssd1W0iMUhD0gyyqy+/7W6/TNnFRR709t4WvxJpTgozuay07Au5QRvxWws2tUraRQ= X-Received: by 2002:a05:651c:24b:b0:259:85b:ac09 with SMTP id x11-20020a05651c024b00b00259085bac09mr4483793ljn.46.1655277267990; Wed, 15 Jun 2022 00:14:27 -0700 (PDT) MIME-Version: 1.0 References: <20211216111430.699717-1-bruce.richardson@intel.com> In-Reply-To: <20211216111430.699717-1-bruce.richardson@intel.com> From: David Marchand Date: Wed, 15 Jun 2022 09:14:16 +0200 Message-ID: Subject: Re: [PATCH] config: remove explicit undef of unset values To: Bruce Richardson Cc: dev , "Dong, JunX" , =?UTF-8?Q?Morten_Br=C3=B8rup?= , Tyler Retzlaff Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Dec 16, 2021 at 12:15 PM Bruce Richardson wrote: > > Rather than explicitly clearing any setting of undefined values in our > rte_config.h file, it's better to instead just add a comment that the > value is not set. Using a comment allows the user to set the value using > CFLAGS or similar mechanism without the config file clearing the value > again. > > The text used " is not set" is modelled after the kernel approach > of doing the same thing. > > Signed-off-by: Bruce Richardson Acked-by: Morten Br=C3=B8rup Acked-by: Tyler Retzlaff Rebased, added check as agreed, and applied. Thanks Bruce. --=20 David Marchand