From: David Marchand <david.marchand@redhat.com>
To: Bruce Richardson <bruce.richardson@intel.com>,
Chengwen Feng <fengchengwen@huawei.com>
Cc: dev <dev@dpdk.org>, Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [dpdk-dev] [PATCH] dmadev: enable build on Windows
Date: Wed, 20 Oct 2021 09:03:14 +0200 [thread overview]
Message-ID: <CAJFAV8xSfULVtHiZ1kstPA7__fg+Xv6WPXzD5B73yGacehTDOw@mail.gmail.com> (raw)
In-Reply-To: <CAJFAV8wNrbZr7V3o-AD862zvwvj1X1LcE88b8=8SbTGSb8NnVA@mail.gmail.com>
On Wed, Oct 20, 2021 at 8:32 AM David Marchand
<david.marchand@redhat.com> wrote:
>
> On Tue, Oct 19, 2021 at 2:28 PM Bruce Richardson
> <bruce.richardson@intel.com> wrote:
> >
> > The dmadev library was not added to the list of libraries built on
> > Windows, meaning it was skipped in those builds and also that none of
> > the drivers were being considered for build. Adding dmadev to the list
> > fixes this, and also enables the skeleton dmadev driver to be built -
> > all-be-it with a small fix necessary.
> >
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> > ---
> >
> > This patch has been compile tested using mingw on Linux. Sending it
> > publicly so that I can get CI test reports to check native windows
> > builds.
> > ---
>
> There is a problem with exported symbols.
> Some inlines have been marked for versioning (see
> rte_dma_burst_capacity for example) and must be removed from
> version.map.
>
> Can you have a look?
I sent the patches.
Hope it saves us some time:
https://patchwork.dpdk.org/project/dpdk/patch/20211020065944.19617-2-david.marchand@redhat.com/
--
David Marchand
next prev parent reply other threads:[~2021-10-20 7:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-19 12:28 Bruce Richardson
2021-10-20 6:32 ` David Marchand
2021-10-20 7:03 ` David Marchand [this message]
2021-10-20 6:39 ` fengchengwen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8xSfULVtHiZ1kstPA7__fg+Xv6WPXzD5B73yGacehTDOw@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=fengchengwen@huawei.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).