From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 11ECAA0562; Tue, 4 May 2021 15:35:04 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CF88F40147; Tue, 4 May 2021 15:35:02 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 23A9F40141 for <dev@dpdk.org>; Tue, 4 May 2021 15:35:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620135300; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KCkxJBUCnQKsFnmeJxol8pP9qdqdZ9mlqzVqYEWAWLs=; b=Geik20QIjrc/vH5zWnKeDW+AMBjHFvr75f3Oy5rdJl3EVSEibr+di1cdR2WYRL4FhdS/TA TeS2qLrUEqtDlB8kW4HJUU7jNSKqYcwyDTLh0r4VyXE1s20XlrLlprMwf0TYsAoXKIGCic pv/5E2bNmWqIEOkubC9hz/24r6KF8Rw= Received: from mail-vk1-f200.google.com (mail-vk1-f200.google.com [209.85.221.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-565-4WZ-flGgPPqdJDRmiSHzuA-1; Tue, 04 May 2021 09:34:57 -0400 X-MC-Unique: 4WZ-flGgPPqdJDRmiSHzuA-1 Received: by mail-vk1-f200.google.com with SMTP id c82-20020a1f1c550000b02901d872c4847dso1333332vkc.17 for <dev@dpdk.org>; Tue, 04 May 2021 06:34:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KCkxJBUCnQKsFnmeJxol8pP9qdqdZ9mlqzVqYEWAWLs=; b=AO4EBah4MCZwdRkiZA+FwYQH3kB8IsdNpPsh+EWO3x/o7hHEfDHIvmJ3KaBhS00yP5 N/u9SvQGAPcED2lFEjUAmnDgYYBkPEtbIhNeagoF1hZ17G4AYq/Ltw3klFV0D/D5cete 7+8qPw+H5OnbrU/08qoXpubLp/GScL+it8MgjeBZafNTNZ6uOQVYpE1gohXwJ6Emt236 ToYXYsjSwP1S7di4mj2w0NPmFwAWoRXZYQFMB5XmNszwiLAjjqhH/AutDCparkESkSJ3 6aTHDj4aVG3iPjN/kydV1Hkc5CHByoBXlTOgPz8/4nxZ6bFMYb0Vj0kC06wq7txZGDgP AKLA== X-Gm-Message-State: AOAM5332p9BcYW76v70KHWQaUncUPsqSk3SmEhC/kaNOtzwKvCJ04ETr JEOehqiMyW+vxxmE5RQBPIBy7KLjy3mEKXZw4yqxQPVkAsAJ3Ynu83+Ri3EholtZNK0+LaiKV1C esCoQni4gcx933VRY7JI= X-Received: by 2002:a67:e317:: with SMTP id j23mr21659970vsf.17.1620135296097; Tue, 04 May 2021 06:34:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyuKxV+ESIVbvs7UE+SThDw9/96mgaHY4eYs3GKuAOEBRi/xfcOjP06G60y/bvMqicUXTxAdLH+Bp/ioEmBwXo= X-Received: by 2002:a67:e317:: with SMTP id j23mr21659934vsf.17.1620135295826; Tue, 04 May 2021 06:34:55 -0700 (PDT) MIME-Version: 1.0 References: <20210422090211.320855-1-bruce.richardson@intel.com> <20210426105403.226004-1-bruce.richardson@intel.com> <4514166.BCOjhHQKq7@thomas> In-Reply-To: <4514166.BCOjhHQKq7@thomas> From: David Marchand <david.marchand@redhat.com> Date: Tue, 4 May 2021 15:34:44 +0200 Message-ID: <CAJFAV8xSfZ0Jztw6OOpKuc2hmLBq9tVcY5-epY2SjP5cgyzv3A@mail.gmail.com> To: Bruce Richardson <bruce.richardson@intel.com> Cc: dev <dev@dpdk.org>, "Burakov, Anatoly" <anatoly.burakov@intel.com>, Thomas Monjalon <thomas@monjalon.net> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2 1/2] devtools: script to check meson indentation of lists X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> On Tue, May 4, 2021 at 3:05 PM Thomas Monjalon <thomas@monjalon.net> wrote: > > 26/04/2021 12:54, Bruce Richardson: > > This is a script to fix up minor formatting issues in meson files. > > It scans for, and can optionally fix, indentation issues and missing > > trailing commas in the lists in meson.build files. It also detects, > > and can fix, multi-line lists where more than one entry appears on a > > line. > > > > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com> > > --- > > devtools/dpdk_meson_check.py | 125 +++++++++++++++++++++++++++++++++++ > > Renamed to check-meson.py and added in MAINTAINERS. > > Series applied, thanks. The default behavior is not that friendly (to me). I have build directories in my sources with stuff from older branches where the coding fixes are not backported. This results in the check complaining on all those directories. Can we have a default behavior where only committed files are considered? Maybe filtering with git ls-files **/meson.build. -- David Marchand