From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B964742CA9; Tue, 13 Jun 2023 15:50:22 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 972CD40A8A; Tue, 13 Jun 2023 15:50:22 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id DE69340698 for ; Tue, 13 Jun 2023 15:50:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686664221; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yPvJ7gXtbkxkPVMR6ozDsRtPk1ZCwmhGw1sZh6HsSJ0=; b=jDYmxXB9/XVGunZS0QJ5FWnr/jkxzl3tSJ8OzGcfn7EUM5TP60srqpJLgCYMmyi4du3SV7 u+LdGckB1VAsI/mDSxAX/pWqJGNLibSXj3BY9qwmVWGCcNfJtkCIc1Uvp6A1xSt7iv7DLu 5PC/LzYHqG4JFHTS9rw7ZbXvfhDnoy8= Received: from mail-oa1-f70.google.com (mail-oa1-f70.google.com [209.85.160.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-494--i36uczoPPSmKmDSS_PNzg-1; Tue, 13 Jun 2023 09:50:19 -0400 X-MC-Unique: -i36uczoPPSmKmDSS_PNzg-1 Received: by mail-oa1-f70.google.com with SMTP id 586e51a60fabf-19ee42cbc89so4068745fac.2 for ; Tue, 13 Jun 2023 06:50:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686664218; x=1689256218; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yPvJ7gXtbkxkPVMR6ozDsRtPk1ZCwmhGw1sZh6HsSJ0=; b=ANO8y7cLEH2vvzyNNGZQq7M0n65CDaPkKHEWaefS2KBOHpZlhgJsIrbaZG13/d41jJ DtYBG+yVGlrGQKqGJSY2mh24lhQA3LZ5dEybWgftkT/Y12KJXTCSdR0twUic+JAVT/Iy RQpknTy5RspIo8NVrNnux7gXHsZtfEMx+jjDga47kLG8NRo78vHVxPJ0tLZ2KuBz3Vj8 7xe0CuxnEYqLMqhIUJmQxWz/mPF90zYoAqbHvBJ1CV9AFFNB2E5Ept3usd11MLYyKksA cPnqWDCLYvo82OhFvSIzKXa+7tb3+hK4K7Un00kdhvtLMWUf4ywMnW6wLxxFrxnwQovp sKCw== X-Gm-Message-State: AC+VfDza6id6PAcSEvquWnDYTC2a28vc+A4v1GbyDfRW/vLP/2Zp9riu qjBlZjuUqM3nlxXmVffGWhR1L1jxXb+kzHBZRSfUZuPEyHCKbEel7laQbUf8I0mHi+ZZYZ3vZTr aBtrOdaPZIRbnjA0y0yw= X-Received: by 2002:a05:6870:e292:b0:19e:7d07:ab9 with SMTP id v18-20020a056870e29200b0019e7d070ab9mr8689867oad.53.1686664218305; Tue, 13 Jun 2023 06:50:18 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7TSRj0idQhJPdSa/C8bMEY/Lg2M8vKCBzdao3CL0UyrulzJoLysFFEoGA4YR3K+wSal3M77VF1FFstefT2GtE= X-Received: by 2002:a05:6870:e292:b0:19e:7d07:ab9 with SMTP id v18-20020a056870e29200b0019e7d070ab9mr8689851oad.53.1686664217959; Tue, 13 Jun 2023 06:50:17 -0700 (PDT) MIME-Version: 1.0 References: <20230612162104.170749-1-bruce.richardson@intel.com> <20230612171456.173378-1-bruce.richardson@intel.com> <20230612171456.173378-2-bruce.richardson@intel.com> In-Reply-To: From: David Marchand Date: Tue, 13 Jun 2023 15:50:06 +0200 Message-ID: Subject: Re: [PATCH v2 2/2] build: prevent accidentally building without NUMA support To: Bruce Richardson Cc: dev@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Jun 12, 2023 at 7:59=E2=80=AFPM Bruce Richardson wrote: > > On Mon, Jun 12, 2023 at 06:14:56PM +0100, Bruce Richardson wrote: > > When libnuma development package is missing on a system, DPDK can still > > be built but will be missing much-needed support for NUMA memory > > management. This may later cause issues at runtime if the resulting > > binary is run on a NUMA system. > > > > We can reduce the incidence of such runtime error by ensuring that, for > > native builds*, libnuma is present - unless the user actually specifies > > via "max_numa_nodes" that they don't require NUMA support. Having this > > as an error condition is also in keeping with what is documented in the > > Linux GSG doc, where libnuma is listed as a requirement for building > > DPDK [1]. > > > > * NOTE: cross-compilation builds have a different logic set, with a > > separate "numa" value indicating if numa support is necessary. > > > > [1] https://doc.dpdk.org/guides-23.03/linux_gsg/sys_reqs.html > > > > Signed-off-by: Bruce Richardson > > > > --- > > V2: Limit check to linux only > > --- > > config/meson.build | 9 +++++++++ > > 1 file changed, 9 insertions(+) > > > I see this patch has failures reported in the CI, due to some of the > systems not having libnuma installed. I'd view that as a false positive, > since libnuma is effectively a mandatory requirement for building DPDK to > run on most systems. [And this patch still provides a way to build withou= t > it - that way just has to be selected deliberately, rather than it being = chosen > by default, without the user being aware of the omission.] The Intel CI lab job failing seems to be an issue in their RHEL 8.7 environ= ment. Can you ping them to figure it out? For the i386 job in GHA.. either we install a 32bits numa library, or we can silence this by setting max_numa_nodes to 1. --=20 David Marchand