From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 633F8A0503; Thu, 19 May 2022 16:21:08 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 501FE40222; Thu, 19 May 2022 16:21:08 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 83F7940156 for ; Thu, 19 May 2022 16:21:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1652970067; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Zo369Gw/2WhQJMbHsRcNm7PIWPX7UclQf299Xd3838M=; b=Qf76eI24L1XS8/PCtDSXk0643oePqbsSlBSQPjDolOu4kqVo7clPj5JzQiX4Np+h7z4P+T 2Z/2vTGuUBEye64lGnhM0GVV0z9mKQEKiriAltWg4uDQYpQlEXd7Rk7N0LeXmSqcv87stz y7ye0/MW/VoKr5tjK7TGVao7Cl88WgE= Received: from mail-lj1-f197.google.com (mail-lj1-f197.google.com [209.85.208.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-580-jYoLyRIxNNqPkjeXz7hWrw-1; Thu, 19 May 2022 10:21:05 -0400 X-MC-Unique: jYoLyRIxNNqPkjeXz7hWrw-1 Received: by mail-lj1-f197.google.com with SMTP id z11-20020a05651c022b00b00253d40c090dso450662ljn.4 for ; Thu, 19 May 2022 07:21:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Zo369Gw/2WhQJMbHsRcNm7PIWPX7UclQf299Xd3838M=; b=60JG4xzsRLCgAQDubf1CsHAcOoTXSEvk2Dx4+kbpOsO2IxrAdRE8xSh2VVpprgkYf1 bymbIzZB+j9db6INnMJvT+3Z0Z6Hd5NyuZo3/ZZ6svIaB1U5awVcUzHV+56Uhl8QAiGg /dKw6/9ZKqvyysgopwdWR1pfPDFJ/PHXZ47FBbEGfpCq0d29B2n0CJsAABIE9QzCfbSv pQ0D+30P+yuFKxRKgVJNgwvOjfLryAPLir4va+k09dHQw2HbZcHmP59RESQEr55nufUh XD4fTTP7Bf7HghNMTErL2O6WfUFf11n1EQIx+ful104z5duQk9gnri+2fJyIHVXBZws3 Ia+g== X-Gm-Message-State: AOAM530368nz36reobUOJK9ucdxRJSDaDvsJsVXJSPQIEAQcl68rAd1A 0RRFlsxt/dNvKXHtyHZhJS0nEHKaiSwfOsEXlM2kURL808HDVjA9qxY6jnZ2zm1jikov74hPtdV JA0X7oQO8PN51TTUXmFA= X-Received: by 2002:a05:651c:1781:b0:247:daa7:4358 with SMTP id bn1-20020a05651c178100b00247daa74358mr2788438ljb.477.1652970064302; Thu, 19 May 2022 07:21:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxGqwZeuXjc1NRSzW8+vgPfRJKXztlWYApcz1IOUlbG3HtLH8yyNjZ8Bqfh9Rd6lICPBO/gemRsT6QvOATv2Vk= X-Received: by 2002:a05:651c:1781:b0:247:daa7:4358 with SMTP id bn1-20020a05651c178100b00247daa74358mr2788419ljb.477.1652970064069; Thu, 19 May 2022 07:21:04 -0700 (PDT) MIME-Version: 1.0 References: <20220429161700.2145-1-pbhagavatula@marvell.com> <20220513182710.13060-1-pbhagavatula@marvell.com> <20220513182710.13060-2-pbhagavatula@marvell.com> In-Reply-To: <20220513182710.13060-2-pbhagavatula@marvell.com> From: David Marchand Date: Thu, 19 May 2022 16:20:52 +0200 Message-ID: Subject: Re: [PATCH v9 2/2] hash: unify crc32 selection for x86 and Arm To: Pavan Nikhilesh Cc: "Wang, Yipeng1" , Jerin Jacob Kollanukkaran , Sameh Gobriel , Bruce Richardson , Vladimir Medvedkin , Ruifeng Wang , dev Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, May 13, 2022 at 8:27 PM wrote: > > From: Pavan Nikhilesh > > Merge crc32 hash calculation public API implementation for x86 and Arm. > Select the best available CRC32 algorithm when unsupported algorithm > on a given CPU architecture is requested by an application. > > Previously, if an application directly includes `rte_crc_arm64.h` > without including `rte_hash_crc.h` it will fail to compile. > > Signed-off-by: Pavan Nikhilesh > Reviewed-by: Ruifeng Wang As mentionned when reviewing v8, the doxygen description of helpers gets dropped by this patch. I moved those descriptions in rte_hash_crc.h only, under a __DOXYGEN__ check. I also sorted alphabetically the list of headers in meson, and aligned include guards with the file names. Series applied, thanks. -- David Marchand