From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1835345AF3; Wed, 9 Oct 2024 12:56:54 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A9AD64065D; Wed, 9 Oct 2024 12:56:53 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 3EF284064C for ; Wed, 9 Oct 2024 12:56:52 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1728471411; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OYnK0wYadzObOt1kJow8Htx8PkFJqUp0NrhVtCvYRr8=; b=Hr4B3Hnm+p8uGXVeOrl9ZUc8of21SOy2s27JdmiLWDkpJaw3hQCnrnnIjHLN2JyedHQAMr 5IUbA6S24pVqUjXoj9T7uLWVwKFm61n2fZ45tYaHUpTwIjb3DKKFctJeEW6GSBKLBbnq53 Lkr0a5BXucRqRZ+1+g8oTzOKJs/2EZU= Received: from mail-lj1-f197.google.com (mail-lj1-f197.google.com [209.85.208.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-524-2QibRLQXNRKTFr49Oatigw-1; Wed, 09 Oct 2024 06:56:50 -0400 X-MC-Unique: 2QibRLQXNRKTFr49Oatigw-1 Received: by mail-lj1-f197.google.com with SMTP id 38308e7fff4ca-2fabce3125fso52426781fa.0 for ; Wed, 09 Oct 2024 03:56:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728471409; x=1729076209; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OYnK0wYadzObOt1kJow8Htx8PkFJqUp0NrhVtCvYRr8=; b=eaej70L9yUg1V234sS2uDxCq+jsdIVPWwYs41p3dyqYiBrdgUAU3q1+Wmg5c7DwoBq atwr6cI8b7n5C9h4YQbCuHxUfytLUdq9uyTdwJaYaD4mrxwC6pRrPfgg/MqVIipCkqPy ElR260DJz/y3BflBx/sRuoQ8szmrGtgLK73VUL/XcifHas3cEfbm3Qa9i0qDuMedVndp Lrht+/AIu9BrkjHxbbtAkhqWafsWr/s219pHrW674DvhPqNQWXSYyIojJPrZDJIp/mVT 3+WpKDNzx+LmqRyoaJDyLounQ1BIek5nUlFJqWIpbQMhPHX4DR47Wnqsv2a16or9dYpW A6sA== X-Gm-Message-State: AOJu0YwDrxcuditP8SZ52gArBxcxK6CUGsAbjgU49fk+nXzK0cWJRQN9 QYFdDTesbURA7XiiYao5PA9vMa4dX5iZKVYMd/PAie4sg9tvpymNoIJqYo7ZCJ7vwhnp3Ctukvy l6jyJqcuLpu24E7/74u2SPE241WzZYxeJ+r9KQmhzY6/xV3XycFRnc3eIhjXAUrIhu9xcwahlUu C+fS2qIEgbK/2ZWSQ= X-Received: by 2002:a05:651c:19a0:b0:2f5:806:5cee with SMTP id 38308e7fff4ca-2fb1872fe60mr14110261fa.11.1728471409177; Wed, 09 Oct 2024 03:56:49 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG4OsCzpI8OLmuRjEXtgy2QQUtqWCFuQNvO0k5AEZtf4j4SSKzA02w5Xj+8qBxa1BL8k1CjHifNUCEeWV2o+vE= X-Received: by 2002:a05:651c:19a0:b0:2f5:806:5cee with SMTP id 38308e7fff4ca-2fb1872fe60mr14109991fa.11.1728471408614; Wed, 09 Oct 2024 03:56:48 -0700 (PDT) MIME-Version: 1.0 References: <20241008171605.378069-1-vladimir.medvedkin@intel.com> In-Reply-To: From: David Marchand Date: Wed, 9 Oct 2024 12:56:37 +0200 Message-ID: Subject: Re: [PATCH v2] fib: network byte order IPv4 lookup To: Vladimir Medvedkin Cc: dev@dpdk.org, rjarry@redhat.com, mb@smartsharesystems.com, Stephen Hemminger X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Oct 9, 2024 at 11:51=E2=80=AFAM David Marchand wrote: > > Hi Vladimir, > > On Tue, Oct 8, 2024 at 7:16=E2=80=AFPM Vladimir Medvedkin > wrote: > > diff --git a/lib/fib/dir24_8_avx512.c b/lib/fib/dir24_8_avx512.c > > index 43dba28cfb..edd802abe4 100644 > > --- a/lib/fib/dir24_8_avx512.c > > +++ b/lib/fib/dir24_8_avx512.c > > @@ -10,7 +10,7 @@ > > > > static __rte_always_inline void > > dir24_8_vec_lookup_x16(void *p, const uint32_t *ips, > > - uint64_t *next_hops, int size) > > + uint64_t *next_hops, int size, bool be_addr) > > { > > struct dir24_8_tbl *dp =3D (struct dir24_8_tbl *)p; > > __mmask16 msk_ext; > > @@ -28,6 +28,16 @@ dir24_8_vec_lookup_x16(void *p, const uint32_t *ips, > > res_msk =3D _mm512_set1_epi32(UINT16_MAX); > > > > ip_vec =3D _mm512_loadu_si512(ips); > > + if (be_addr) { > > + const __m512i bswap32 =3D _mm512_set_epi8( > > Some toolchains do not like _mm512_set_epi8 (reported by the CI). Probably related to gcc commit 4e6a811fad69 ("avx512fintrin.h (_mm512_set_epi16, [...]): New intrinsics.") introduced in gcc 9. Some distributions in the CI come with a gcc < 9. We had a similar situation in the hash library in the past, fba335b4b204 ("hash: fix Toeplitz hash implementation"). --=20 David Marchand