DPDK patches and discussions
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: Tal Shnaiderman <talshn@mellanox.com>,
	Thomas Monjalon <thomas@monjalon.net>
Cc: dev <dev@dpdk.org>, Pallavi Kadam <pallavi.kadam@intel.com>,
	 Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,
	Gaetan Rivet <grive@u256.net>,
	 Ranjit Menon <ranjit.menon@intel.com>,
	navasile@linux.microsoft.com,
	 Harini Ramakrishnan <harini.ramakrishnan@microsoft.com>,
	Omar Cardona <ocardona@microsoft.com>,
	 "Burakov, Anatoly" <anatoly.burakov@intel.com>
Subject: Re: [dpdk-dev] [PATCH v5 1/8] eal: move OS common functions to single file
Date: Tue, 16 Jun 2020 10:46:07 +0200	[thread overview]
Message-ID: <CAJFAV8xUPn_74c2cDGGZAdFsxGpt0NztQoLBr0XiX14fqE4f9A@mail.gmail.com> (raw)
In-Reply-To: <20200609103139.22168-2-talshn@mellanox.com>

On Tue, Jun 9, 2020 at 12:32 PM <talshn@mellanox.com> wrote:
>
> From: Tal Shnaiderman <talshn@mellanox.com>
>
> Move common functions between Unix and Windows to eal_common_config.c.
>
> Those simple functions are getter functions for IOVA,
> configuration, Multi-process.
>
> Move rte_config and runtime_dir to be defined in a common file.
>
> Signed-off-by: Tal Shnaiderman <talshn@mellanox.com>
> ---
>  lib/librte_eal/common/eal_common_config.c | 39 +++++++++++++++++++++++++++++++
>  lib/librte_eal/common/eal_private.h       | 12 ++++++++++
>  lib/librte_eal/common/meson.build         |  2 ++
>  lib/librte_eal/freebsd/Makefile           |  1 +
>  lib/librte_eal/freebsd/eal.c              | 36 ----------------------------
>  lib/librte_eal/linux/Makefile             |  1 +
>  lib/librte_eal/linux/eal.c                | 36 ----------------------------
>  lib/librte_eal/windows/eal.c              | 36 ----------------------------
>  8 files changed, 55 insertions(+), 108 deletions(-)
>  create mode 100644 lib/librte_eal/common/eal_common_config.c
>
> diff --git a/lib/librte_eal/common/eal_common_config.c b/lib/librte_eal/common/eal_common_config.c
> new file mode 100644
> index 0000000000..641c7d884c
> --- /dev/null
> +++ b/lib/librte_eal/common/eal_common_config.c
> @@ -0,0 +1,39 @@
> +/* SPDX-License-Identifier: BSD-3-Clause
> + * Copyright(c) 2020 Mellanox Technologies, Ltd
> + */
> +#include <eal_private.h>
> +
> +#include <rte_os.h>

Usually EAL public headers are included first, then local headers after.


> +
> +struct rte_mem_config early_mem_config;

We lost the comment on why this was needed.
This is used as a temp storage before mapping to a shared space.
The code that was relying on this symbol should stop doing it and
start using the getter on rte_config.

This symbol can then be hidden in this code unit.


> +
> +char runtime_dir[PATH_MAX];
> +
> +struct rte_config rte_config = {

static, we have getters.

> +               .mem_config = &early_mem_config,

Single indent is enough.


> +};
> +
> +const char *
> +rte_eal_get_runtime_dir(void)
> +{
> +       return runtime_dir;
> +}
> +
> +/* Return a pointer to the configuration structure */
> +struct rte_config *
> +rte_eal_get_configuration(void)
> +{
> +       return &rte_config;
> +}
> +
> +enum rte_iova_mode
> +rte_eal_iova_mode(void)
> +{
> +       return rte_eal_get_configuration()->iova_mode;
> +}
> +
> +enum rte_proc_type_t
> +rte_eal_process_type(void)
> +{
> +       return rte_config.process_type;
> +}
> diff --git a/lib/librte_eal/common/eal_private.h b/lib/librte_eal/common/eal_private.h
> index 2a780f5138..61bcba81b7 100644
> --- a/lib/librte_eal/common/eal_private.h
> +++ b/lib/librte_eal/common/eal_private.h
> @@ -13,6 +13,8 @@
>  #include <rte_lcore.h>
>  #include <rte_memory.h>
>
> +#include <eal_memcfg.h>

No reason to include this here once we remove the symbol exports.


> +
>  #include "eal_internal_cfg.h"
>
>  /**
> @@ -36,6 +38,13 @@ struct lcore_config {
>         rte_cpuset_t cpuset;       /**< cpu set which the lcore affinity to */
>  };
>
> +
> +/* early configuration structure, when memory config is not mmapped */
> +extern struct rte_mem_config early_mem_config;
> +
> +/* platform-specific runtime dir */
> +extern char runtime_dir[PATH_MAX];
> +

Those exports will disappear once the symbols are static.


>  extern struct lcore_config lcore_config[RTE_MAX_LCORE];
>
>  /**
> @@ -62,6 +71,9 @@ struct rte_config {
>         struct rte_mem_config *mem_config;
>  } __rte_packed;
>
> +/* Address of global and public configuration */
> +extern struct rte_config rte_config;
> +

Ditto.


>  /**
>   * Get the global configuration structure.
>   *
> diff --git a/lib/librte_eal/common/meson.build b/lib/librte_eal/common/meson.build
> index 3108442697..a16f002a3e 100644
> --- a/lib/librte_eal/common/meson.build
> +++ b/lib/librte_eal/common/meson.build
> @@ -7,6 +7,7 @@ if is_windows
>         sources += files(
>                 'eal_common_bus.c',
>                 'eal_common_class.c',
> +               'eal_common_config.c',
>                 'eal_common_devargs.c',
>                 'eal_common_dynmem.c',
>                 'eal_common_errno.c',
> @@ -34,6 +35,7 @@ sources += files(
>         'eal_common_bus.c',
>         'eal_common_cpuflags.c',
>         'eal_common_class.c',
> +       'eal_common_config.c',
>         'eal_common_devargs.c',
>         'eal_common_dev.c',
>         'eal_common_errno.c',
> diff --git a/lib/librte_eal/freebsd/Makefile b/lib/librte_eal/freebsd/Makefile
> index 2374ba0b7d..7762b3ede4 100644
> --- a/lib/librte_eal/freebsd/Makefile
> +++ b/lib/librte_eal/freebsd/Makefile
> @@ -38,6 +38,7 @@ SRCS-$(CONFIG_RTE_EXEC_ENV_FREEBSD) += eal_alarm.c
>  SRCS-$(CONFIG_RTE_EXEC_ENV_FREEBSD) += eal_dev.c
>
>  # from common dir
> +SRCS-$(CONFIG_RTE_EXEC_ENV_FREEBSD) += eal_common_config.c
>  SRCS-$(CONFIG_RTE_EXEC_ENV_FREEBSD) += eal_common_lcore.c
>  SRCS-$(CONFIG_RTE_EXEC_ENV_FREEBSD) += eal_common_timer.c
>  SRCS-$(CONFIG_RTE_EXEC_ENV_FREEBSD) += eal_common_memzone.c
> diff --git a/lib/librte_eal/freebsd/eal.c b/lib/librte_eal/freebsd/eal.c
> index c41f265fac..eab961232e 100644
> --- a/lib/librte_eal/freebsd/eal.c
> +++ b/lib/librte_eal/freebsd/eal.c
> @@ -58,8 +58,6 @@
>
>  /* Allow the application to print its usage message too if set */
>  static rte_usage_hook_t        rte_application_usage_hook = NULL;
> -/* early configuration structure, when memory config is not mmapped */
> -static struct rte_mem_config early_mem_config;
>
>  /* define fd variable here, because file needs to be kept open for the
>   * duration of the program, as we hold a write lock on it in the primary proc */
> @@ -72,11 +70,6 @@ static struct flock wr_lock = {
>                 .l_len = sizeof(early_mem_config.memsegs),
>  };
>
> -/* Address of global and public configuration */
> -static struct rte_config rte_config = {
> -               .mem_config = &early_mem_config,
> -};
> -
>  /* internal configuration (per-core) */
>  struct lcore_config lcore_config[RTE_MAX_LCORE];
>
> @@ -86,9 +79,6 @@ struct internal_config internal_config;
>  /* used by rte_rdtsc() */
>  int rte_cycles_vmware_tsc_map;
>
> -/* platform-specific runtime dir */
> -static char runtime_dir[PATH_MAX];
> -
>  static const char *default_runtime_dir = "/var/run";
>
>  int
> @@ -151,13 +141,6 @@ eal_clean_runtime_dir(void)
>         return 0;
>  }
>
> -
> -const char *
> -rte_eal_get_runtime_dir(void)
> -{
> -       return runtime_dir;
> -}
> -
>  /* Return user provided mbuf pool ops name */
>  const char *
>  rte_eal_mbuf_user_pool_ops(void)
> @@ -165,19 +148,6 @@ rte_eal_mbuf_user_pool_ops(void)
>         return internal_config.user_mbuf_pool_ops_name;
>  }
>
> -/* Return a pointer to the configuration structure */
> -struct rte_config *
> -rte_eal_get_configuration(void)
> -{
> -       return &rte_config;
> -}
> -
> -enum rte_iova_mode
> -rte_eal_iova_mode(void)
> -{
> -       return rte_eal_get_configuration()->iova_mode;
> -}
> -
>  /* parse a sysfs (or other) file containing one integer value */
>  int
>  eal_parse_sysfs_value(const char *filename, unsigned long *val)
> @@ -983,12 +953,6 @@ rte_eal_cleanup(void)
>         return 0;
>  }
>
> -enum rte_proc_type_t
> -rte_eal_process_type(void)
> -{
> -       return rte_config.process_type;
> -}
> -
>  int rte_eal_has_pci(void)
>  {
>         return !internal_config.no_pci;
> diff --git a/lib/librte_eal/linux/Makefile b/lib/librte_eal/linux/Makefile
> index 07ce643bae..28404b0534 100644
> --- a/lib/librte_eal/linux/Makefile
> +++ b/lib/librte_eal/linux/Makefile
> @@ -45,6 +45,7 @@ SRCS-$(CONFIG_RTE_EXEC_ENV_LINUX) += eal_alarm.c
>  SRCS-$(CONFIG_RTE_EXEC_ENV_LINUX) += eal_dev.c
>
>  # from common dir
> +SRCS-$(CONFIG_RTE_EXEC_ENV_LINUX) += eal_common_config.c
>  SRCS-$(CONFIG_RTE_EXEC_ENV_LINUX) += eal_common_lcore.c
>  SRCS-$(CONFIG_RTE_EXEC_ENV_LINUX) += eal_common_timer.c
>  SRCS-$(CONFIG_RTE_EXEC_ENV_LINUX) += eal_common_memzone.c
> diff --git a/lib/librte_eal/linux/eal.c b/lib/librte_eal/linux/eal.c
> index f162124a37..8cbb8c644c 100644
> --- a/lib/librte_eal/linux/eal.c
> +++ b/lib/librte_eal/linux/eal.c
> @@ -72,9 +72,6 @@
>  /* Allow the application to print its usage message too if set */
>  static rte_usage_hook_t        rte_application_usage_hook = NULL;
>
> -/* early configuration structure, when memory config is not mmapped */
> -static struct rte_mem_config early_mem_config;
> -
>  /* define fd variable here, because file needs to be kept open for the
>   * duration of the program, as we hold a write lock on it in the primary proc */
>  static int mem_cfg_fd = -1;
> @@ -86,11 +83,6 @@ static struct flock wr_lock = {
>                 .l_len = sizeof(early_mem_config.memsegs),
>  };
>
> -/* Address of global and public configuration */
> -static struct rte_config rte_config = {
> -               .mem_config = &early_mem_config,
> -};
> -
>  /* internal configuration (per-core) */
>  struct lcore_config lcore_config[RTE_MAX_LCORE];
>
> @@ -100,9 +92,6 @@ struct internal_config internal_config;
>  /* used by rte_rdtsc() */
>  int rte_cycles_vmware_tsc_map;
>
> -/* platform-specific runtime dir */
> -static char runtime_dir[PATH_MAX];
> -
>  static const char *default_runtime_dir = "/var/run";
>
>  int
> @@ -241,12 +230,6 @@ eal_clean_runtime_dir(void)
>         return -1;
>  }
>
> -const char *
> -rte_eal_get_runtime_dir(void)
> -{
> -       return runtime_dir;
> -}
> -
>  /* Return user provided mbuf pool ops name */
>  const char *
>  rte_eal_mbuf_user_pool_ops(void)
> @@ -254,19 +237,6 @@ rte_eal_mbuf_user_pool_ops(void)
>         return internal_config.user_mbuf_pool_ops_name;
>  }
>
> -/* Return a pointer to the configuration structure */
> -struct rte_config *
> -rte_eal_get_configuration(void)
> -{
> -       return &rte_config;
> -}
> -
> -enum rte_iova_mode
> -rte_eal_iova_mode(void)
> -{
> -       return rte_eal_get_configuration()->iova_mode;
> -}
> -
>  /* parse a sysfs (or other) file containing one integer value */
>  int
>  eal_parse_sysfs_value(const char *filename, unsigned long *val)
> @@ -1343,12 +1313,6 @@ rte_eal_cleanup(void)
>         return 0;
>  }
>
> -enum rte_proc_type_t
> -rte_eal_process_type(void)
> -{
> -       return rte_config.process_type;
> -}
> -
>  int rte_eal_has_hugepages(void)
>  {
>         return ! internal_config.no_hugetlbfs;
> diff --git a/lib/librte_eal/windows/eal.c b/lib/librte_eal/windows/eal.c
> index a43649abc0..506b29bf60 100644
> --- a/lib/librte_eal/windows/eal.c
> +++ b/lib/librte_eal/windows/eal.c
> @@ -32,36 +32,12 @@ static rte_usage_hook_t     rte_application_usage_hook;
>   */
>  static int mem_cfg_fd = -1;
>
> -/* early configuration structure, when memory config is not mmapped */
> -static struct rte_mem_config early_mem_config;
> -
> -/* Address of global and public configuration */
> -static struct rte_config rte_config = {
> -               .mem_config = &early_mem_config,
> -};
> -
>  /* internal configuration (per-core) */
>  struct lcore_config lcore_config[RTE_MAX_LCORE];
>
>  /* internal configuration */
>  struct internal_config internal_config;
>
> -/* platform-specific runtime dir */
> -static char runtime_dir[PATH_MAX];
> -
> -const char *
> -rte_eal_get_runtime_dir(void)
> -{
> -       return runtime_dir;
> -}
> -
> -/* Return a pointer to the configuration structure */
> -struct rte_config *
> -rte_eal_get_configuration(void)
> -{
> -       return &rte_config;
> -}
> -
>  /* Detect if we are a primary or a secondary process */
>  enum rte_proc_type_t
>  eal_proc_type_detect(void)
> @@ -94,24 +70,12 @@ eal_proc_type_detect(void)
>         return ptype;
>  }
>
> -enum rte_proc_type_t
> -rte_eal_process_type(void)
> -{
> -       return rte_config.process_type;
> -}
> -
>  int
>  rte_eal_has_hugepages(void)
>  {
>         return !internal_config.no_hugetlbfs;
>  }
>
> -enum rte_iova_mode
> -rte_eal_iova_mode(void)
> -{
> -       return rte_config.iova_mode;
> -}
> -
>  /* display usage */
>  static void
>  eal_usage(const char *prgname)
> --
> 2.16.1.windows.4
>



-- 
David Marchand


  reply	other threads:[~2020-06-16  8:46 UTC|newest]

Thread overview: 92+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-09 10:31 [dpdk-dev] [PATCH v5 0/8] Windows bus/pci support talshn
2020-06-09 10:31 ` [dpdk-dev] [PATCH v5 1/8] eal: move OS common functions to single file talshn
2020-06-16  8:46   ` David Marchand [this message]
2020-06-18 21:15   ` [dpdk-dev] [PATCH v6 0/9] Windows bus/pci support talshn
2020-06-18 21:15     ` [dpdk-dev] [PATCH v6 1/9] eal: move OS common functions to single file talshn
2020-06-20 19:01       ` Dmitry Kozlyuk
2020-06-21 10:26       ` [dpdk-dev] [PATCH v7 0/9] Windows bus/pci support talshn
2020-06-21 10:26         ` [dpdk-dev] [PATCH v7 1/9] eal: move OS common functions to single file talshn
2020-06-22  7:55           ` [dpdk-dev] [PATCH v8 0/9] Windows bus/pci support talshn
2020-06-22  7:55             ` [dpdk-dev] [PATCH v8 1/9] eal: move OS common functions to single file talshn
2020-06-22 14:54               ` Thomas Monjalon
2020-06-23  6:45                 ` Tal Shnaiderman
2020-06-23  7:16                   ` Thomas Monjalon
2020-06-24  8:28               ` [dpdk-dev] [PATCH v9 00/10] Windows bus/pci support talshn
2020-06-24  8:28                 ` [dpdk-dev] [PATCH v9 01/10] eal: move OS common config objects talshn
2020-06-25 14:18                   ` Thomas Monjalon
2020-06-24  8:28                 ` [dpdk-dev] [PATCH v9 02/10] eal: move OS common options functions talshn
2020-06-25 14:29                   ` Thomas Monjalon
2020-06-24  8:28                 ` [dpdk-dev] [PATCH v9 03/10] pci: use OS generic memory mapping functions talshn
2020-06-24  8:28                 ` [dpdk-dev] [PATCH v9 04/10] pci: build on Windows talshn
2020-06-24  8:28                 ` [dpdk-dev] [PATCH v9 05/10] pci: fix format warning " talshn
2020-06-25 12:54                   ` Thomas Monjalon
2020-06-24  8:28                 ` [dpdk-dev] [PATCH v9 06/10] drivers: ignore pmdinfogen generation for Windows talshn
2020-06-24  8:28                 ` [dpdk-dev] [PATCH v9 07/10] drivers: fix incorrect meson import folder " talshn
2020-06-24  8:28                 ` [dpdk-dev] [PATCH v9 08/10] bus/pci: introduce Windows support with stubs talshn
2020-06-24  8:28                 ` [dpdk-dev] [PATCH v9 09/10] bus/pci: support Windows with bifurcated drivers talshn
2020-06-27  1:46                   ` Narcisa Ana Maria Vasile
2020-06-28 12:10                     ` Tal Shnaiderman
2020-06-24  8:28                 ` [dpdk-dev] [PATCH v9 10/10] build: generate version.map file for MinGW on Windows talshn
2020-06-27  1:54                 ` [dpdk-dev] [PATCH v9 00/10] Windows bus/pci support Narcisa Ana Maria Vasile
2020-06-28 12:32                   ` Tal Shnaiderman
2020-06-29 12:37                 ` [dpdk-dev] [PATCH v10 " talshn
2020-06-29 12:37                   ` [dpdk-dev] [PATCH v10 01/10] eal: move OS common config objects talshn
2020-06-29 15:36                     ` Tal Shnaiderman
2020-06-29 12:37                   ` [dpdk-dev] [PATCH v10 02/10] eal: move OS common options functions talshn
2020-06-29 12:37                   ` [dpdk-dev] [PATCH v10 03/10] pci: use OS generic memory mapping functions talshn
2020-06-29 12:37                   ` [dpdk-dev] [PATCH v10 04/10] pci: build on Windows talshn
2020-06-29 12:37                   ` [dpdk-dev] [PATCH v10 05/10] pci: fix format warning " talshn
2020-06-29 12:37                   ` [dpdk-dev] [PATCH v10 06/10] drivers: ignore pmdinfogen generation for Windows talshn
2020-06-29 12:37                   ` [dpdk-dev] [PATCH v10 07/10] drivers: fix incorrect meson import folder " talshn
2020-06-29 12:37                   ` [dpdk-dev] [PATCH v10 08/10] bus/pci: introduce Windows support with stubs talshn
2020-06-29 20:40                     ` Thomas Monjalon
2020-06-29 12:37                   ` [dpdk-dev] [PATCH v10 09/10] bus/pci: support Windows with bifurcated drivers talshn
2020-06-29 12:37                   ` [dpdk-dev] [PATCH v10 10/10] build: generate version.map file for MinGW on Windows talshn
2020-06-29 22:07                   ` [dpdk-dev] [PATCH v10 00/10] Windows bus/pci support Thomas Monjalon
2020-06-22  7:55             ` [dpdk-dev] [PATCH v8 2/9] pci: use OS generic memory mapping functions talshn
2020-06-22 21:54               ` Dmitry Kozlyuk
2020-06-22  7:55             ` [dpdk-dev] [PATCH v8 3/9] pci: build on Windows talshn
2020-06-22  7:55             ` [dpdk-dev] [PATCH v8 4/9] pci: fix format warning " talshn
2020-06-22  7:55             ` [dpdk-dev] [PATCH v8 5/9] drivers: ignore pmdinfogen generation for Windows talshn
2020-06-22  7:55             ` [dpdk-dev] [PATCH v8 6/9] drivers: fix incorrect meson import folder " talshn
2020-06-22  7:55             ` [dpdk-dev] [PATCH v8 7/9] bus/pci: introduce Windows support with stubs talshn
2020-06-22  7:55             ` [dpdk-dev] [PATCH v8 8/9] bus/pci: support Windows with bifurcated drivers talshn
2020-06-23 23:28               ` Dmitry Kozlyuk
2020-06-24  8:02                 ` Tal Shnaiderman
2020-06-22  7:55             ` [dpdk-dev] [PATCH v8 9/9] build: generate version.map file for MinGW on Windows talshn
2020-06-21 10:26         ` [dpdk-dev] [PATCH v7 2/9] pci: use OS generic memory mapping functions talshn
2020-06-21 10:26         ` [dpdk-dev] [PATCH v7 3/9] pci: build on Windows talshn
2020-06-21 10:26         ` [dpdk-dev] [PATCH v7 4/9] pci: fix format warning " talshn
2020-06-21 10:26         ` [dpdk-dev] [PATCH v7 5/9] drivers: ignore pmdinfogen generation for Windows talshn
2020-06-21 10:26         ` [dpdk-dev] [PATCH v7 6/9] drivers: fix incorrect meson import folder " talshn
2020-06-21 10:26         ` [dpdk-dev] [PATCH v7 7/9] bus/pci: introduce Windows support with stubs talshn
2020-06-21 11:23           ` Fady Bader
2020-06-21 10:26         ` [dpdk-dev] [PATCH v7 8/9] bus/pci: support Windows with bifurcated drivers talshn
2020-06-21 10:26         ` [dpdk-dev] [PATCH v7 9/9] build: generate version.map file for MinGW on Windows talshn
2020-06-18 21:15     ` [dpdk-dev] [PATCH v6 2/9] pci: use OS generic memory mapping functions talshn
2020-06-18 22:44       ` Dmitry Kozlyuk
2020-06-18 21:15     ` [dpdk-dev] [PATCH v6 3/9] pci: build on Windows talshn
2020-06-18 21:15     ` [dpdk-dev] [PATCH v6 4/9] pci: fix format warning " talshn
2020-06-18 21:15     ` [dpdk-dev] [PATCH v6 5/9] drivers: ignore pmdinfogen generation for Windows talshn
2020-06-18 21:15     ` [dpdk-dev] [PATCH v6 6/9] drivers: fix incorrect meson import folder " talshn
2020-06-18 21:15     ` [dpdk-dev] [PATCH v6 7/9] bus/pci: introduce Windows support with stubs talshn
2020-06-18 21:15     ` [dpdk-dev] [PATCH v6 8/9] bus/pci: support Windows with bifurcated drivers talshn
2020-06-18 22:40       ` Dmitry Kozlyuk
2020-06-18 21:15     ` [dpdk-dev] [PATCH v6 9/9] build: generate version.map file for MingW on Windows talshn
2020-06-18 23:13       ` Dmitry Kozlyuk
2020-06-21  6:36         ` Tal Shnaiderman
2020-06-20 18:54       ` Dmitry Kozlyuk
2020-06-21  5:49         ` Tal Shnaiderman
2020-06-09 10:31 ` [dpdk-dev] [PATCH v5 2/8] pci: use OS generic memory mapping functions talshn
2020-06-09 10:31 ` [dpdk-dev] [PATCH v5 3/8] pci: build on Windows talshn
2020-06-16  8:22   ` Thomas Monjalon
2020-06-09 10:31 ` [dpdk-dev] [PATCH v5 4/8] pci: fix format warning " talshn
2020-06-09 10:31 ` [dpdk-dev] [PATCH v5 5/8] drivers: ignore pmdinfogen generation for Windows talshn
2020-06-17 20:39   ` Dmitry Kozlyuk
2020-06-09 10:31 ` [dpdk-dev] [PATCH v5 6/8] drivers: fix incorrect meson import folder " talshn
2020-06-16  8:29   ` Thomas Monjalon
2020-06-16  9:17   ` Bruce Richardson
2020-06-09 10:31 ` [dpdk-dev] [PATCH v5 7/8] bus/pci: introduce Windows support with stubs talshn
2020-06-17 20:29   ` Dmitry Kozlyuk
2020-06-09 10:31 ` [dpdk-dev] [PATCH v5 8/8] bus/pci: support Windows with bifurcated drivers talshn
2020-06-17 20:28   ` Dmitry Kozlyuk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJFAV8xUPn_74c2cDGGZAdFsxGpt0NztQoLBr0XiX14fqE4f9A@mail.gmail.com \
    --to=david.marchand@redhat.com \
    --cc=anatoly.burakov@intel.com \
    --cc=dev@dpdk.org \
    --cc=dmitry.kozliuk@gmail.com \
    --cc=grive@u256.net \
    --cc=harini.ramakrishnan@microsoft.com \
    --cc=navasile@linux.microsoft.com \
    --cc=ocardona@microsoft.com \
    --cc=pallavi.kadam@intel.com \
    --cc=ranjit.menon@intel.com \
    --cc=talshn@mellanox.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).