DPDK patches and discussions
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: Anatoly Burakov <anatoly.burakov@intel.com>
Cc: dev@dpdk.org, Thomas Monjalon <thomas@monjalon.net>,
	bruce.richardson@intel.com, stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] eal: move compat includes to common meson file
Date: Wed, 9 Jan 2019 18:29:32 +0100	[thread overview]
Message-ID: <CAJFAV8xUjcBr8Hk-+Y2ZOY+as1KFu6U4ntxL_-2tNVLFs7s82A@mail.gmail.com> (raw)
In-Reply-To: <98ec658513d481f8d22c8b438cc3fedc4a718d3f.1547054251.git.anatoly.burakov@intel.com>

On Wed, Jan 9, 2019 at 6:18 PM Anatoly Burakov <anatoly.burakov@intel.com>
wrote:

> Currently, while EAL does depend on librte_compat as far as common
> meson build is concerned, for some reason the headers for that
> library are not added into the list of includes. This is fixed in
> Linuxapp-specific meson file, but is absent from FreeBSD meson file.
>
> This worked fine up until recently, when an rte_compat dependency
> was added to rte_log, which is a common header. Fix this issue by
> adding librte_compat includes to common EAL meson file.
>
> Fixes: 844514c73569 ("eal: build with meson")
> Fixes: a8499f65a1d1 ("log: add missing experimental tag")
> Cc: bruce.richardson@intel.com
> Cc: david.marchand@redhat.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
>

lgtm, thanks.

Reviewed-by: David Marchand <david.marchand@redhat.com>


-- 
David Marchand

  reply	other threads:[~2019-01-09 17:29 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-09 17:18 Anatoly Burakov
2019-01-09 17:29 ` David Marchand [this message]
2019-01-09 20:51   ` Bruce Richardson
2019-01-09 21:36     ` Thomas Monjalon
2019-01-10  8:45       ` Burakov, Anatoly
2019-01-10  8:52         ` Thomas Monjalon
2019-01-10 10:02           ` Bruce Richardson
2019-01-10 10:33             ` Thomas Monjalon
2019-01-10 10:34             ` Burakov, Anatoly
2019-01-10 10:41               ` Bruce Richardson
2019-01-10 10:44                 ` David Marchand
2019-01-10 10:48                   ` Bruce Richardson
2019-01-10 11:13                     ` Bruce Richardson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJFAV8xUjcBr8Hk-+Y2ZOY+as1KFu6U4ntxL_-2tNVLFs7s82A@mail.gmail.com \
    --to=david.marchand@redhat.com \
    --cc=anatoly.burakov@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=stable@dpdk.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).