From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua1-f67.google.com (mail-ua1-f67.google.com [209.85.222.67]) by dpdk.org (Postfix) with ESMTP id F19191B547 for ; Wed, 9 Jan 2019 18:29:44 +0100 (CET) Received: by mail-ua1-f67.google.com with SMTP id n7so2670558uao.7 for ; Wed, 09 Jan 2019 09:29:44 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4TvLMHeqZd8w8Ftdlwz5hOGTNp31KyS+sTmc3+/szd8=; b=t+WqFbxYCUcdU9pfXt8LdevEPxneJRHAdHWIz/6lm7JNPiq18xF1eixFValM7hGoqU nbkVo++DmSytQ1Y/yzvBufH5LpdN31ZE8LGRa9qr4nV1P45f4ghuldTN3SJQX4A3kuzC Qi0Ymguj0t1y7/Rm7s5/Be9vxcC79/9WAQ9F/NxNvYfbCjPPBRvM4eEFzaDWlVFWrK9s XN/lzGyS3Q+sYgMbfRdFho4k88CXVdQQHahohj1k1O3NZQ0jOtZvTK7cPRqW5qIAtP3U RKwgShrw2VPdr22bTOr3bFxiHV6vN8eNss19zXIpRQjuzbhTEnWMd6UYD61moYMmuVBt DElQ== X-Gm-Message-State: AJcUukcHGIxOTjJyTlFQNTa5eayQXysqe4RHm5VbU4OlEABrW76AH7HG 5Q3ezVYb8fnemzKy4EEMKFcmym3zNVAgUYHh3kqb0Q== X-Google-Smtp-Source: ALg8bN6tQgkjoMKgK8IjYSH24tJsE7kPVKfQIQcCsL3oixQeoWh5lePqsYbtvsTI1elyzyjE4i+jNmgtxGm/1UTqO50= X-Received: by 2002:ab0:3484:: with SMTP id c4mr2503198uar.39.1547054984329; Wed, 09 Jan 2019 09:29:44 -0800 (PST) MIME-Version: 1.0 References: <98ec658513d481f8d22c8b438cc3fedc4a718d3f.1547054251.git.anatoly.burakov@intel.com> In-Reply-To: <98ec658513d481f8d22c8b438cc3fedc4a718d3f.1547054251.git.anatoly.burakov@intel.com> From: David Marchand Date: Wed, 9 Jan 2019 18:29:32 +0100 Message-ID: To: Anatoly Burakov Cc: dev@dpdk.org, Thomas Monjalon , bruce.richardson@intel.com, stable@dpdk.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] eal: move compat includes to common meson file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jan 2019 17:29:45 -0000 On Wed, Jan 9, 2019 at 6:18 PM Anatoly Burakov wrote: > Currently, while EAL does depend on librte_compat as far as common > meson build is concerned, for some reason the headers for that > library are not added into the list of includes. This is fixed in > Linuxapp-specific meson file, but is absent from FreeBSD meson file. > > This worked fine up until recently, when an rte_compat dependency > was added to rte_log, which is a common header. Fix this issue by > adding librte_compat includes to common EAL meson file. > > Fixes: 844514c73569 ("eal: build with meson") > Fixes: a8499f65a1d1 ("log: add missing experimental tag") > Cc: bruce.richardson@intel.com > Cc: david.marchand@redhat.com > Cc: stable@dpdk.org > > Signed-off-by: Anatoly Burakov > lgtm, thanks. Reviewed-by: David Marchand -- David Marchand