From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 94701A04B1; Wed, 23 Sep 2020 18:29:16 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EC5671D98E; Wed, 23 Sep 2020 18:29:15 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by dpdk.org (Postfix) with ESMTP id 3752D1D8FE for ; Wed, 23 Sep 2020 18:29:14 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1600878553; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gD8f7PXFZq1Lg9+xluObdPBwUiiUWTtZ5fgsaUfKLxc=; b=TA7ayvxETSTP2i5KwQbJI+JkRpSBTMMNTYUMKfxHmdlO/8yiM1UqrBP3UnNumfTZO3Ct0o HOk7Ur1b0w3DCmUexTceQdYzteuIb43eDxxqMU83pKgecbO19SQJURZIjmgpDFU0wcGc7F 2SthbWqy9yMOMxnOc0ugcdjaxv+nRPs= Received: from mail-ua1-f72.google.com (mail-ua1-f72.google.com [209.85.222.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-516-uJ0GQy4PMB22360zBQYTZQ-1; Wed, 23 Sep 2020 12:29:09 -0400 X-MC-Unique: uJ0GQy4PMB22360zBQYTZQ-1 Received: by mail-ua1-f72.google.com with SMTP id j4so80190uan.16 for ; Wed, 23 Sep 2020 09:29:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=gD8f7PXFZq1Lg9+xluObdPBwUiiUWTtZ5fgsaUfKLxc=; b=f4HTSCODrV19HWu7QI8xKDBuMt7lZpmuMTH+3vDnU9QhaVtqwuB9DhAdCVJUH1PDsI xZODrZD93Ak594Hhms5nc4NYY/JdLJCvT8ud9O6AwBoGgu5tpGClQbNOcdztlAAbtEdN l8aNT0py73uVDmiaGIWrIbcM3crLC/3bKoNu5UHqJIFNjlbx7KH1ohV/LpauFklL1nzB IvXg4os6FohiZx6TE30l0YezoJSDloRszBEVADAXwkpX+aenF+3RXDqOkExr7MmTN3Qs 73gbgfdbQwthJsOqnrjb6mVa3fyTTEuyBbhXPdoel82P0msUtrEe2VuTos0TDt5Pb12I EMwA== X-Gm-Message-State: AOAM532CWTE65XhDIqtBeFRK2tpLsgNxRQgZ/zJRr4RJeCtx7Ve0m4m7 NxrKnyQteDogQ/JWncLiZdEkaMyO0ctDfnysNvu2k3590ktqYJVSE3xNiaKErfrOaNmEpGZ4hsO rSJcV45xflV4BGhy3RiA= X-Received: by 2002:a1f:e905:: with SMTP id g5mr914530vkh.17.1600878549061; Wed, 23 Sep 2020 09:29:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx84tV+iJ3V1oseDgwOmOn300oxvSMuIrMJWWHiJnFAcUuaNAsHEobO7/MzCbnLIKl5RFbyS+CaKHttapQumSc= X-Received: by 2002:a1f:e905:: with SMTP id g5mr914516vkh.17.1600878548732; Wed, 23 Sep 2020 09:29:08 -0700 (PDT) MIME-Version: 1.0 References: <20200908201830.74206-2-cristian.dumitrescu@intel.com> <20200910152645.9342-1-cristian.dumitrescu@intel.com> In-Reply-To: From: David Marchand Date: Wed, 23 Sep 2020 18:28:57 +0200 Message-ID: To: "Dumitrescu, Cristian" Cc: dev , Thomas Monjalon Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v4 00/41] Pipeline alignment with the P4 language X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Sep 23, 2020 at 6:08 PM Dumitrescu, Cristian wrote: > > - Many MACRO_WITH_FLOW_CONTROL warnings reported by checkpatches. > > > > Yes, I fixed all the other code style issues, this is the only one remain= ing. It is basically due to a recurring CHECK() macro. And it will also rip= ples over the code, so IMO it is time consuming & error prone to remove wit= h no real benefit. > > We also already have many places in DPDK that use the same pattern. I sug= gest we ignore this warning, are you OK with it? I am fine with ignoring, this is not like we have no other occurrence of such macros. I still see little value in those specific macros. > > - On the patch titles, check-git-log.sh reports: > > Wrong headline case: > > "pipeline: add SWX dma instruction": dma --> DMA > > Wrong headline case: > > "pipeline: add SWX rx and extract instructions": rx --> Rx > > Wrong headline case: > > "pipeline: add SWX tx and emit instructions": tx --> Tx > > Wrong headline case: > > "pipeline: introduce SWX xor instruction": xor --> XOR > > > > I can do this change, but IMO it is not the right choice here, as in this= particular case we have instructions that are called "rx", "tx", "dma", "a= nd", "or", "xor", etc. So it is the name of an instruction rather than a te= xt abbreviation. Hence, I think these messages are not really applicable he= re. What do you think? For this reason I am ok with ignoring too, Thomas wdyt? --=20 David Marchand