From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua1-f43.google.com (mail-ua1-f43.google.com [209.85.222.43]) by dpdk.org (Postfix) with ESMTP id 1F6A41BD70 for ; Fri, 21 Dec 2018 09:28:09 +0100 (CET) Received: by mail-ua1-f43.google.com with SMTP id u19so1439086uae.4 for ; Fri, 21 Dec 2018 00:28:09 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FM78UbAUQ0pXMzU8uhmB26iLHqbUhO5kxJGxSzLTjNc=; b=tSUAFzzzr+1d5bIJAsrUjJOEb5qF/tNKYW9wJPP3xyALqjaZ4JjR2ymnpA8MidyHh8 3K0/7rINdyysEP6EYAUqDYoF4YhQHtq+DMaq8Ow9K36yOZNR/ICe2bdIjPDS7DIupIte ZaEveV9Sv/y1kgNEw3JcKxw0I5zdU42ESBetxKDkqWAyXJOCCUk7tci8Eq5jIfudVLFa QOvehiQyME0i9BbI7pxsw6XPG/eug95X/ScaAO/G5pG3YSnxQmt0RKKcQSIULjL8RLxK msPXNeGnVnU4Uvrbf4AZTYVWVIBhxHrhuaPc6nEQFHfu2SLSfbLJMDerrXoasIpKFhrO AH0A== X-Gm-Message-State: AJcUukccPSmBmKztTSwcXPBYI8DVpRdulEYJbbeF2L2PhC6Du1hFtQmk Za1mSTyLu8yurXECiwBRvfXqwrZHdnjQCrcsBef3JA== X-Google-Smtp-Source: ALg8bN7oFDRtTdQ0uiua2TCUkI5DWNJCXK2dufMQ80BqKpKHNHzABvUJg3aro3+/e6txAoq3LIptgt+r8e0mckhAR4Y= X-Received: by 2002:ab0:3484:: with SMTP id c4mr568475uar.39.1545380888467; Fri, 21 Dec 2018 00:28:08 -0800 (PST) MIME-Version: 1.0 References: <1545300049-7463-1-git-send-email-hari.kumarx.vemula@intel.com> In-Reply-To: <1545300049-7463-1-git-send-email-hari.kumarx.vemula@intel.com> From: David Marchand Date: Fri, 21 Dec 2018 09:27:56 +0100 Message-ID: To: Hari Kumar Vemula Cc: dev@dpdk.org, reshma.pattan@intel.com, "Yigit, Ferruh" , stable@dpdk.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] eal: fix core number validation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Dec 2018 08:28:09 -0000 On Thu, Dec 20, 2018 at 11:01 AM Hari Kumar Vemula < hari.kumarx.vemula@intel.com> wrote: > When incorrect core value or range provided, > as part of -l command line option, a crash occurs. > > Added valid range checks to fix the crash. > > Fixes: d888cb8b9613 ("eal: add core list input format") > Cc: stable@dpdk.org > > Signed-off-by: Hari Kumar Vemula > Thanks for reporting. I agree that some validation steps are missing, but I tried a little bit and did not reproduce a crash. On my 8 cores system: [dmarchan@dmarchan dpdk]$ ./master/app/testpmd --no-huge -l 567890,567891,567892 -m 512 --log-level *:debug -- -i --total-num-mbufs 2048 [...] EAL: Support maximum 128 logical core(s) by configuration. EAL: Detected 8 lcore(s) [...] EAL: invalid core list Usage: ./master/app/testpmd [options] etc... [dmarchan@dmarchan dpdk]$ ./master/app/testpmd --no-huge -l 2,3,-1 -m 512 --log-level *:debug -- -i --total-num-mbufs 2048 [...] EAL: Support maximum 128 logical core(s) by configuration. EAL: Detected 8 lcore(s) EAL: Detected 1 NUMA nodes [...] Done testpmd> Bye... Idem with [dmarchan@dmarchan dpdk]$ ./master/app/testpmd --no-huge -l 2,3,567890 -m 512 --log-level *:debug -- -i --total-num-mbufs 2048 [...] EAL: Support maximum 128 logical core(s) by configuration. EAL: Detected 8 lcore(s) EAL: Detected 1 NUMA nodes [...] Done testpmd> Bye... Since you have identified a potential crash, can you give an example of such a crash ? Besides, we have tests that check arguments, so an update of the test would be nice. Thanks. -- David Marchand