From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 54AAD45C13; Wed, 30 Oct 2024 10:26:56 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3CC5543372; Wed, 30 Oct 2024 10:26:56 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 0A77042FB9 for <dev@dpdk.org>; Wed, 30 Oct 2024 10:26:53 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1730280413; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=r3/aWt660skRTTIPHSaBu5MyyuP5bOmpJmoDq6n7PQA=; b=GG+WL5aF+zX12CK6NwI+JWMQwzOF7PcR+nsr1Cl9+k4vqjcjqAXtMlkalLXaogC+kDHDfQ aVNgSIo5lMf4EAdr6Uaz5JmaPgdfJbuJ7Avz1Y2v8gVytymr1rm99U4eJI5mqHJjvtU3HQ BS2cnzhX1/zk4NsmroHMpoaMEDnmwuo= Received: from mail-lj1-f197.google.com (mail-lj1-f197.google.com [209.85.208.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-613-M2BGemPmMM60SFaYix6sZw-1; Wed, 30 Oct 2024 05:26:51 -0400 X-MC-Unique: M2BGemPmMM60SFaYix6sZw-1 Received: by mail-lj1-f197.google.com with SMTP id 38308e7fff4ca-2f75cf9472dso37207651fa.3 for <dev@dpdk.org>; Wed, 30 Oct 2024 02:26:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730280410; x=1730885210; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=r3/aWt660skRTTIPHSaBu5MyyuP5bOmpJmoDq6n7PQA=; b=mCgbW66G3IW8p2/qqpy7RdSWgJtzk6qlsCb7H23tF8YFwqHhYMZeWpikg4HVxYZdHG 1GqTMP3CwCFQ7Asc1uUZa7D8+ikLu3BGjeMDrn3FvzTrLmZT2QC+hb9PP17ot9HVMCK1 czkD9yFPwbUkw6Ylsv5f9E/qtk5jb07raUlFObQO6Vj8kibywsLW0GVm/BIIkzzb2RSh wufD0AIePzioWZ+VHEwe5hcGl1g5QyJoAMwORLheMgh7BYECZwN3bKxR44PEfx2Xd/FD cSGgtPrwz6H4rgYkN/PTAhzOwrzxc6Q+G+VrErp5bLCrd6X5QmdWck6pBMEgMSojt1FB /xSw== X-Gm-Message-State: AOJu0YzYOVOzVTvLyt3jQwY0kdwW2U6sCnRwuMQmYAGRz3gyFD7+DaEK Uj2rZ7GPeJhq+M9X85zlELNW54gPOoecI8u5b3C4EiaXD7dRa/cvbqT30klYrtjy2el9Md0j9ps z7pXoIpRR093YPIMUHq0oY8oZH8/VW7YeN/DzTOcTQFcA00Oe38crtEIQEv5JVeWETcxKMalrja BydipBe25h9Pw+Hiw= X-Received: by 2002:a2e:b8d2:0:b0:2fb:587d:2ee with SMTP id 38308e7fff4ca-2fcbdf7d926mr67627601fa.12.1730280410212; Wed, 30 Oct 2024 02:26:50 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG8uzmgEqzgP4k7guU3RYyUxBxOu01reBpctOzIApZESkrZ9Nnh7QXWKS4Y+YEL52FxgN5Fpy+o89omUGT6HiA= X-Received: by 2002:a2e:b8d2:0:b0:2fb:587d:2ee with SMTP id 38308e7fff4ca-2fcbdf7d926mr67627401fa.12.1730280409788; Wed, 30 Oct 2024 02:26:49 -0700 (PDT) MIME-Version: 1.0 References: <20241022023728.451151-1-stephen@networkplumber.org> In-Reply-To: <20241022023728.451151-1-stephen@networkplumber.org> From: David Marchand <david.marchand@redhat.com> Date: Wed, 30 Oct 2024 10:26:38 +0100 Message-ID: <CAJFAV8xWDXBxF+Ja+QSiPoZ6zPaycZ0Exm+89C1fY273JMKx3Q@mail.gmail.com> Subject: Re: [PATCH] bus/vmbus: remove unnecessary packed attribute To: Stephen Hemminger <stephen@networkplumber.org> Cc: dev@dpdk.org, Long Li <longli@microsoft.com>, Wei Hu <weh@microsoft.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On Tue, Oct 22, 2024 at 4:37=E2=80=AFAM Stephen Hemminger <stephen@networkplumber.org> wrote: > > The VMBus ring structure was marked packed which will cause > warnings if the no-address-of-packed is enabled. The structure > is all 32 bit values and the packed attribute has no impact > on the code layout; remove it. > > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org> - Why only clean this structure in this header? I see many others which could get cleaned wrt __rte_packed. (There are some unused structs too and it would be better not to keep unused code around). - On a separate note, I wonder why the vmbus headers are exported as public headers. All those seem to be for use only in drivers, for resources attached on such a bus. Would an application benefit from talking directly to the hyperv? --=20 David Marchand