From: David Marchand <david.marchand@redhat.com>
To: David Marchand <david.marchand@redhat.com>
Cc: Aaron Conole <aconole@redhat.com>,
Andre Muezerie <andremue@linux.microsoft.com>,
dev@dpdk.org, thomas@monjalon.net,
Michael Santana <maicolgabriel@hotmail.com>
Subject: Re: [PATCH] ci: build with MSVC in GHA
Date: Wed, 19 Feb 2025 09:09:27 +0100 [thread overview]
Message-ID: <CAJFAV8xWNv5CX16coq1qBwxjY0r3Wg21giXZt5_uA9WzkzTq8A@mail.gmail.com> (raw)
In-Reply-To: <20250218153508.GA20690@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
On Tue, Feb 18, 2025 at 4:36 PM Andre Muezerie
<andremue@linux.microsoft.com> wrote:
> > > > Add a build target in Windows 2022 for MSVC.
> > > >
> > > > Loading MSVC environment and having successive commands in a single
> > > > (cmd or pwsh) shell does not seem to correctly report if one of the
> > > > commands failed.
> > > > For now, load MSVC environment and run commands in separate shells.
Cc: stable@dpdk.org
> > > > Signed-off-by: David Marchand <david.marchand@redhat.com>
> > > Acked-by: Aaron Conole <aconole@redhat.com>
> LGTM.
> --
> Andre Muezerie
Applied, thanks.
--
David Marchand
next prev parent reply other threads:[~2025-02-19 8:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-13 7:50 David Marchand
2025-02-18 13:32 ` Aaron Conole
2025-02-18 14:10 ` David Marchand
2025-02-18 15:35 ` Andre Muezerie
2025-02-19 8:09 ` David Marchand [this message]
2025-02-18 19:45 ` Aaron Conole
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8xWNv5CX16coq1qBwxjY0r3Wg21giXZt5_uA9WzkzTq8A@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=aconole@redhat.com \
--cc=andremue@linux.microsoft.com \
--cc=dev@dpdk.org \
--cc=maicolgabriel@hotmail.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).