From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0B201A00C2; Mon, 26 Sep 2022 11:39:30 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E92C84069B; Mon, 26 Sep 2022 11:39:29 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 4CA9F400D7 for ; Mon, 26 Sep 2022 11:39:28 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1664185167; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TBDkRilBCouKImg74ng9yln9BKJPHLJxq5JdQQoHh/s=; b=Aut+ZJKLIbT059I3Okvy55bCSEEltJX6UWyyObQO/huaw1P7LNOprR0zrnQgdy0l2we3HJ HOJYL+u9MBv713mSaJNlb4wPTxB/vtWXPnLpifyJMghLc//J3sWeNmu64IcYNvQwaMAnBB nohb3UvN0AbLgwBYda+LuFPnc9rt4eM= Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-121-by86SEDdOPSE82Ar3B0JAA-1; Mon, 26 Sep 2022 05:39:26 -0400 X-MC-Unique: by86SEDdOPSE82Ar3B0JAA-1 Received: by mail-ed1-f70.google.com with SMTP id y14-20020a056402440e00b0044301c7ccd9so4942954eda.19 for ; Mon, 26 Sep 2022 02:39:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date; bh=TBDkRilBCouKImg74ng9yln9BKJPHLJxq5JdQQoHh/s=; b=EkYIg/QW/8wpl40M/QF298K22hvMEktlWHIU7vFAzp7XM5DL6FQW0l7UHZEXRtIdBK VY5RSovrK54RmtkgdDYGRJpsWFW3L2R5VvpZ5Twv8q2L6uw67Efk/7zaVuF1U/hQcxJa byFEe+2rLvt4RET45TDh+t+n31gy8RHqs27wgeo5cnnoVlLBIV+1604Tl8Y4yooh1brM 4qq7TnxpckWZnpq4QbUxA70eK6LNvupGu/rMj+E1mjxOHyUIwXmcG64SENbfXPPU0vTC 1xEbzFgxNFieNAH5BPdGdWb72TJoHqnAEnz1eJv3gamYxEgWvrr07DY39CbC48Y1BwZI jSLw== X-Gm-Message-State: ACrzQf0bInl8yv9aCmhqIO0DVZU2Uvrbs3Apxh8xirMu8pQ2GRSOfxBt o85Ike05V0wNkd/iQt+zlWmQoaaQj8y8h+JEUemH/2NX+FC60NGtXviRxzi4pt7BZikJU5MLXfJ 4poZXu4gOVsZ6BN5kDGM= X-Received: by 2002:a17:906:fe04:b0:777:b13d:30a6 with SMTP id wy4-20020a170906fe0400b00777b13d30a6mr17009183ejb.248.1664185165538; Mon, 26 Sep 2022 02:39:25 -0700 (PDT) X-Google-Smtp-Source: AMsMyM78NxRxHcM0e88ljBlOHjBK5U7jXs3ROcQtXSdAZdylO3Wnyjh1+D+L5Vh0zXHMOjoNOkoQduaEIYsaPzyiOgs= X-Received: by 2002:a17:906:fe04:b0:777:b13d:30a6 with SMTP id wy4-20020a170906fe0400b00777b13d30a6mr17009162ejb.248.1664185165315; Mon, 26 Sep 2022 02:39:25 -0700 (PDT) MIME-Version: 1.0 References: <20220922081843.50b6d22e@hermes.local> <20220923070613.697210-1-omer.yamac@ceng.metu.edu.tr> In-Reply-To: <20220923070613.697210-1-omer.yamac@ceng.metu.edu.tr> From: David Marchand Date: Mon, 26 Sep 2022 11:39:13 +0200 Message-ID: Subject: Re: [PATCH v3] eal: update lcore-worker name due to high number of cores To: =?UTF-8?B?QWJkdWxsYWggw5ZtZXIgWWFtYcOn?= , Kevin Traynor , Luca Boccassi , "Xueming(Steven) Li" , Christian Ehrhardt Cc: dev@dpdk.org, ferruh.yigit@xilinx.com, Stephen Hemminger X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hello, On Fri, Sep 23, 2022 at 9:06 AM Abdullah =C3=96mer Yama=C3=A7 wrote: > > In this patch we suggest a new name for lcore-worker. > In case of more than 99 logical cores, name is truncated > (length is restricted to 16 characters, including the > terminating null byte ('\0')) and it makes hard to follow threads. > > Signed-off-by: Abdullah =C3=96mer Yama=C3=A7 > Acked-by: Stephen Hemminger - Thanks, good catch. Some comments though. What matters is the lcore index, not the core/lcore count. The commitlog could probably describe this better. For example, this issue can be triggered with --lcores=3D0,10@1,100@2 and here we only have three lcores. $ cat /proc/$(pidof dpdk-testpmd)/task/*/comm dpdk-testpmd eal-intr-thread rte_mp_handle lcore-worker-10 lcore-worker-10 telemetry-v2 telemetry-v1 And what do you think of following title: "eal: fix thread names for high order lcores" Can you update the release notes? - Question to stable maintainers: Do you think we should backport this fix? As you can see below, this change affects EAL thread names, maybe some users are monitoring them based on the names... > > --- > Cc: David Marchand > --- > lib/eal/freebsd/eal.c | 2 +- > lib/eal/linux/eal.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/lib/eal/freebsd/eal.c b/lib/eal/freebsd/eal.c > index ee5c929da8..a1bb5363b1 100644 > --- a/lib/eal/freebsd/eal.c > +++ b/lib/eal/freebsd/eal.c > @@ -817,7 +817,7 @@ rte_eal_init(int argc, char **argv) > > /* Set thread_name for aid in debugging. */ > snprintf(thread_name, sizeof(thread_name), > - "lcore-worker-%d", i); > + "rte-worker-%d", i); > rte_thread_setname(lcore_config[i].thread_id, thread_name= ); > > ret =3D pthread_setaffinity_np(lcore_config[i].thread_id, > diff --git a/lib/eal/linux/eal.c b/lib/eal/linux/eal.c > index 46bf52cef0..9a168b7773 100644 > --- a/lib/eal/linux/eal.c > +++ b/lib/eal/linux/eal.c > @@ -1248,7 +1248,7 @@ rte_eal_init(int argc, char **argv) > > /* Set thread_name for aid in debugging. */ > snprintf(thread_name, sizeof(thread_name), > - "lcore-worker-%d", i); > + "rte-worker-%d", i); > ret =3D rte_thread_setname(lcore_config[i].thread_id, > thread_name); > if (ret !=3D 0) > -- > 2.27.0 > Merci ! --=20 David Marchand