From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C28C9A0562; Wed, 14 Apr 2021 16:15:00 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AC621161B57; Wed, 14 Apr 2021 16:15:00 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 788BA161B4F for ; Wed, 14 Apr 2021 16:14:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618409698; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=q+e4aR/OOrrzFrsDWZxsvm8USpxMkaDe4sd0NU4ISFY=; b=YS7oj8gvPj7ZPUAQ6USRh7ShFaqI/4Rz6QLGygwKp6dRbqbcXpdVo+qPE9J9wE0vLd5Z3q jBMwR3Vc530IEDA0kuIz18ZsrUOKNScH5/Qmno+AroEutpvSa/EsOOPuwlkbBrFE6Es9V1 /SBcwTmPjowaN49PPtKHIfeSPgrwLvw= Received: from mail-vs1-f70.google.com (mail-vs1-f70.google.com [209.85.217.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-553-VGQ_ELmLMOGlwlHINqfEAw-1; Wed, 14 Apr 2021 10:14:57 -0400 X-MC-Unique: VGQ_ELmLMOGlwlHINqfEAw-1 Received: by mail-vs1-f70.google.com with SMTP id w2-20020a67ffc20000b02901c5449f589eso2048419vsq.20 for ; Wed, 14 Apr 2021 07:14:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=q+e4aR/OOrrzFrsDWZxsvm8USpxMkaDe4sd0NU4ISFY=; b=CGXt4zzGYjqQF9qhmzdLGe6looMcbHgWk44MVz9lyk21aNpzFT3Pgifrj5N/IeIMst KzgVLXgK6COqrEC0AqD4idymXP2ooqyfex4PfiTpFkxH9d6kgQE9TR7tchF8KY9Nj1/1 nDGrrFvk9b52bQZDzFcnhjpGFVhIaSe8B7FUykFAdLI4qX/dhzFZO9x2sjDd9wj3oNno v55s1hj3SIx++X7YL2ZE7o3NZwkwsH+UdG+zBtuNiQykzeHuZA6Ofs1k6FZlOnQfQsYU wvEEcRFHRDBgPqRamFR7WxkI7stSNgO+bE/SEzQN0nA59JTzYDnhiRqEHBzzPg3EDbrJ Mz3g== X-Gm-Message-State: AOAM53321/vYtyOulLOZPeDoe8/YoRgHj3cvL2Q9uJSkoqZNg4LUdvpk 1T/8TR1Yg1W+HcEWcWBx8FE9zzeLwJ3zcHdH4jasnHx8c9xznCOEIEStPdAGmZHW3US5jKzs+xH Co+wQ/GjyBCN/8sKChtc= X-Received: by 2002:ab0:7616:: with SMTP id o22mr16042799uap.126.1618409696546; Wed, 14 Apr 2021 07:14:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxa2xTROsmgyPjD+jdLcHmSORNXca2XAAB2TpOfEPUIgN9fnEHkCdBaQWF3yMiLpQ3QgPoFcQ6iVYUnCITTulk= X-Received: by 2002:ab0:7616:: with SMTP id o22mr16042761uap.126.1618409696313; Wed, 14 Apr 2021 07:14:56 -0700 (PDT) MIME-Version: 1.0 References: <20201222063054.44429-1-feifei.wang2@arm.com> <20210310021527.19305-1-feifei.wang2@arm.com> <20210310021527.19305-2-feifei.wang2@arm.com> In-Reply-To: <20210310021527.19305-2-feifei.wang2@arm.com> From: David Marchand Date: Wed, 14 Apr 2021 16:14:44 +0200 Message-ID: To: Feifei Wang Cc: Jerin Jacob , Sunil Kumar Kori , dev , nd , dpdk stable , Honnappa Nagarahalli , Ruifeng Wang , Pavan Nikhilesh Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v3 1/1] test/trace: collect perf data after worker threads exit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Mar 10, 2021 at 3:15 AM Feifei Wang wrote: > > The measure_perf function should be executed after worker threads exit > to collect correct perf data. Otherwise, while workers are running, the > main thread may get incomplete data from workers. > > In the meanwhile, remove unnecessary barrier in the test. > For signal variables "ldata.done" and "ldata.start", no operations > should keep the order that being executed after them. So the wmb after > them can be moved. > > Fixes: 16a277a24c9f ("test/trace: add performance test cases") > Cc: stable@dpdk.org > > Suggested-by: Honnappa Nagarahalli > Signed-off-by: Feifei Wang > Reviewed-by: Honnappa Nagarahalli > Reviewed-by: Ruifeng Wang > Acked-by: Pavan Nikhilesh > Acked-by: Jerin Jacob Applied, thanks. -- David Marchand