DPDK patches and discussions
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
	 "Ruifeng Wang (Arm Technology China)" <ruifeng.wang@arm.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	Thomas Monjalon <thomas@monjalon.net>,
	 Ferruh Yigit <ferruh.yigit@intel.com>,
	Luca Boccassi <bluca@debian.org>, nd <nd@arm.com>
Subject: Re: [dpdk-dev] DPDK Release Status Meeting 12/11/2020
Date: Thu, 12 Nov 2020 12:57:45 +0100	[thread overview]
Message-ID: <CAJFAV8xXp6Sd56PYHwvMCa-wgV4gkcvz8E79wT1yGC5g7Ln3dg@mail.gmail.com> (raw)
In-Reply-To: <5735a4fd-5b51-dc15-9afc-bd8ab70cacfd@intel.com>

On Thu, Nov 12, 2020 at 12:39 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>    * In suse build environment, there are some arm and PPC build error
>      * For arm the RHEL 7 compiler for arm is too old
>        * Can be possible to disable the failing driver and still test the rest

Luca also mentioned an issue on Centos 8.


Interestingly, I am not able to reproduce it in my OBS env.
https://build.opensuse.org/build/home:dmarchan/home_bluca_dpdk_CentOS_8/aarch64/dpdk/_log

[  135s] [118/2414] cc -Ilib/76b5a35@@rte_net@sta -Ilib -I../lib
-Ilib/librte_net -I../lib/librte_net -I. -I../ -Iconfig -I../config
-Ilib/librte_eal/include -I../lib/librte_eal/include
-Ilib/librte_eal/linux/include -I../lib/librte_eal/linux/include
-Ilib/librte_eal/arm/include -I../lib/librte_eal/arm/include
-Ilib/librte_eal/common -I../lib/librte_eal/common -Ilib/librte_eal
-I../lib/librte_eal -Ilib/librte_kvargs -I../lib/librte_kvargs
-Ilib/librte_telemetry/../librte_metrics
-I../lib/librte_telemetry/../librte_metrics -Ilib/librte_telemetry
-I../lib/librte_telemetry -Ilib/librte_mbuf -I../lib/librte_mbuf
-Ilib/librte_mempool -I../lib/librte_mempool -Ilib/librte_ring
-I../lib/librte_ring -fdiagnostics-color=always -pipe
-D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -O3 -include rte_config.h
-Wextra -Wcast-qual -Wdeprecated -Wmissing-declarations
-Wmissing-prototypes -Wnested-externs -Wold-style-definition
-Wpointer-arith -Wsign-compare -Wstrict-prototypes -Wundef
-Wwrite-strings -Wno-packed-not-aligned
-Wno-missing-field-initializers -D_GNU_SOURCE -fcommon -Werror -fPIC
-march=armv8.1-a+crc+crypto -mcpu=thunderx2t99
-DALLOW_EXPERIMENTAL_API -DALLOW_INTERNAL_API -Wno-format-truncation
-DCC_ARM64_NEON_PMULL_SUPPORT  -MD -MQ
'lib/76b5a35@@rte_net@sta/librte_net_net_crc_neon.c.o' -MF
'lib/76b5a35@@rte_net@sta/librte_net_net_crc_neon.c.o.d' -o
'lib/76b5a35@@rte_net@sta/librte_net_net_crc_neon.c.o' -c
../lib/librte_net/net_crc_neon.c

Looking at Luca env log:
https://build.opensuse.org/build/home:bluca:dpdk/CentOS_8/aarch64/dpdk/_log

[  290s] [117/2414] cc -Ilib/76b5a35@@rte_net@sta -Ilib -I../lib
-Ilib/librte_net -I../lib/librte_net -I. -I../ -Iconfig -I../config
-Ilib/librte_eal/include -I../lib/librte_eal/include
-Ilib/librte_eal/linux/include -I../lib/librte_eal/linux/include
-Ilib/librte_eal/arm/include -I../lib/librte_eal/arm/include
-Ilib/librte_eal/common -I../lib/librte_eal/common -Ilib/librte_eal
-I../lib/librte_eal -Ilib/librte_kvargs -I../lib/librte_kvargs
-Ilib/librte_telemetry/../librte_metrics
-I../lib/librte_telemetry/../librte_metrics -Ilib/librte_telemetry
-I../lib/librte_telemetry -Ilib/librte_mbuf -I../lib/librte_mbuf
-Ilib/librte_mempool -I../lib/librte_mempool -Ilib/librte_ring
-I../lib/librte_ring -fdiagnostics-color=always -pipe
-D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -O3 -include rte_config.h
-Wextra -Wcast-qual -Wdeprecated -Wmissing-declarations
-Wmissing-prototypes -Wnested-externs -Wold-style-definition
-Wpointer-arith -Wsign-compare -Wstrict-prototypes -Wundef
-Wwrite-strings -Wno-packed-not-aligned
-Wno-missing-field-initializers -D_GNU_SOURCE -fcommon -Werror -fPIC
-mcpu=thunderxt88 -DALLOW_EXPERIMENTAL_API -DALLOW_INTERNAL_API
-Wno-format-truncation -DCC_ARM64_NEON_PMULL_SUPPORT  -MD -MQ
'lib/76b5a35@@rte_net@sta/librte_net_net_crc_neon.c.o' -MF
'lib/76b5a35@@rte_net@sta/librte_net_net_crc_neon.c.o.d' -o
'lib/76b5a35@@rte_net@sta/librte_net_net_crc_neon.c.o' -c
../lib/librte_net/net_crc_neon.c
...
[  290s] ../lib/librte_net/net_crc_neon.c: In function 'crcr32_folding_round':
[  290s] /usr/lib/gcc/aarch64-redhat-linux/8/include/arm_neon.h:26094:1:
error: inlining failed in call to always_inline 'vmull_p64': target
specific option mismatch
[  290s]  vmull_p64 (poly64_t a, poly64_t b)
[  290s]  ^~~~~~~~~


The difference is:
- for me -march=armv8.1-a+crc+crypto -mcpu=thunderx2t99 (working)
- for Luca -mcpu=thunderxt88 (*not* working)

Could you ARM guys have a look?
My gut feeling is that there is some check missing in
lib/librte_net/meson.build, maybe checking for __ARM_NEON in addition
to the check on __ARM_FEATURE_CRYPTO?


Thanks!

-- 
David Marchand


  reply	other threads:[~2020-11-12 11:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-12 11:39 Ferruh Yigit
2020-11-12 11:57 ` David Marchand [this message]
2020-11-18  6:24   ` Ruifeng Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJFAV8xXp6Sd56PYHwvMCa-wgV4gkcvz8E79wT1yGC5g7Ln3dg@mail.gmail.com \
    --to=david.marchand@redhat.com \
    --cc=bluca@debian.org \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=jerinj@marvell.com \
    --cc=nd@arm.com \
    --cc=ruifeng.wang@arm.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).