From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 036AC42C98; Mon, 12 Jun 2023 15:09:37 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CD4FD4114A; Mon, 12 Jun 2023 15:09:36 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id CC84541138 for ; Mon, 12 Jun 2023 15:09:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686575374; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LzUnojaEAH2vSdVqPBiqrXBK+BadUdlh+TwcjCm0AF4=; b=NsmyIXO1U3w9SFsfljxt36xSLU4lkcc/3YGzFTVGht5f+AU4/kpcuIQwXymAyHMrHgyuqY Jn2h+CiZvWaiS4mFYvASTyykbKodib+/iAyuxA+0vJS0vDhUVqfZmbgdhiPYIZ/zDyokq1 ybvZ6Q3bgXEdnigeIq1nmUP/1rmlnKU= Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-77-qxYbFAlJNTOW_eJWys_2Kw-1; Mon, 12 Jun 2023 09:09:32 -0400 X-MC-Unique: qxYbFAlJNTOW_eJWys_2Kw-1 Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-25910abc536so1769093a91.2 for ; Mon, 12 Jun 2023 06:09:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686575372; x=1689167372; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LzUnojaEAH2vSdVqPBiqrXBK+BadUdlh+TwcjCm0AF4=; b=ECoFsSr008JJ1vSTOwrvIk58Er6mR2haOUZ6pGm97WXxa61f6i3ynWP6Djbg1panSk R9u9KYxQRuVt3NCXBZ4duVex6/WrhytzRNXE38SYIgTtT30//rX2ChsE8yyMz5VWNvTB EpuMQtWaiVlw0VqKWl+zMT3gOGUIXmXISmRcr/9Y9N4kHToK7PBLQ8OiXdeDHjEQm5qX bsMDsL78sj7NfWF2IEOBg3nXQxpGlo7eWI5QxvSHUScLavRtcyo8SVvEY+dg/vJ2q13h jFnzkBuR89PKU3XHjRPDQTwMxSdL8z5QVUGpoXDu+zNLNWNJt4Igeqn6vQUae8giYEyh 2srQ== X-Gm-Message-State: AC+VfDy5oEjiSc+veS18uFvoaJWJtNBAh4EH+w/ei/m6fFmbBl9tgctl IQUNwz+PlPV45guRD3qjmHJu5h4PEi6xsRS5Fm5tfHGYwThnV1e3ynSftINTEyX6qDqkoEFIZz3 rqOMSiPsRIfFFEsjZjHU= X-Received: by 2002:a17:90a:5918:b0:256:5dec:50ed with SMTP id k24-20020a17090a591800b002565dec50edmr7875674pji.7.1686575371698; Mon, 12 Jun 2023 06:09:31 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ42nyQcsucNeMWOuGQHiIVFskIYnBJ9UzIZ7h7KHTbAxQBlAuLwH3jopqip9QwspXKTZzlfVDaPck34gCoo/YM= X-Received: by 2002:a17:90a:5918:b0:256:5dec:50ed with SMTP id k24-20020a17090a591800b002565dec50edmr7875655pji.7.1686575371397; Mon, 12 Jun 2023 06:09:31 -0700 (PDT) MIME-Version: 1.0 References: <20230529112155.11247-1-changfengnan@bytedance.com> In-Reply-To: <20230529112155.11247-1-changfengnan@bytedance.com> From: David Marchand Date: Mon, 12 Jun 2023 15:09:20 +0200 Message-ID: Subject: Re: [PATCH] eal: fix prompt info when remap_segment failed To: Fengnan Chang Cc: anatoly.burakov@intel.com, dev@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, May 29, 2023 at 1:22=E2=80=AFPM Fengnan Chang wrote: > > when there is enough space for memseg, we should pormpt which > config to modify, not just print numbers. I think you want to explain the case when there is *not* enough objects declared in the static configuration. Could you rephrase and fix the typos? > > Signed-off-by: Fengnan Chang > --- > lib/eal/linux/eal_memory.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/lib/eal/linux/eal_memory.c b/lib/eal/linux/eal_memory.c > index 0876974631..974db901b7 100644 > --- a/lib/eal/linux/eal_memory.c > +++ b/lib/eal/linux/eal_memory.c > @@ -716,9 +716,8 @@ remap_segment(struct hugepage_file *hugepages, int se= g_start, int seg_end) > break; > } > if (msl_idx =3D=3D RTE_MAX_MEMSEG_LISTS) { > - RTE_LOG(ERR, EAL, "Could not find space for memseg. Pleas= e increase %s and/or %s in configuration.\n", > - RTE_STR(RTE_MAX_MEMSEG_PER_TYPE), > - RTE_STR(RTE_MAX_MEM_MB_PER_TYPE)); > + RTE_LOG(ERR, EAL, "Could not find space for memseg. Pleas= e increase RTE_MAX_MEMSEG_PER_LIST " > + "RTE_MAX_MEMSEG_PER_TYPE and/or RTE_MAX_M= EM_MB_PER_TYPE in configuration.\n"); This same log is in FreeBSD, so I guess we want to update it too. --=20 David Marchand