From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 77D87430EE; Thu, 24 Aug 2023 10:52:21 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 107DA410EE; Thu, 24 Aug 2023 10:52:21 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id E6A6E40EE1 for ; Thu, 24 Aug 2023 10:52:19 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1692867139; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gEcCz5U67p+LBivxT7iDwPZJJAmEGj9RuI8E1zX9OA8=; b=EGAFU3CYQwSEeDXv/Tvz6AvbRpi9sOCTE7Uk6qlQ0KIGpby4wlTG03DCz8DRuev6LSePUQ +09G20WNxfF3fMRBTV14x8XE0fysLsO8OINlK1+RhXf8GXDZ0nEcvZUuMACxpofl59P5XT fp4D/4qkNO6QwslwXnmJ05Lg6AyB9XY= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-131-fIQUYNlFPkup_Lbh0ZQbuA-1; Thu, 24 Aug 2023 04:52:17 -0400 X-MC-Unique: fIQUYNlFPkup_Lbh0ZQbuA-1 Received: by mail-lf1-f69.google.com with SMTP id 2adb3069b0e04-4ff8d9fdf11so6627986e87.0 for ; Thu, 24 Aug 2023 01:52:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692867136; x=1693471936; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gEcCz5U67p+LBivxT7iDwPZJJAmEGj9RuI8E1zX9OA8=; b=KvQPnwU0Kxe9weDYMrAeu5OlI+lsoiAxn88owO2YObCTY/nce/bf4B/3Qhd+Tu6Gmo mTST2Anl6iA4yAIHstbA34eCPVZIlDqLQG1LcPbLVnHkk81RKg2nzpTAkz9X2K6rtn/0 xYSqpj4mxz3CVvM7Y5yvQZg1icZnGUxnTcy2Lv6sv1VXWQwMleOFZna2/Uf7pAYZMTZo K8/W8UeKx08Nhzij9ESqcgsgWe+EKDI+2YPVDdKL1GGuT3eNZT2lHXVUk6KyMpy6+ore 1+F5Cb6nxtKMGmM0mdWLSZGH7FTgc+Ab040cxx2p0iBgulw8WilQeJeinAIGReaW3xn8 HESQ== X-Gm-Message-State: AOJu0YyyvQfVjRw0zDdAkI5mu/TZRfnd9qKxSfZZqx5M+XTrFH+eqHqD XUoaZnO3xEpbRMQfhuRaaFAHxBRTGCAfY6lvlZG2sZ/kK+RV3hd54M2oi/6wIEnf7c+Ls+QUeul 6R/gqPywQpImzyUACxms= X-Received: by 2002:a19:520b:0:b0:4ff:9a75:211e with SMTP id m11-20020a19520b000000b004ff9a75211emr9676295lfb.42.1692867136347; Thu, 24 Aug 2023 01:52:16 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGNMO8CdJ1Fc7vIKD4dlE8IDowGi+pKJCH4YSfuVXoTLpsylcCY+zoBH0A0wt0MHaLJ+PQkK7ApcRdeLVQLA3I= X-Received: by 2002:a19:520b:0:b0:4ff:9a75:211e with SMTP id m11-20020a19520b000000b004ff9a75211emr9676286lfb.42.1692867136044; Thu, 24 Aug 2023 01:52:16 -0700 (PDT) MIME-Version: 1.0 References: <20230824083034.806773-1-david.marchand@redhat.com> In-Reply-To: <20230824083034.806773-1-david.marchand@redhat.com> From: David Marchand Date: Thu, 24 Aug 2023 10:52:04 +0200 Message-ID: Subject: Re: [PATCH] remove wrappers for GCC < 4.8 To: roretzla@linux.microsoft.com Cc: dev@dpdk.org, Ruifeng Wang , David Christensen , Bruce Richardson , Konstantin Ananyev X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hello Tyler, On Thu, Aug 24, 2023 at 10:30=E2=80=AFAM David Marchand wrote: > diff --git a/lib/eal/include/rte_debug.h b/lib/eal/include/rte_debug.h > index 2c4b94a7c9..74593cd4d4 100644 > --- a/lib/eal/include/rte_debug.h > +++ b/lib/eal/include/rte_debug.h > @@ -60,11 +60,7 @@ void rte_dump_stack(void); > * documentation. > */ > void __rte_panic(const char *funcname , const char *format, ...) > -#ifdef __GNUC__ > -#if (__GNUC__ > 4 || (__GNUC__ =3D=3D 4 && __GNUC_MINOR__ > 2)) > __rte_cold > -#endif > -#endif I don't see some wrapping around __rte_cold for MSVC in your series. Would this patch break MSVC buidlds? > __rte_noreturn > __rte_format_printf(2, 3); > --=20 David Marchand