From: David Marchand <david.marchand@redhat.com>
To: Tyler Retzlaff <roretzla@linux.microsoft.com>
Cc: dev@dpdk.org, Anatoly Burakov <anatoly.burakov@intel.com>,
Bruce Richardson <bruce.richardson@intel.com>,
Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,
Sivaprasad Tummala <sivaprasad.tummala@amd.com>
Subject: Re: [PATCH] eal: fix compile failure of asm on MSVC toolchain
Date: Thu, 26 Oct 2023 10:43:11 +0200 [thread overview]
Message-ID: <CAJFAV8xY2iD_0zEEBev4b88CZcz7uA8+Z=0m4OOG6krxmwLnMQ@mail.gmail.com> (raw)
In-Reply-To: <1697551570-20942-1-git-send-email-roretzla@linux.microsoft.com>
On Tue, Oct 17, 2023 at 4:06 PM Tyler Retzlaff
<roretzla@linux.microsoft.com> wrote:
>
> Most MSVC targets do not support inline asm and __MWAITX__ is a GCC
> implementation detail. Use a test of defined(RTE_TOOLCHAIN_MSVC) to
> avoid conditional compilation of inline asm and instead use intrinsics
> instead.
>
> Fixes: c7ed1ce04704 ("eal/x86: add power intrinsics for AMD")
>
> Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
Acked-by: David Marchand <david.marchand@redhat.com>
Applied, thanks.
--
David Marchand
prev parent reply other threads:[~2023-10-26 8:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-17 14:06 Tyler Retzlaff
2023-10-26 8:43 ` David Marchand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8xY2iD_0zEEBev4b88CZcz7uA8+Z=0m4OOG6krxmwLnMQ@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=anatoly.burakov@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=konstantin.v.ananyev@yandex.ru \
--cc=roretzla@linux.microsoft.com \
--cc=sivaprasad.tummala@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).