From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 77155A0A0A; Thu, 3 Jun 2021 09:54:01 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E9D4140689; Thu, 3 Jun 2021 09:54:00 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id EE13B4067A for ; Thu, 3 Jun 2021 09:53:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1622706838; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZJ11MYeViwsl7Jql8jxN+j5DfLFQMliQcbDOIz92pmY=; b=ayeoqoGZkcODZEoE/guWE2pHTS5zFWO06mY1L3my5kM4scJo+8jgrbPt3V5nsNadt7yyPv 8I9YTu74se753RvchBR574rANbSNz8kfvERZcSlHUKw3VN2j7qlfaD9xjYsBl1nRtNucnO IpGabz84L0o84caRdehevAEwOl/jlB0= Received: from mail-vs1-f72.google.com (mail-vs1-f72.google.com [209.85.217.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-166-pXfF13eINImvEJVu3uiOGA-1; Thu, 03 Jun 2021 03:53:56 -0400 X-MC-Unique: pXfF13eINImvEJVu3uiOGA-1 Received: by mail-vs1-f72.google.com with SMTP id b11-20020a67f98b0000b0290259f9cc600bso679996vsq.5 for ; Thu, 03 Jun 2021 00:53:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ZJ11MYeViwsl7Jql8jxN+j5DfLFQMliQcbDOIz92pmY=; b=mcNtKdd+wocvxjxaf6NEY6AOXnLE6WUQhDXPoJhZ6EKQ04tMaCYdp1huP6s2RbSPvI ETKOq10F3/d+029DyhNtxXDuMuC/ZPRlNsJzjQykijmpm5qLxLpo2JL1fyvtN3XFqkjF S1/v6WZgk2K+HA2ZMsgjiLwK++A6fTn+Emfw8x//F/+xcJQOWcY/dae7jr8FztYwaf3j 0L69fylR7oKMxjoI6tK+laxVdiksLKDzhiEYoOcfvdAwJx2RDyUhAuFppzyWWz2XQVFB e9frE86uwqO9qtgloJ3LEFHZwUii/iGDh1kz6Tk9DUtZyz58GioSdGnl3m2/jOcqc4R9 f63Q== X-Gm-Message-State: AOAM532oBvJsGPXD/BsuxiM3h+kl4qDPAsaOl/pZX9XslPgqlyVQHJQH PCsuR2cXT7AnGkSY5Oj84nHNbhKAgUSgJIRcTnhZA3IEY3JeBUNASuDM9SWXso1+DcHfqQEQSyo 6kbG7iUsvRd1/PxkJABI= X-Received: by 2002:ab0:6cf2:: with SMTP id l18mr16621984uai.86.1622706836546; Thu, 03 Jun 2021 00:53:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyLas0OgzrQCkX2ra0EM9feAJxYZqfaIKny2MkDpKJPMcteFQUQHinDArH52tBV4f3pJcrKilBsOAbwbPru+BY= X-Received: by 2002:ab0:6cf2:: with SMTP id l18mr16621971uai.86.1622706836344; Thu, 03 Jun 2021 00:53:56 -0700 (PDT) MIME-Version: 1.0 References: <20210602095836.24901-1-david.marchand@redhat.com> <20210602095836.24901-3-david.marchand@redhat.com> <20210603001919.7ea9c273@sovereign> In-Reply-To: From: David Marchand Date: Thu, 3 Jun 2021 09:53:44 +0200 Message-ID: To: Dmitry Kozlyuk Cc: dev , Aaron Conole , Michael Santana , Bruce Richardson , Rasesh Mody , Shahed Shaikh , Qiming Yang , Qi Zhang , Heinrich Kuhn , Devendra Singh Rawat , Igor Russkikh , Ray Kinsella , Neil Horman , Narcisa Ana Maria Vasile , Dmitry Malloy , Pallavi Kadam Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 2/2] eal: handle compressed firmwares X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Jun 3, 2021 at 9:23 AM David Marchand wrote: > > > diff --git a/config/meson.build b/config/meson.build > > > index 017bb2efbb..337daa2719 100644 > > > --- a/config/meson.build > > > +++ b/config/meson.build > > > @@ -166,6 +166,15 @@ if fdt_dep.found() and cc.has_header('fdt.h') > > > dpdk_extra_ldflags += '-lfdt' > > > endif > > > > > > +has_libarchive = 0 > > > +archive_dep = cc.find_library('libarchive', required: false) > > > +if archive_dep.found() and cc.has_header('archive.h') > > > + dpdk_conf.set10('RTE_HAS_LIBARCHIVE', true) > > > + has_libarchive = 1 > > > + add_project_link_arguments('-larchive', language: 'c') > > > + dpdk_extra_ldflags += '-larchive' > > > +endif > > > + > > > > Why not use pkg-config? > > `has_libarchive` is unused. > > Frankly, I just copied the logic already present in config/meson.build. > If there is better to do, please advise. Ah ok, I think I understand. Do you mean to align on libbsd? -- David Marchand