* [dpdk-dev] [PATCH] power: fix unused-but-set variable error
@ 2021-10-29 17:15 Jim Harris
2021-10-29 18:53 ` David Marchand
0 siblings, 1 reply; 3+ messages in thread
From: Jim Harris @ 2021-10-29 17:15 UTC (permalink / raw)
To: dev, david.hunt; +Cc: Jim Harris
clang-13 rightfully complains that the tot_ppi
variable in update_stats is set but not used, since
the final accumulated tot_ppi results isn't used
anywhere. So just remove the tot_ppi variable.
Signed-off-by: Jim Harris <james.r.harris@intel.com>
---
lib/power/rte_power_empty_poll.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/lib/power/rte_power_empty_poll.c b/lib/power/rte_power_empty_poll.c
index 975aa92997..8a2d60c576 100644
--- a/lib/power/rte_power_empty_poll.c
+++ b/lib/power/rte_power_empty_poll.c
@@ -207,7 +207,7 @@ update_training_stats(struct priority_worker *poll_stats,
static __rte_always_inline uint32_t
update_stats(struct priority_worker *poll_stats)
{
- uint64_t tot_edpi = 0, tot_ppi = 0;
+ uint64_t tot_edpi = 0;
uint32_t j, percent;
struct priority_worker *s = poll_stats;
@@ -237,7 +237,6 @@ update_stats(struct priority_worker *poll_stats)
for (j = 0; j < BINS_AV; j++) {
tot_edpi += s->edpi_av[j];
- tot_ppi += s->ppi_av[j];
}
tot_edpi = tot_edpi / BINS_AV;
--
2.32.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] power: fix unused-but-set variable error
2021-10-29 17:15 [dpdk-dev] [PATCH] power: fix unused-but-set variable error Jim Harris
@ 2021-10-29 18:53 ` David Marchand
2021-11-04 17:32 ` Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: David Marchand @ 2021-10-29 18:53 UTC (permalink / raw)
To: Jim Harris; +Cc: dev, David Hunt
On Fri, Oct 29, 2021 at 7:17 PM Jim Harris <james.r.harris@intel.com> wrote:
>
> clang-13 rightfully complains that the tot_ppi
> variable in update_stats is set but not used, since
> the final accumulated tot_ppi results isn't used
> anywhere. So just remove the tot_ppi variable.
Dead code, from the start...
Fixes: 450f0791312c ("power: add traffic pattern aware power control")
>
> Signed-off-by: Jim Harris <james.r.harris@intel.com>
> ---
> lib/power/rte_power_empty_poll.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/lib/power/rte_power_empty_poll.c b/lib/power/rte_power_empty_poll.c
> index 975aa92997..8a2d60c576 100644
> --- a/lib/power/rte_power_empty_poll.c
> +++ b/lib/power/rte_power_empty_poll.c
> @@ -207,7 +207,7 @@ update_training_stats(struct priority_worker *poll_stats,
> static __rte_always_inline uint32_t
> update_stats(struct priority_worker *poll_stats)
> {
> - uint64_t tot_edpi = 0, tot_ppi = 0;
> + uint64_t tot_edpi = 0;
> uint32_t j, percent;
>
> struct priority_worker *s = poll_stats;
> @@ -237,7 +237,6 @@ update_stats(struct priority_worker *poll_stats)
>
> for (j = 0; j < BINS_AV; j++) {
> tot_edpi += s->edpi_av[j];
> - tot_ppi += s->ppi_av[j];
> }
>
> tot_edpi = tot_edpi / BINS_AV;
> --
> 2.32.0
>
I don't think keeping ppi_av[] (and related data struct) is that
useful.. but in any case patch lgtm:
Reviewed-by: David Marchand <david.marchand@redhat.com>
--
David Marchand
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] power: fix unused-but-set variable error
2021-10-29 18:53 ` David Marchand
@ 2021-11-04 17:32 ` Thomas Monjalon
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2021-11-04 17:32 UTC (permalink / raw)
To: Jim Harris; +Cc: dev, David Hunt, David Marchand
29/10/2021 20:53, David Marchand:
> On Fri, Oct 29, 2021 at 7:17 PM Jim Harris <james.r.harris@intel.com> wrote:
> >
> > clang-13 rightfully complains that the tot_ppi
> > variable in update_stats is set but not used, since
> > the final accumulated tot_ppi results isn't used
> > anywhere. So just remove the tot_ppi variable.
>
> Dead code, from the start...
> Fixes: 450f0791312c ("power: add traffic pattern aware power control")
>
> > @@ -237,7 +237,6 @@ update_stats(struct priority_worker *poll_stats)
> >
> > for (j = 0; j < BINS_AV; j++) {
> > tot_edpi += s->edpi_av[j];
> > - tot_ppi += s->ppi_av[j];
> > }
>
> I don't think keeping ppi_av[] (and related data struct) is that
> useful.. but in any case patch lgtm:
>
> Reviewed-by: David Marchand <david.marchand@redhat.com>
I understand that a v2 removing ppi_av would be better.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-11-04 17:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-29 17:15 [dpdk-dev] [PATCH] power: fix unused-but-set variable error Jim Harris
2021-10-29 18:53 ` David Marchand
2021-11-04 17:32 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).