From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9A7DD41E8E; Tue, 14 Mar 2023 09:39:27 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E405141611; Tue, 14 Mar 2023 09:39:26 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 6A50D410DE for ; Tue, 14 Mar 2023 09:39:25 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1678783164; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=csniA+unIlwX9+gB42miELRqOXXVoqllGIEqsc8oDB4=; b=XE56Vx3hBi8093S7gATppWv6JE1rK51YWT6+WYZ/Lh/M6pjjulR5a40gtrVS+ZMgSJ2XOb zkQpuX0wfooiAOZ1zJmw1zUEm4PUGUe8mh9BNF9hzBMvbeCCESa45nNnKjvjnv2ICDNIQE fte0ywL62JB1F3EwZrdP4Dfz32YusYI= Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-606-QVRj1Q9yM8--ovlIN3Tvbw-1; Tue, 14 Mar 2023 04:39:23 -0400 X-MC-Unique: QVRj1Q9yM8--ovlIN3Tvbw-1 Received: by mail-pj1-f71.google.com with SMTP id d5-20020a17090a7bc500b0023d3366e005so930364pjl.6 for ; Tue, 14 Mar 2023 01:39:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678783163; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=csniA+unIlwX9+gB42miELRqOXXVoqllGIEqsc8oDB4=; b=OWPce51eEvysJ/wNBFdTlHifDWEi0JCCeAGh8a+SsRLnplAbRSDzZEuuyVlF1cPNhZ 2BVqiByrk0qJ13q5KbpTz5fH8JSAWH8J6dSy7Os09V0MnhJ6RfwHJEhih9yuvli63cSZ Uutzesa8dI4NOYn1DYRPGRo0YUe6djTbLNsL0+KLLX9f4f1+ptjF2lnxGT3V6znqncHo X9DRrxHYEgkZLN7q/HmKJb0uVBuVdbTVYIXUmApGCbsv+pXzjioCQ7lwWWvZp95By9T7 QL/K+pBOYTUB9zQCRuSCpO6JTlLh35VtYgnwl8jRnWTiZHMqL9btNSkmEyuVABWsB5Tm 26cA== X-Gm-Message-State: AO0yUKWs/Onhg2YaYc15hjG0peGeQ20InoFRbiWR9yU4Qji6sCzrXtaX GNCpPq2hDGqbwBDvmrO98hrximuoxS/xcYv0mp4xUAP/tt7FIGKYIbCgmnEwUXeRI/ZNYGOKUwT tStt97Fe69gPWXbieRDeBaWTV0n8= X-Received: by 2002:a65:6156:0:b0:50b:189d:bfd with SMTP id o22-20020a656156000000b0050b189d0bfdmr1915190pgv.11.1678783162819; Tue, 14 Mar 2023 01:39:22 -0700 (PDT) X-Google-Smtp-Source: AK7set+A3NEK4oTjg46mlUcV8r7vD12tQSwhk+UiLBJiCezSiZNf8Y4AoZ6OXIdaEhtbdejAvNMhfb75K/8kaIVZ2LE= X-Received: by 2002:a65:6156:0:b0:50b:189d:bfd with SMTP id o22-20020a656156000000b0050b189d0bfdmr1915184pgv.11.1678783162544; Tue, 14 Mar 2023 01:39:22 -0700 (PDT) MIME-Version: 1.0 References: <20230310142604.2409586-1-david.marchand@redhat.com> In-Reply-To: <20230310142604.2409586-1-david.marchand@redhat.com> From: David Marchand Date: Tue, 14 Mar 2023 09:39:11 +0100 Message-ID: Subject: Re: [PATCH 1/2] raw/skeleton: fix selftest To: dev@dpdk.org, Thomas Monjalon Cc: stable@dpdk.org, Sachin Saxena , Hemant Agrawal , Shreyansh Jain X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Mar 10, 2023 at 3:26=E2=80=AFPM David Marchand wrote: > > ASan reported issues in this driver. > > rte_rawdev_obj_t context object points at a uint16_t. > skeleton_rawdev_enqueue_bufs() and skeleton_rawdev_dequeue_bufs() were > incorrectly casting to an int. > > The enqueue/dequeue selftest had a leak on the enqueued string and was > wrong in passing a rte_rawdev_buf pointer array. > Fix this by allocating buffers on the stack and check that returned > string is the expected one. > > Bugzilla ID: 1175 Thomas, just a note if you are the one to apply this one. I was looking at bugzilla, and this issue was actually reported a while back, as bz 999, so the commitlog needs some update before applying. > Fixes: 61c592a8d035 ("raw/skeleton: introduce skeleton rawdev driver") > Fixes: 55ca1b0f2151 ("raw/skeleton: add test cases") > Cc: stable@dpdk.org > > Signed-off-by: David Marchand --=20 David Marchand