From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id AD4B7A0093; Tue, 19 May 2020 11:15:19 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4A05E1D17E; Tue, 19 May 2020 11:15:19 +0200 (CEST) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) by dpdk.org (Postfix) with ESMTP id 2CE8F1D17A for ; Tue, 19 May 2020 11:15:17 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1589879716; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fhzHsym1OPZH3ohMIJrzgC/vt8b5MWEIGb2dMb/JRQ0=; b=a0EudGsj189ZNufV+oze5lXZKRKhZ2EE9a2pDOgvssI9THOCZXwHpKDtE3/bfiAurIcESy xVl+tjjxBcR4UTPGcqJ8C9Xpf/cWO2v1P1T81UMhhsZEGS4+yW5TuQsfuGv5fATM4QPUME 2VzS0aQ20HZqe6EJtrMgCKCYyinipXs= Received: from mail-ua1-f71.google.com (mail-ua1-f71.google.com [209.85.222.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-361-XzK67zccNFawfFQNetm2OQ-1; Tue, 19 May 2020 05:15:15 -0400 X-MC-Unique: XzK67zccNFawfFQNetm2OQ-1 Received: by mail-ua1-f71.google.com with SMTP id w1so4734775uaq.0 for ; Tue, 19 May 2020 02:15:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fhzHsym1OPZH3ohMIJrzgC/vt8b5MWEIGb2dMb/JRQ0=; b=naXvCdFTEp7cwuXKw8B2aHjevPu2r8V+P3QklMiBi93VAZqvBGXvK4zBGrAmpdhYGM 9eBhQncEp8wzscvPOLxVmR4KpV17FlA9piZZ3yyQEdYbuQovZhbnwhECjOPFjdOzj8tC sgVQ66LnvHzHhubotfpcnNNaqBqi69TnLf2D7OCDPiCO+HGhg4gH4XmoHPMgCRi0to7x iHgEw6yzbVEZ5XuV8FVbI5hAXgVWzzeGFADvFiv6AX0ldOrGbORi2wg8B738M63RHpBl 6d+qqTNs6SMPnRwHIXiliQSQ6rlafkbWhX3aHhfL5XvLnNHshRmoYFlFP67fOeivch7P /q6w== X-Gm-Message-State: AOAM531i+EkSwxjgSMnMH/Re50a2RhusmADH51JhvsDo7TTpSMBoyW9S 5fyVjXy7UasQb5Mx8y89foR0llM7jw/E6MqTJwQBb2f/JZa8LrczK10SB7SYuy4OLWaLFx+ei4B EzjbnhUguqN266FKCLnk= X-Received: by 2002:ab0:36d9:: with SMTP id v25mr13700991uau.126.1589879714634; Tue, 19 May 2020 02:15:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwHEY9AbWO9v73A1j3zg4vGFgw9SUNtiHaPf76G/E97bN2Yfg+r9BiUTckRFFWDmzpi45+dTCY1TBr/wlOgObg= X-Received: by 2002:ab0:36d9:: with SMTP id v25mr13700975uau.126.1589879714327; Tue, 19 May 2020 02:15:14 -0700 (PDT) MIME-Version: 1.0 References: <20200512133057.106374-1-dariusz.stojaczyk@intel.com> In-Reply-To: <20200512133057.106374-1-dariusz.stojaczyk@intel.com> From: David Marchand Date: Tue, 19 May 2020 11:15:03 +0200 Message-ID: To: Darek Stojaczyk Cc: dev , "Burakov, Anatoly" , Stephen Hemminger , Gaetan Rivet X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] pci: properly parse 32-bit domain numbers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, May 12, 2020 at 3:31 PM Darek Stojaczyk wrote: > > The parsing code was bailing on domains greater than UINT16_MAX, > but domain numbers like that are still valid and present on some systems. > One example is Intel VMD (Volume Management Device), which acts somewhat > as a software-managed PCI switch and its upstream linux driver assigns > all downstream devices a PCI domain of 0x10000. > > Parsing a BDF like 10000:01:00.0 was failing before. To fix it, increase > the upper limit of domain number to UINT32_MAX. This matches the size of > struct rte_pci_addr->domain (uint32). Fixes: af75078fece3 ("first public release") Cc: stable@dpdk.org > Signed-off-by: Darek Stojaczyk Acked-by: Gaetan Rivet Applied, thanks. -- David Marchand