DPDK patches and discussions
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org, thomas@monjalon.net, techboard@dpdk.org,
	 Vipin Varghese <vipin.varghese@amd.com>,
	Anatoly Burakov <anatoly.burakov@intel.com>,
	 Konstantin Ananyev <konstantin.ananyev@huawei.com>
Subject: Re: [PATCH v2] eal: deprecate old coremask-based EAL parameters
Date: Thu, 3 Jul 2025 10:42:25 +0200	[thread overview]
Message-ID: <CAJFAV8x_X2FKYBuRhpPCbhghh=9V2sXk7QwcLmnRcM=GMMmVzg@mail.gmail.com> (raw)
In-Reply-To: <CAJFAV8yixOQ-GFn9FZoheQzfwXh5c=zCms6wvRdZwHqZctTJ=w@mail.gmail.com>

On Tue, Jul 1, 2025 at 9:56 AM David Marchand <david.marchand@redhat.com> wrote:
>
> On Mon, Jun 30, 2025 at 5:38 PM Bruce Richardson
> <bruce.richardson@intel.com> wrote:
> >
> > As the number of cores/cpus on platforms has increased over the years,
> > the use of coremasks rather than core-lists for identifying DPDK cores
> > has become more and more unwieldy. At this point, let's deprecate the
> > coremask-based EAL parameters for future removal, and point users to the
> > core-list based versions instead.
> >
> > Depends-on: series-35540 ("use core lists not masks in documentation")
> >
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> > Acked-by: Vipin Varghese <vipin.varghese@amd.com>
> > Acked-By: Anatoly Burakov <anatoly.burakov@intel.com>
> > Acked-by: Konstantin Ananyev <konstantin.ananyev@huawei.com>
>
> Acked-by: David Marchand <david.marchand@redhat.com>

I realised the test-null.sh script needs tweaking.
I'll squash this:

diff --git a/devtools/test-null.sh b/devtools/test-null.sh
index 6cd34f64f1..e3ac168ce3 100755
--- a/devtools/test-null.sh
+++ b/devtools/test-null.sh
@@ -7,7 +7,7 @@

 build=${1:-build} # first argument can be the build directory
 testpmd=$1 # or first argument can be the testpmd path
-coremask=${2:-3} # default using cores 0 and 1
+corelist=${2:-0-1} # default using cores 0 and 1
 eal_options=$3
 testpmd_options=$4

@@ -28,6 +28,6 @@ fi

 (sleep 1 && echo stop) |
 # testpmd only needs 20M, make it x2 (default number of cores) for NUMA systems
-$testpmd -c $coremask --no-huge -m 40 \
+$testpmd -l $corelist --no-huge -m 40 \
        $libs -a 0:0.0 --vdev net_null1 --vdev net_null2 $eal_options -- \
        --no-mlockall --total-num-mbufs=2048 $testpmd_options -ia


-- 
David Marchand


  reply	other threads:[~2025-07-03  8:42 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-24 13:41 [PATCH] " Bruce Richardson
2025-06-27 14:52 ` Burakov, Anatoly
2025-06-30 11:15 ` Konstantin Ananyev
2025-06-30 14:33 ` David Marchand
2025-06-30 15:37 ` [PATCH v2] " Bruce Richardson
2025-07-01  7:56   ` David Marchand
2025-07-03  8:42     ` David Marchand [this message]
2025-07-03  9:06   ` David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJFAV8x_X2FKYBuRhpPCbhghh=9V2sXk7QwcLmnRcM=GMMmVzg@mail.gmail.com' \
    --to=david.marchand@redhat.com \
    --cc=anatoly.burakov@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=konstantin.ananyev@huawei.com \
    --cc=techboard@dpdk.org \
    --cc=thomas@monjalon.net \
    --cc=vipin.varghese@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).