From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EC2DD41C52; Thu, 9 Feb 2023 15:23:23 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8DB5A410EA; Thu, 9 Feb 2023 15:23:23 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 6509240EDC for ; Thu, 9 Feb 2023 15:23:21 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675952600; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=g5BAFa0EY4bXinRLCBT5ZUFD4XXqR4AVhW9jOwpGl5g=; b=P43N59eWcI/EDiw36vVU0KQH7vljuuZ28OuqPiQlfrfhzJcBYKbVriRSu7D73Aw7BHtBdN UGpi3ar6jNSdX9MSJQBm/fABZYyHauD/SVZ6LdaQ4JEnUPxgIc5hzsJG8QeLRVN1ybOyYG bPC3vYlb4cnfS6rZUTxSIZqD7U+qCA4= Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-459-McPncTIeM0ebxjqQdax9RA-1; Thu, 09 Feb 2023 09:23:19 -0500 X-MC-Unique: McPncTIeM0ebxjqQdax9RA-1 Received: by mail-pj1-f72.google.com with SMTP id s20-20020a17090b071400b00230ecf76407so1101880pjz.3 for ; Thu, 09 Feb 2023 06:23:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=g5BAFa0EY4bXinRLCBT5ZUFD4XXqR4AVhW9jOwpGl5g=; b=GMh4KZCrRtWywREHZe+Tp0L5uVq0VZpjgsS6OxhTjSIzSqCPuyqdkOO2sU4XvFj1J1 IHv6wSxsYZJO0Va7jArvYH4vi7ev8QYWUXrDxt1YO6/hCvBqDTO0PAv9hVar6A3gNEFQ Wybqe0+Zij7DMJKRZuh+i/Jx7UtRzYVR+P6oANRmg0lS6csHlD9jespXHJ62v+ipBICh UKnEKpY4OW1u8JHvmuGNMzTTY6x4BWcbuRDYwlov16h5umupYMzbJT7SuII2wootOuVo ZuVdRPe8l7uHHDSnuHOmcMx/E9eVw8ZWRubpwsAxdY5c8dmaDS3tn6ogwvHsY4W33jdq BbQw== X-Gm-Message-State: AO0yUKXjxx0I/tNPdM6Ufq9JTWjJ+8Ha3xfDUlTkvpRCm5Thqm/mLNot CGRY563W1iiHvBWZn9F6ccxihoVGLuJsGyuHYbuxKiZmb1FVnm32h72HjzX/GMsgQrEQvwhzGXZ 4hwziU8+YhHbOAuzsI0s= X-Received: by 2002:a17:902:968c:b0:19a:5a4b:2d27 with SMTP id n12-20020a170902968c00b0019a5a4b2d27mr566800plp.32.1675952598614; Thu, 09 Feb 2023 06:23:18 -0800 (PST) X-Google-Smtp-Source: AK7set/ql/+4amAQLj4tyv4ixEg9Vuau80khzUiuRbpFE42m8uSf9XFumcnGwsgwv4bwG07X5dmXLiMKxKKua4kG2kA= X-Received: by 2002:a17:902:968c:b0:19a:5a4b:2d27 with SMTP id n12-20020a170902968c00b0019a5a4b2d27mr566795plp.32.1675952598186; Thu, 09 Feb 2023 06:23:18 -0800 (PST) MIME-Version: 1.0 References: <20230209133019.933380-1-adwivedi@marvell.com> <20230209133019.933380-2-adwivedi@marvell.com> In-Reply-To: <20230209133019.933380-2-adwivedi@marvell.com> From: David Marchand Date: Thu, 9 Feb 2023 15:23:07 +0100 Message-ID: Subject: Re: [PATCH v1 1/5] mempool: remove internal tracepoints from version map To: Ankur Dwivedi Cc: dev@dpdk.org, thomas@monjalon.net, ferruh.yigit@amd.com, jerinj@marvell.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Feb 9, 2023 at 2:30 PM Ankur Dwivedi wrote: > > The file rte_mempool_trace.h contains tracepoints which are internal to the > mempool library. This file is renamed to mempool_trace.h, and is made an > internal header. The tracepoints in this file are removed from the This patch also exports this new internal header which looks wrong to me. See below. > experimental section in version.map file. > > Signed-off-by: Ankur Dwivedi > diff --git a/lib/mempool/meson.build b/lib/mempool/meson.build > index b8aaa00694..29ae6d21e5 100644 > --- a/lib/mempool/meson.build > +++ b/lib/mempool/meson.build > @@ -17,7 +17,9 @@ sources = files( > ) > headers = files( > 'rte_mempool.h', > - 'rte_mempool_trace.h', > 'rte_mempool_trace_fp.h', > ) > +driver_sdk_headers += files( > + 'mempool_trace.h', > +) driver_sdk_headers is for exporting driver headers. I am not sure why you added this, can you elaborate? Checking with who includes this header in the whole tree: $ git grep include..mempool_trace lib/mempool/mempool_trace_points.c:#include "mempool_trace.h" lib/mempool/rte_mempool.c:#include "mempool_trace.h" lib/mempool/rte_mempool_ops.c:#include "mempool_trace.h" I see no external (from the mempool library pov) user of this header => no export needed. I did not check the rest of the series, but the same argument is likely to apply. Thanks. -- David Marchand