From: David Marchand <david.marchand@redhat.com>
To: Chengwen Feng <fengchengwen@huawei.com>
Cc: Thomas Monjalon <thomas@monjalon.net>, dev <dev@dpdk.org>,
"Burakov, Anatoly" <anatoly.burakov@intel.com>,
Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [PATCH v2 1/3] eal: fix segment fault when exit trace
Date: Tue, 14 Jun 2022 10:25:49 +0200 [thread overview]
Message-ID: <CAJFAV8xa1ubOy+u+z2-yhX0v9iWYfPMB6TgA9s4t6cOVsntDJg@mail.gmail.com> (raw)
In-Reply-To: <20220614055900.22848-2-fengchengwen@huawei.com>
On Tue, Jun 14, 2022 at 8:06 AM Chengwen Feng <fengchengwen@huawei.com> wrote:
>
> Bug scenario:
> 1. start testpmd:
> dpdk-testpmd -l 4-6 -a 0000:7d:00.0 --trace=.* -- -i
> 2. quit testpmd and then observed segment fault:
> Bye...
> Segmentation fault (core dumped)
>
> The root cause is that rte_trace_save() and eal_trace_fini() access
> the huge pages which were cleanup by rte_eal_memory_detach().
>
> This patch moves rte_trace_save() and eal_trace_fini() before
> rte_eal_memory_detach() to fix the bug.
>
> Fixes: dfbc61a2f9a6 ("mem: detach memsegs on cleanup")
> Cc: stable@dpdk.org
>
> Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
> Tested-by: Jerin Jacob <jerinj@marvell.com>
Reviewed-by: David Marchand <david.marchand@redhat.com>
--
David Marchand
next prev parent reply other threads:[~2022-06-14 8:26 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-07 12:00 [PATCH] " Chengwen Feng
2022-06-07 12:26 ` fengchengwen
2022-06-13 14:15 ` David Marchand
2022-06-14 0:33 ` fengchengwen
2022-06-07 13:00 ` David Marchand
2022-06-08 10:31 ` Jerin Jacob
2022-06-14 5:58 ` [PATCH v2 0/3] bugfix for trace Chengwen Feng
2022-06-14 5:58 ` [PATCH v2 1/3] eal: fix segment fault when exit trace Chengwen Feng
2022-06-14 8:25 ` David Marchand [this message]
2022-06-14 5:58 ` [PATCH v2 2/3] eal: fix trace init fail with long file-prefix Chengwen Feng
2022-06-15 14:02 ` David Marchand
2022-06-15 18:11 ` Jerin Jacob
2022-06-14 5:59 ` [PATCH v2 3/3] test: support trace-autotest when enable trace Chengwen Feng
2022-06-15 14:00 ` David Marchand
2022-06-17 2:42 ` fengchengwen
2022-06-21 9:06 ` David Marchand
2022-06-17 2:29 ` [PATCH v3 0/4] bugfix for trace Chengwen Feng
2022-06-17 2:29 ` [PATCH v3 1/4] eal: fix segment fault when exit trace Chengwen Feng
2022-06-17 2:29 ` [PATCH v3 2/4] eal: fix errno not set if strftime return zero Chengwen Feng
2022-06-21 9:05 ` David Marchand
2022-06-17 2:29 ` [PATCH v3 3/4] eal: fix trace init fail with long file-prefix Chengwen Feng
2022-06-17 2:29 ` [PATCH v3 4/4] test: introduce trace-autotest with traces enabled Chengwen Feng
2022-06-21 9:07 ` David Marchand
2022-06-21 9:07 ` [PATCH v3 0/4] bugfix for trace David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8xa1ubOy+u+z2-yhX0v9iWYfPMB6TgA9s4t6cOVsntDJg@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=anatoly.burakov@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=fengchengwen@huawei.com \
--cc=jerinj@marvell.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).