From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7FEB2A00BE; Tue, 14 Jun 2022 10:26:06 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5D64C4068E; Tue, 14 Jun 2022 10:26:06 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 72CB44067C for ; Tue, 14 Jun 2022 10:26:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1655195163; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rXRHv2J5GFvASYfHKz0Z/0H2n0jbDB8/IVXEYmECdBQ=; b=WkIAS39ORidpcckYL5GJbAejE4112GeyaQxhPuyZtTyhNx6hjwC62bx194s0ISqcl/QGl1 Dt5OFhWcbCNLKsZt+L4g5QTurejsBI9CTAZmDS1ga8LhemSl41zv0HSSOwhPs8g4z+Wb5b jxk5kUUrJIRHF48wUpTAVfZM9hp946k= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-557-zKfzt_MIMBee9iGOBWa37w-1; Tue, 14 Jun 2022 04:26:02 -0400 X-MC-Unique: zKfzt_MIMBee9iGOBWa37w-1 Received: by mail-lf1-f71.google.com with SMTP id c25-20020ac25f79000000b00478f05f8f49so4175827lfc.20 for ; Tue, 14 Jun 2022 01:26:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=rXRHv2J5GFvASYfHKz0Z/0H2n0jbDB8/IVXEYmECdBQ=; b=FjFcyG3vj9Iq/nIkokyaz6lk8V5Avf5PccA0ZBMdR+GpyD1Eh18Uoo2SHEF+z6ob6w gIR9PNYJPA7Tu6xocaJ17gh8RsU/duqEUuX9QEiZextcpU54Q1rbcZ/p/JOWVYyygwAa 5dVOS5Drev9FnGGN8yt2tZE15CFKyU8eW19JHwDY+mLnZBeqURMvT+FeUStvayTLLKt1 pUM2LVB8ryARemnbnosxsYN+lfBNbOuNr3uP0SpZjHsKbFz6WCsXfkRwI42AzIoN/bkf XfV8EfVSfGkYLW7qNQfQyEJwTqdR3dfdX6q79pVXB1OjeH+RsTGuNCajuMorSnrEn4fn Q3aA== X-Gm-Message-State: AJIora8gQ7y/mCnEMpNjwJPeWyoBF/8yg0xCx2IteKHfosJEVuu9KYcW qMvYu3FrCO+ZHJcbbG3eKh3xq5l3/+syAlhuFbO9RGhSQImxtGFMYsVUYp0X8zEgtboXDCLzdPm GCShZo2SYkClKzV/fsO8= X-Received: by 2002:a19:a418:0:b0:478:fda4:e755 with SMTP id q24-20020a19a418000000b00478fda4e755mr2308238lfc.560.1655195161211; Tue, 14 Jun 2022 01:26:01 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vFQQT2IpmUvOEjf1BFtkOXGm3GzrqREJ/Ip8ZuY4P4JYVj4PMLDwNkr2+BCB4OR9JuMhxp5LJHUn61q8kbjwk= X-Received: by 2002:a19:a418:0:b0:478:fda4:e755 with SMTP id q24-20020a19a418000000b00478fda4e755mr2308229lfc.560.1655195160973; Tue, 14 Jun 2022 01:26:00 -0700 (PDT) MIME-Version: 1.0 References: <20220607120014.49823-1-fengchengwen@huawei.com> <20220614055900.22848-1-fengchengwen@huawei.com> <20220614055900.22848-2-fengchengwen@huawei.com> In-Reply-To: <20220614055900.22848-2-fengchengwen@huawei.com> From: David Marchand Date: Tue, 14 Jun 2022 10:25:49 +0200 Message-ID: Subject: Re: [PATCH v2 1/3] eal: fix segment fault when exit trace To: Chengwen Feng Cc: Thomas Monjalon , dev , "Burakov, Anatoly" , Jerin Jacob Kollanukkaran , Bruce Richardson Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Jun 14, 2022 at 8:06 AM Chengwen Feng wrote: > > Bug scenario: > 1. start testpmd: > dpdk-testpmd -l 4-6 -a 0000:7d:00.0 --trace=.* -- -i > 2. quit testpmd and then observed segment fault: > Bye... > Segmentation fault (core dumped) > > The root cause is that rte_trace_save() and eal_trace_fini() access > the huge pages which were cleanup by rte_eal_memory_detach(). > > This patch moves rte_trace_save() and eal_trace_fini() before > rte_eal_memory_detach() to fix the bug. > > Fixes: dfbc61a2f9a6 ("mem: detach memsegs on cleanup") > Cc: stable@dpdk.org > > Signed-off-by: Chengwen Feng > Tested-by: Jerin Jacob Reviewed-by: David Marchand -- David Marchand