From: David Marchand <david.marchand@redhat.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org, stable@dpdk.org,
Jingjing Wu <jingjing.wu@intel.com>,
Haiyue Wang <haiyue.wang@intel.com>,
Qi Zhang <qi.z.zhang@intel.com>,
Qiming Yang <qiming.yang@intel.com>
Subject: Re: [PATCH] net/iavf: remove error logs for vlan offloading
Date: Tue, 6 Feb 2024 11:20:24 +0100 [thread overview]
Message-ID: <CAJFAV8xaAFQORdhYtAMr2hCB7cZpRs+p+kyw1wW1y9pUcgQ14A@mail.gmail.com> (raw)
In-Reply-To: <ZcID1bWjdGaz-xFG@bricha3-MOBL.ger.corp.intel.com>
On Tue, Feb 6, 2024 at 11:04 AM Bruce Richardson
<bruce.richardson@intel.com> wrote:
> > @@ -631,7 +631,7 @@ iavf_dev_init_vlan(struct rte_eth_dev *dev)
> > RTE_ETH_VLAN_FILTER_MASK |
> > RTE_ETH_VLAN_EXTEND_MASK);
> > if (err) {
> > - PMD_DRV_LOG(ERR, "Failed to update vlan offload");
> > + PMD_DRV_LOG(INFO, "There is no support or the PF refused VLAN offloading");
>
> Minor nit, the phrase "no support" seems ambiguous on first reading, since
> it's not completely clear that the no support refers to vlan offloading.
>
> How about:
> "VLAN offloading is not supported, or offloading was refused by the PF"
It reads better, I'll send a v2.
Thanks Bruce.
--
David Marchand
next prev parent reply other threads:[~2024-02-06 10:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-06 9:56 David Marchand
2024-02-06 10:03 ` Bruce Richardson
2024-02-06 10:20 ` David Marchand [this message]
2024-02-06 10:34 ` [PATCH v2] " David Marchand
2024-02-06 12:43 ` Amiya Ranjan Mohakud
2024-02-06 12:46 ` David Marchand
2024-02-06 12:47 ` David Marchand
2024-02-06 12:54 ` Amiya Ranjan Mohakud
2024-02-29 11:54 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8xaAFQORdhYtAMr2hCB7cZpRs+p+kyw1wW1y9pUcgQ14A@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=haiyue.wang@intel.com \
--cc=jingjing.wu@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=qiming.yang@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).