From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6A9B243A99; Tue, 6 Feb 2024 11:20:42 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A7E4640DDA; Tue, 6 Feb 2024 11:20:41 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 24D604021E for ; Tue, 6 Feb 2024 11:20:40 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1707214839; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZicySNaBmXQWmJEVeY+Pypgezz8+tXAzZ8bNi9q4rEw=; b=VxYghzOYU4Z+atLIU0fNIDJzVtSq/cCehXOrVifKYqOaKoS5oxUAPpfM92r4H0g9MbzAyO y1zVTRXHrnLwOIy4bLGdR7rX2PedHbXzA94jan+eV26W86WhyElACst6rjvZ//CmMe+wPI cqEryFv/XOzodJ6T4ku5IGGjp6Akku0= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-187-atQ9r8IrPVi6_7WNr6s--A-1; Tue, 06 Feb 2024 05:20:38 -0500 X-MC-Unique: atQ9r8IrPVi6_7WNr6s--A-1 Received: by mail-lf1-f72.google.com with SMTP id 2adb3069b0e04-51145df2a08so256858e87.1 for ; Tue, 06 Feb 2024 02:20:38 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707214837; x=1707819637; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZicySNaBmXQWmJEVeY+Pypgezz8+tXAzZ8bNi9q4rEw=; b=nEpkEx2GlJLIVxWsVH5LUpqjqWm6o4rmc/ZsSa1MH+NV1NQ09mcWQDBEHx3RaWihNn YTOcfZSA6BEofBsCVH7iXVkKNiD479cdUe7DG+4Z+W2YdGq1tkSuKoYdq6pULSjwqE4M GdkXdNagIY2EPogVDy6Sgww/9/tA0nu9SpmsEBbeXHpo04+K+K6vyOCpA6eCnFaNecPY JO9oQgWaJo0ER/wd6fcCo+7olST1L1uCdIH6QhftDxvGXmp20rt69iZR4yHYyhBBPhd1 X+4uw+ZEfFXzKXwoZ120UQF3LFfrws4iUf+BpGWdZzc7VRlnzybefmke5iR7SN85cBql s0wQ== X-Gm-Message-State: AOJu0Yy1xvstvMOHE0U23ZsnKyMZ/yV+vaK5HPbFKOAtX8lfM4CW1drC /I1n2m/gmny0L57aIk2dyY0r4xxaWrcjimQFVKuwCEBGrSaayl8pwX0ujwjsnLeNz/DPI/BGX1u +DpCTd/WnDVzNPhqF0/fnCZt/x9MNm3Ie3INSk/y/eX3/gyPo1huA6kYvBUh18DQQfm7lIiZVOM JGfcNmF977QYzmKtA= X-Received: by 2002:a19:6414:0:b0:510:a6d:d48a with SMTP id y20-20020a196414000000b005100a6dd48amr2546362lfb.23.1707214836899; Tue, 06 Feb 2024 02:20:36 -0800 (PST) X-Google-Smtp-Source: AGHT+IEeHEAfUacebkqmcjeiem5OrC8fARj+RwfLsLUZkDGyiBb6m0kUi0T3HHBZfbEu0tEq8lISMLgZaBw6vwSLQng= X-Received: by 2002:a19:6414:0:b0:510:a6d:d48a with SMTP id y20-20020a196414000000b005100a6dd48amr2546351lfb.23.1707214836588; Tue, 06 Feb 2024 02:20:36 -0800 (PST) MIME-Version: 1.0 References: <20240206095607.339410-1-david.marchand@redhat.com> In-Reply-To: From: David Marchand Date: Tue, 6 Feb 2024 11:20:24 +0100 Message-ID: Subject: Re: [PATCH] net/iavf: remove error logs for vlan offloading To: Bruce Richardson Cc: dev@dpdk.org, stable@dpdk.org, Jingjing Wu , Haiyue Wang , Qi Zhang , Qiming Yang X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Feb 6, 2024 at 11:04=E2=80=AFAM Bruce Richardson wrote: > > @@ -631,7 +631,7 @@ iavf_dev_init_vlan(struct rte_eth_dev *dev) > > RTE_ETH_VLAN_FILTER_MASK | > > RTE_ETH_VLAN_EXTEND_MASK); > > if (err) { > > - PMD_DRV_LOG(ERR, "Failed to update vlan offload"); > > + PMD_DRV_LOG(INFO, "There is no support or the PF refused = VLAN offloading"); > > Minor nit, the phrase "no support" seems ambiguous on first reading, sinc= e > it's not completely clear that the no support refers to vlan offloading. > > How about: > "VLAN offloading is not supported, or offloading was refused by the PF" It reads better, I'll send a v2. Thanks Bruce. --=20 David Marchand